diff mbox series

iommu/arm-smmu-v3: Import IOMMUFD module namespace

Message ID 20241114-arm-smmu-v3-import-iommufd-module-ns-v1-1-c551e7b972e9@kernel.org (mailing list archive)
State New
Headers show
Series iommu/arm-smmu-v3: Import IOMMUFD module namespace | expand

Commit Message

Nathan Chancellor Nov. 14, 2024, 5:42 p.m. UTC
Commit 69d9b312f38a ("iommu/arm-smmu-v3: Support IOMMU_VIOMMU_ALLOC")
started using _iommufd_object_alloc() without importing the IOMMUFD
module namespace, resulting in a modpost warning:

  WARNING: modpost: module arm_smmu_v3 uses symbol _iommufd_object_alloc from namespace IOMMUFD, but does not import it.

Commit d68beb276ba2 ("iommu/arm-smmu-v3: Support IOMMU_HWPT_INVALIDATE
using a VIOMMU object") added another warning by using
iommufd_viommu_find_dev():

  WARNING: modpost: module arm_smmu_v3 uses symbol iommufd_viommu_find_dev from namespace IOMMUFD, but does not import it.

Import the IOMMUFD module namespace to resolve the warnings.

Fixes: 69d9b312f38a ("iommu/arm-smmu-v3: Support IOMMU_VIOMMU_ALLOC")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c | 2 ++
 1 file changed, 2 insertions(+)


---
base-commit: d68beb276ba26cec47350a6d468e967673ee0c56
change-id: 20241114-arm-smmu-v3-import-iommufd-module-ns-4d22fdd1f765

Best regards,

Comments

Jason Gunthorpe Nov. 15, 2024, 1:07 a.m. UTC | #1
On Thu, Nov 14, 2024 at 10:42:29AM -0700, Nathan Chancellor wrote:
> Commit 69d9b312f38a ("iommu/arm-smmu-v3: Support IOMMU_VIOMMU_ALLOC")
> started using _iommufd_object_alloc() without importing the IOMMUFD
> module namespace, resulting in a modpost warning:
> 
>   WARNING: modpost: module arm_smmu_v3 uses symbol _iommufd_object_alloc from namespace IOMMUFD, but does not import it.
> 
> Commit d68beb276ba2 ("iommu/arm-smmu-v3: Support IOMMU_HWPT_INVALIDATE
> using a VIOMMU object") added another warning by using
> iommufd_viommu_find_dev():
> 
>   WARNING: modpost: module arm_smmu_v3 uses symbol iommufd_viommu_find_dev from namespace IOMMUFD, but does not import it.
> 
> Import the IOMMUFD module namespace to resolve the warnings.
> 
> Fixes: 69d9b312f38a ("iommu/arm-smmu-v3: Support IOMMU_VIOMMU_ALLOC")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c | 2 ++
>  1 file changed, 2 insertions(+)

I guess the build bots don't run ARM64 all mod config?

Thanks, applied

Jason
diff mbox series

Patch

diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c
index c96cab6521a468d49a4c25566d08ea756211d545..6cc14d82399fa2666bd5374bb7d565171f6ce7ac 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c
@@ -397,3 +397,5 @@  struct iommufd_viommu *arm_vsmmu_alloc(struct device *dev,
 
 	return &vsmmu->core;
 }
+
+MODULE_IMPORT_NS(IOMMUFD);