| Message ID | 20241118-schema-v1-1-11b7c1583c0c@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add standalone ethernet MAC entries for qcs615 | expand |
On Mon, Nov 18, 2024 at 02:16:50PM +0800, Yijie Yang wrote: > The core version of EMAC on qcs615 has minor differences compared to that > on sm8150. During the bring-up routine, the loopback bit needs to be set, > and the Power-On Reset (POR) status of the registers isn't entirely > consistent with sm8150 either. > Therefore, it should be treated as a separate entity rather than a > fallback option. 'revise description' is not very specific. 'Drop fallback compatible for qcom,qcs615-ethqos' would be better. However, this is an ABI change. You could leave the binding/dts alone and only change the kernel driver to match on qcom,qcs615-ethqos to achieve what you need. If there's a reason why the ABI change is okay, then you need to detail that. Did the driver never work? Are there no users yet? > > Fixes: 32535b9410b8 ("dt-bindings: net: qcom,ethqos: add description for qcs615") > Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> > --- > Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > index 0bcd593a7bd093d4475908d82585c36dd6b3a284..576a52742ff45d4984388bbc0fcc91fa91bab677 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > @@ -23,12 +23,9 @@ properties: > - enum: > - qcom,qcs8300-ethqos > - const: qcom,sa8775p-ethqos > - - items: > - - enum: > - - qcom,qcs615-ethqos > - - const: qcom,sm8150-ethqos > - enum: > - qcom,qcs404-ethqos > + - qcom,qcs615-ethqos > - qcom,sa8775p-ethqos > - qcom,sc8280xp-ethqos > - qcom,sm8150-ethqos > > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml index 0bcd593a7bd093d4475908d82585c36dd6b3a284..576a52742ff45d4984388bbc0fcc91fa91bab677 100644 --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml @@ -23,12 +23,9 @@ properties: - enum: - qcom,qcs8300-ethqos - const: qcom,sa8775p-ethqos - - items: - - enum: - - qcom,qcs615-ethqos - - const: qcom,sm8150-ethqos - enum: - qcom,qcs404-ethqos + - qcom,qcs615-ethqos - qcom,sa8775p-ethqos - qcom,sc8280xp-ethqos - qcom,sm8150-ethqos
The core version of EMAC on qcs615 has minor differences compared to that on sm8150. During the bring-up routine, the loopback bit needs to be set, and the Power-On Reset (POR) status of the registers isn't entirely consistent with sm8150 either. Therefore, it should be treated as a separate entity rather than a fallback option. Fixes: 32535b9410b8 ("dt-bindings: net: qcom,ethqos: add description for qcs615") Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> --- Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)