| Message ID | 20241125092146.1561901-4-yuji2.ishikawa@toshiba.co.jp (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Toshiba Visconti Video Input Interface driver | expand |
Hi Ishikawa-san, Thank you for the patch. On Mon, Nov 25, 2024 at 06:21:41PM +0900, Yuji Ishikawa wrote: > Adds the Toshiba Visconti VIIF specific metadata format s/Adds/Add/ s/format/formats./ > > - V4L2_META_FMT_VISCONTI_VIIF_PARAMS for ISP parameters > - V4L2_META_FMT_VISCONTI_VIIF_STATS for ISP statistics > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> Assuming the documentation of the formats in subsequent patches is fine, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Changelog v10: > - add entry for V4L2_META_FMT_VISCONTI_VIIF_PARAMS > - add entry for V4L2_META_FMT_VISCONTI_VIIF_STATS > > Changelog v11: > - no change > > Changelog v12: > - add description for meta formats at v4l2-ioctl.c > > drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > include/uapi/linux/videodev2.h | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index 0304daa8471d..f7facb63b8ea 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -1470,6 +1470,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > case V4L2_META_FMT_RPI_BE_CFG: descr = "RPi PiSP BE Config format"; break; > case V4L2_META_FMT_RPI_FE_CFG: descr = "RPi PiSP FE Config format"; break; > case V4L2_META_FMT_RPI_FE_STATS: descr = "RPi PiSP FE Statistics format"; break; > + case V4L2_META_FMT_VISCONTI_VIIF_PARAMS: descr = "Visconti ISP Parameters"; break; > + case V4L2_META_FMT_VISCONTI_VIIF_STATS: descr = "Visconti ISP Statistics"; break; > case V4L2_META_FMT_GENERIC_8: descr = "8-bit Generic Metadata"; break; > case V4L2_META_FMT_GENERIC_CSI2_10: descr = "8-bit Generic Meta, 10b CSI-2"; break; > case V4L2_META_FMT_GENERIC_CSI2_12: descr = "8-bit Generic Meta, 12b CSI-2"; break; > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index a5418759e2ba..9e1f66fdf038 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -863,6 +863,10 @@ struct v4l2_pix_format { > #define V4L2_META_FMT_RPI_FE_CFG v4l2_fourcc('R', 'P', 'F', 'C') /* PiSP FE configuration */ > #define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S') /* PiSP FE stats */ > > +/* Vendor specific - used for Visconti VIIF sub-system */ > +#define V4L2_META_FMT_VISCONTI_VIIF_PARAMS v4l2_fourcc('V', 'I', 'F', 'P') /* ISP Params */ > +#define V4L2_META_FMT_VISCONTI_VIIF_STATS v4l2_fourcc('V', 'I', 'F', 'S') /* ISP Stats */ > + > #ifdef __KERNEL__ > /* > * Line-based metadata formats. Remember to update v4l_fill_fmtdesc() when
Hello Laurent. Thank you for your review comments. > -----Original Message----- > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Sent: Thursday, January 2, 2025 10:10 PM > To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) > <yuji2.ishikawa@toshiba.co.jp> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Rob Herring > <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > <conor+dt@kernel.org>; Sakari Ailus <sakari.ailus@linux.intel.com>; Hans > Verkuil <hverkuil-cisco@xs4all.nl>; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ > □ＤＩＴ○ＯＳＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>; > linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org > Subject: Re: [PATCH v12 3/8] media: uapi: add visconti viif meta buffer format > > Hi Ishikawa-san, > > Thank you for the patch. > > > On Mon, Nov 25, 2024 at 06:21:41PM +0900, Yuji Ishikawa wrote: > > Adds the Toshiba Visconti VIIF specific metadata format > > s/Adds/Add/ > s/format/formats./ > I'll fix the commit message. > > > > - V4L2_META_FMT_VISCONTI_VIIF_PARAMS for ISP parameters > > - V4L2_META_FMT_VISCONTI_VIIF_STATS for ISP statistics > > > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> > > Assuming the documentation of the formats in subsequent patches is fine, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > Changelog v10: > > - add entry for V4L2_META_FMT_VISCONTI_VIIF_PARAMS > > - add entry for V4L2_META_FMT_VISCONTI_VIIF_STATS > > > > Changelog v11: > > - no change > > > > Changelog v12: > > - add description for meta formats at v4l2-ioctl.c > > > > drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > > include/uapi/linux/videodev2.h | 4 ++++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c > > b/drivers/media/v4l2-core/v4l2-ioctl.c > > index 0304daa8471d..f7facb63b8ea 100644 > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > @@ -1470,6 +1470,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc > *fmt) > > case V4L2_META_FMT_RPI_BE_CFG: descr = "RPi PiSP BE Config > format"; break; > > case V4L2_META_FMT_RPI_FE_CFG: descr = "RPi PiSP FE Config > format"; break; > > case V4L2_META_FMT_RPI_FE_STATS: descr = "RPi PiSP FE > Statistics > > format"; break; > > + case V4L2_META_FMT_VISCONTI_VIIF_PARAMS: descr = "Visconti > ISP Parameters"; break; > > + case V4L2_META_FMT_VISCONTI_VIIF_STATS: descr = "Visconti ISP > > +Statistics"; break; The media-ci has reported the following errors. Is it all right to leave these errors unfixed and keep the lines with the same style as other entries? # Test checkpatch:./0003-media-uapi-add-visconti-viif-meta-buffer-format.patch ERROR: trailing statements should be on next line #26: FILE: drivers/media/v4l2-core/v4l2-ioctl.c:1473: +case V4L2_META_FMT_VISCONTI_VIIF_PARAMS: descr = "Visconti ISP +Parameters"; break; ERROR: trailing statements should be on next line #27: FILE: drivers/media/v4l2-core/v4l2-ioctl.c:1474: +case V4L2_META_FMT_VISCONTI_VIIF_STATS: descr = "Visconti ISP +Statistics"; break; total: 2 errors, 0 warnings, 0 checks, 18 lines checked > > case V4L2_META_FMT_GENERIC_8: descr = "8-bit Generic > Metadata"; break; > > case V4L2_META_FMT_GENERIC_CSI2_10: descr = "8-bit > Generic Meta, 10b CSI-2"; break; > > case V4L2_META_FMT_GENERIC_CSI2_12: descr = "8-bit > Generic Meta, 12b CSI-2"; break; > > diff --git a/include/uapi/linux/videodev2.h > > b/include/uapi/linux/videodev2.h index a5418759e2ba..9e1f66fdf038 > > 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -863,6 +863,10 @@ struct v4l2_pix_format { > > #define V4L2_META_FMT_RPI_FE_CFG v4l2_fourcc('R', 'P', 'F', 'C') /* > PiSP FE configuration */ > > #define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S') /* > PiSP FE stats */ > > > > +/* Vendor specific - used for Visconti VIIF sub-system */ > > +#define V4L2_META_FMT_VISCONTI_VIIF_PARAMS v4l2_fourcc('V', 'I', 'F', > 'P') /* ISP Params */ > > +#define V4L2_META_FMT_VISCONTI_VIIF_STATS v4l2_fourcc('V', 'I', 'F', > 'S') /* ISP Stats */ > > + > > #ifdef __KERNEL__ > > /* > > * Line-based metadata formats. Remember to update v4l_fill_fmtdesc() > > when > > -- > Regards, > > Laurent Pinchart
On Mon, Jan 20, 2025 at 12:15:43AM +0000, yuji2.ishikawa@toshiba.co.jp wrote: > On Thursday, January 2, 2025 10:10 PM, Laurent Pinchart wrote: > > On Mon, Nov 25, 2024 at 06:21:41PM +0900, Yuji Ishikawa wrote: > > > Adds the Toshiba Visconti VIIF specific metadata format > > > > s/Adds/Add/ > > s/format/formats./ > > I'll fix the commit message. > > > > - V4L2_META_FMT_VISCONTI_VIIF_PARAMS for ISP parameters > > > - V4L2_META_FMT_VISCONTI_VIIF_STATS for ISP statistics > > > > > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> > > > > Assuming the documentation of the formats in subsequent patches is fine, > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > --- > > > Changelog v10: > > > - add entry for V4L2_META_FMT_VISCONTI_VIIF_PARAMS > > > - add entry for V4L2_META_FMT_VISCONTI_VIIF_STATS > > > > > > Changelog v11: > > > - no change > > > > > > Changelog v12: > > > - add description for meta formats at v4l2-ioctl.c > > > > > > drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > > > include/uapi/linux/videodev2.h | 4 ++++ > > > 2 files changed, 6 insertions(+) > > > > > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c > > > b/drivers/media/v4l2-core/v4l2-ioctl.c > > > index 0304daa8471d..f7facb63b8ea 100644 > > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > > @@ -1470,6 +1470,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > > > case V4L2_META_FMT_RPI_BE_CFG: descr = "RPi PiSP BE Config format"; break; > > > case V4L2_META_FMT_RPI_FE_CFG: descr = "RPi PiSP FE Config format"; break; > > > case V4L2_META_FMT_RPI_FE_STATS: descr = "RPi PiSP FE Statistics format"; break; > > > + case V4L2_META_FMT_VISCONTI_VIIF_PARAMS: descr = "Visconti ISP Parameters"; break; > > > + case V4L2_META_FMT_VISCONTI_VIIF_STATS: descr = "Visconti ISP Statistics"; break; > > The media-ci has reported the following errors. > Is it all right to leave these errors unfixed and keep the lines with > the same style as other entries? Yes, you can ignore those issues. > # Test checkpatch:./0003-media-uapi-add-visconti-viif-meta-buffer-format.patch > ERROR: trailing statements should be on next line > #26: FILE: drivers/media/v4l2-core/v4l2-ioctl.c:1473: > +case V4L2_META_FMT_VISCONTI_VIIF_PARAMS: descr = "Visconti ISP > +Parameters"; break; > > ERROR: trailing statements should be on next line > #27: FILE: drivers/media/v4l2-core/v4l2-ioctl.c:1474: > +case V4L2_META_FMT_VISCONTI_VIIF_STATS: descr = "Visconti ISP > +Statistics"; break; > > total: 2 errors, 0 warnings, 0 checks, 18 lines checked > > > > case V4L2_META_FMT_GENERIC_8: descr = "8-bit Generic Metadata"; break; > > > case V4L2_META_FMT_GENERIC_CSI2_10: descr = "8-bit Generic Meta, 10b CSI-2"; break; > > > case V4L2_META_FMT_GENERIC_CSI2_12: descr = "8-bit Generic Meta, 12b CSI-2"; break; > > > diff --git a/include/uapi/linux/videodev2.h > > > b/include/uapi/linux/videodev2.h index a5418759e2ba..9e1f66fdf038 > > > 100644 > > > --- a/include/uapi/linux/videodev2.h > > > +++ b/include/uapi/linux/videodev2.h > > > @@ -863,6 +863,10 @@ struct v4l2_pix_format { > > > #define V4L2_META_FMT_RPI_FE_CFG v4l2_fourcc('R', 'P', 'F', 'C') /* PiSP FE configuration */ > > > #define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S') /* PiSP FE stats */ > > > > > > +/* Vendor specific - used for Visconti VIIF sub-system */ > > > +#define V4L2_META_FMT_VISCONTI_VIIF_PARAMS v4l2_fourcc('V', 'I', 'F', 'P') /* ISP Params */ > > > +#define V4L2_META_FMT_VISCONTI_VIIF_STATS v4l2_fourcc('V', 'I', 'F', 'S') /* ISP Stats */ > > > + > > > #ifdef __KERNEL__ > > > /* > > > * Line-based metadata formats. Remember to update v4l_fill_fmtdesc() when
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index 0304daa8471d..f7facb63b8ea 100644 --- a/drivers/media/v4l2-core/v4l2-ioctl.c +++ b/drivers/media/v4l2-core/v4l2-ioctl.c @@ -1470,6 +1470,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) case V4L2_META_FMT_RPI_BE_CFG: descr = "RPi PiSP BE Config format"; break; case V4L2_META_FMT_RPI_FE_CFG: descr = "RPi PiSP FE Config format"; break; case V4L2_META_FMT_RPI_FE_STATS: descr = "RPi PiSP FE Statistics format"; break; + case V4L2_META_FMT_VISCONTI_VIIF_PARAMS: descr = "Visconti ISP Parameters"; break; + case V4L2_META_FMT_VISCONTI_VIIF_STATS: descr = "Visconti ISP Statistics"; break; case V4L2_META_FMT_GENERIC_8: descr = "8-bit Generic Metadata"; break; case V4L2_META_FMT_GENERIC_CSI2_10: descr = "8-bit Generic Meta, 10b CSI-2"; break; case V4L2_META_FMT_GENERIC_CSI2_12: descr = "8-bit Generic Meta, 12b CSI-2"; break; diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index a5418759e2ba..9e1f66fdf038 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -863,6 +863,10 @@ struct v4l2_pix_format { #define V4L2_META_FMT_RPI_FE_CFG v4l2_fourcc('R', 'P', 'F', 'C') /* PiSP FE configuration */ #define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S') /* PiSP FE stats */ +/* Vendor specific - used for Visconti VIIF sub-system */ +#define V4L2_META_FMT_VISCONTI_VIIF_PARAMS v4l2_fourcc('V', 'I', 'F', 'P') /* ISP Params */ +#define V4L2_META_FMT_VISCONTI_VIIF_STATS v4l2_fourcc('V', 'I', 'F', 'S') /* ISP Stats */ + #ifdef __KERNEL__ /* * Line-based metadata formats. Remember to update v4l_fill_fmtdesc() when
Adds the Toshiba Visconti VIIF specific metadata format - V4L2_META_FMT_VISCONTI_VIIF_PARAMS for ISP parameters - V4L2_META_FMT_VISCONTI_VIIF_STATS for ISP statistics Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> --- Changelog v10: - add entry for V4L2_META_FMT_VISCONTI_VIIF_PARAMS - add entry for V4L2_META_FMT_VISCONTI_VIIF_STATS Changelog v11: - no change Changelog v12: - add description for meta formats at v4l2-ioctl.c drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ include/uapi/linux/videodev2.h | 4 ++++ 2 files changed, 6 insertions(+)