| Message ID | 20241202-dt-bcm2712-fixes-v1-5-fac67cc2f98a@raspberrypi.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/vc4: Fixup DT and DT binding issues from recent patchset | expand |
On 02/12/2024 15:31, Dave Stevenson wrote: > BCM2712 DT was producing dtbinding validation errors of s/DT/DTS/ No one uses term like "dtbinding". Use full make target name or DT schema. > > interrupt-controller@7cd00000: 'interrupt-controller' is a required > property > interrupt-controller@7cd00000: '#interrupt-cells' is a required property > > Fix them by adding the required flags. But are these valid? Why do you think that binding is correct? Or you just silence the warning regardless whether this matches the hardware? Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi index f42fad2d8b37..0ba076ab9caf 100644 --- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi +++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi @@ -224,6 +224,8 @@ mailbox: mailbox@7c013880 { local_intc: interrupt-controller@7cd00000 { compatible = "brcm,bcm2836-l1-intc"; reg = <0x7cd00000 0x100>; + interrupt-controller; + #interrupt-cells = <2>; }; uart10: serial@7d001000 {
BCM2712 DT was producing dtbinding validation errors of interrupt-controller@7cd00000: 'interrupt-controller' is a required property interrupt-controller@7cd00000: '#interrupt-cells' is a required property Fix them by adding the required flags. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> --- arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 2 ++ 1 file changed, 2 insertions(+)