| Message ID | 20241202-dt-bcm2712-fixes-v1-6-fac67cc2f98a@raspberrypi.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/vc4: Fixup DT and DT binding issues from recent patchset | expand |
Hi Dave, Am 02.12.24 um 15:31 schrieb Dave Stevenson: > BCM2711 DT was producing dtbinding validation errors of > > interrupt-controller@40000000: 'interrupt-controller' is a required > property > interrupt-controller@40000000: '#interrupt-cells' is a required property > > Fix them by adding the required flags. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Did you actually test these changes, because the last time [1] it broke the boot of RPi 4 and likely for RPi 5, too? Best regards [1] - https://lore.kernel.org/linux-arm-kernel/07154679-42bc-43ba-8b72-62083ed78a4d@gmx.net/ > --- > arch/arm/boot/dts/broadcom/bcm2711.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/broadcom/bcm2711.dtsi b/arch/arm/boot/dts/broadcom/bcm2711.dtsi > index e4e42af21ef3..313b1046d74f 100644 > --- a/arch/arm/boot/dts/broadcom/bcm2711.dtsi > +++ b/arch/arm/boot/dts/broadcom/bcm2711.dtsi > @@ -51,6 +51,8 @@ soc { > local_intc: interrupt-controller@40000000 { > compatible = "brcm,bcm2836-l1-intc"; > reg = <0x40000000 0x100>; > + interrupt-controller; > + #interrupt-cells = <2>; > }; > > gicv2: interrupt-controller@40041000 { >
diff --git a/arch/arm/boot/dts/broadcom/bcm2711.dtsi b/arch/arm/boot/dts/broadcom/bcm2711.dtsi index e4e42af21ef3..313b1046d74f 100644 --- a/arch/arm/boot/dts/broadcom/bcm2711.dtsi +++ b/arch/arm/boot/dts/broadcom/bcm2711.dtsi @@ -51,6 +51,8 @@ soc { local_intc: interrupt-controller@40000000 { compatible = "brcm,bcm2836-l1-intc"; reg = <0x40000000 0x100>; + interrupt-controller; + #interrupt-cells = <2>; }; gicv2: interrupt-controller@40041000 {
BCM2711 DT was producing dtbinding validation errors of interrupt-controller@40000000: 'interrupt-controller' is a required property interrupt-controller@40000000: '#interrupt-cells' is a required property Fix them by adding the required flags. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> --- arch/arm/boot/dts/broadcom/bcm2711.dtsi | 2 ++ 1 file changed, 2 insertions(+)