ARM: sun8i: r40/a40i: rm unneeded PH23 setup which resets Banana Pi M2 Ultra V1.1

Commit Message

[e-mail] Dec. 6, 2024, 8:20 p.m. UTC

Banana Pi M2 Ultra V1.1 board resets immediately when the usb core tries
to setup PH23 GPIO. It turned out that the V1.0 board USB-A ports are
always power supplied and according to the board scheme PH23 is simply
not connected.

So remove the PH23 setup: Doesn't harm V1.0 (with R40) and let V1.1
(with A40i) start

Signed-off-by: Hermann Lauer <[e-mail]>
---

# HG changeset patch
# Parent  236ffa4558b03bbc654515fae80a7a2387f06cd4

Comments

Andre Przywara Dec. 6, 2024, 10:53 p.m. UTC | #1

Hi Hermann,

thanks for sending the patch!

The subject line would need to be shortened, something like:
ARM: dts: sun8i-r40: remove unused GPIO regulator
(no need to sweat it with the A40i/R40/A40 names, they are all the same 
chip, essentially)

And please add the maintainers in "To:", and put the lists on Cc:, as 
shown by:
$ scripts/get_maintainer.pl 0001-*

On 06/12/2024 20:20, [e-mail] wrote:
> Banana Pi M2 Ultra V1.1 board resets immediately when the usb core tries
> to setup PH23 GPIO. It turned out that the V1.0 board USB-A ports are
> always power supplied and according to the board scheme PH23 is simply
> not connected.
> 
> So remove the PH23 setup: Doesn't harm V1.0 (with R40) and let V1.1
> (with A40i) start
> 
> Signed-off-by: Hermann Lauer <[e-mail]>
> ---
> 
> # HG changeset patch
> # Parent  236ffa4558b03bbc654515fae80a7a2387f06cd4

Please remove those two lines, if possible.

> diff --git a/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts
> --- a/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts
> +++ b/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts
> @@ -347,7 +347,5 @@
>   };
>   
>   &usbphy {
> -	usb1_vbus-supply = <&reg_vcc5v0>;
> -	usb2_vbus-supply = <&reg_vcc5v0>;

So while this fixes your immediate problem, the regulator with the 
deadly GPIO is still in. For once it's not needed anymore, but more 
importantly it still references the problematic GPIO, so please remove 
the whole reg_vcc5v0 regulator node altogether as well.

Cheers,
Andre



>   	status = "okay";
>   };
>

Patch

diff --git a/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts
--- a/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts
+++ b/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts
@@ -347,7 +347,5 @@ 
 };
 
 &usbphy {
-	usb1_vbus-supply = <&reg_vcc5v0>;
-	usb2_vbus-supply = <&reg_vcc5v0>;
 	status = "okay";
 };