| Message ID | 20250114160630.1122885-1-robert.marko@sartura.hr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iommu/arm-smmu-v3: add missing header | expand |
On Tue, Jan 14, 2025 at 05:05:56PM +0100, Robert Marko wrote: > str_read_write is currently undeclared and thus compilation will fail with: > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1911:25: error: implicit declaration of function ‘str_read_write’; did you mean ‘sb_end_write’? [-Wimplicit-function-declaration] > > So include the missing linux/string_choices.h header to fix compilation. > > Fixes: f2c77f6e41e6 ("iommu/arm-smmu-v3: Use str_read_write helper w/ logs") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202501111926.qOpnlK9J-lkp@intel.com/ > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 0e4cbb2c64d7..a0e395da8a88 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -26,6 +26,7 @@ > #include <linux/pci.h> > #include <linux/pci-ats.h> > #include <linux/platform_device.h> > +#include <linux/string_choices.h> > #include <kunit/visibility.h> > #include <uapi/linux/iommufd.h> Hi Robert, This fix has already been merged to the arm/smmu/updates branch [1] which should appear in -next when Joerg next rebuilds the branch. Thanks, Praan [1] https://git.kernel.org/pub/scm/linux/kernel/git/iommu/linux.git/commit/?h=arm/smmu/updates > > -- > 2.47.1 > >
On Thu, Jan 16, 2025 at 4:09 AM Pranjal Shrivastava <praan@google.com> wrote: > > On Tue, Jan 14, 2025 at 05:05:56PM +0100, Robert Marko wrote: > > str_read_write is currently undeclared and thus compilation will fail with: > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1911:25: error: implicit declaration of function ‘str_read_write’; did you mean ‘sb_end_write’? [-Wimplicit-function-declaration] > > > > So include the missing linux/string_choices.h header to fix compilation. > > > > Fixes: f2c77f6e41e6 ("iommu/arm-smmu-v3: Use str_read_write helper w/ logs") > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202501111926.qOpnlK9J-lkp@intel.com/ > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > --- > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > index 0e4cbb2c64d7..a0e395da8a88 100644 > > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > @@ -26,6 +26,7 @@ > > #include <linux/pci.h> > > #include <linux/pci-ats.h> > > #include <linux/platform_device.h> > > +#include <linux/string_choices.h> > > #include <kunit/visibility.h> > > #include <uapi/linux/iommufd.h> > > Hi Robert, > > This fix has already been merged to the arm/smmu/updates branch [1] > which should appear in -next when Joerg next rebuilds the branch. Hi Praan, I looked for an existing fix but couldn't find it before sending it. Glad that it was already fixed, please ignore this patch then. Regards, Robert > > Thanks, > Praan > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/iommu/linux.git/commit/?h=arm/smmu/updates > > > > > -- > > 2.47.1 > > > >
diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c index 0e4cbb2c64d7..a0e395da8a88 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -26,6 +26,7 @@ #include <linux/pci.h> #include <linux/pci-ats.h> #include <linux/platform_device.h> +#include <linux/string_choices.h> #include <kunit/visibility.h> #include <uapi/linux/iommufd.h>
str_read_write is currently undeclared and thus compilation will fail with: drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1911:25: error: implicit declaration of function ‘str_read_write’; did you mean ‘sb_end_write’? [-Wimplicit-function-declaration] So include the missing linux/string_choices.h header to fix compilation. Fixes: f2c77f6e41e6 ("iommu/arm-smmu-v3: Use str_read_write helper w/ logs") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202501111926.qOpnlK9J-lkp@intel.com/ Signed-off-by: Robert Marko <robert.marko@sartura.hr> --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 + 1 file changed, 1 insertion(+)