| Message ID | 20250202-arm-brbe-v19-v19-5-1c1300802385@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64/perf: Enable branch stack sampling | expand |
On 2/3/25 06:12, Rob Herring (Arm) wrote: > Currently (armv7|krait_|scorpion_)pmu_enable_event() start by disabling > the event counter it has been asked to enable. This should not be > necessary as the counter (and the PMU as a whole) should not be active > when *_enable_event() is called. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > drivers/perf/arm_v7_pmu.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/perf/arm_v7_pmu.c b/drivers/perf/arm_v7_pmu.c > index 7fa88e3b64e0..17831e1920bd 100644 > --- a/drivers/perf/arm_v7_pmu.c > +++ b/drivers/perf/arm_v7_pmu.c > @@ -857,8 +857,6 @@ static void armv7pmu_enable_event(struct perf_event *event) > return; > } > > - armv7_pmnc_disable_counter(idx); > - > /* > * Set event (if destined for PMNx counters) > * We only need to set the event for the cycle counter if we > @@ -1450,8 +1448,6 @@ static void krait_pmu_enable_event(struct perf_event *event) > struct hw_perf_event *hwc = &event->hw; > int idx = hwc->idx; > > - armv7_pmnc_disable_counter(idx); > - > /* > * Set event (if destined for PMNx counters) > * We set the event for the cycle counter because we > @@ -1762,8 +1758,6 @@ static void scorpion_pmu_enable_event(struct perf_event *event) > struct hw_perf_event *hwc = &event->hw; > int idx = hwc->idx; > > - armv7_pmnc_disable_counter(idx); > - > /* > * Set event (if destined for PMNx counters) > * We don't set the event for the cycle counter because we > LGTM Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
diff --git a/drivers/perf/arm_v7_pmu.c b/drivers/perf/arm_v7_pmu.c index 7fa88e3b64e0..17831e1920bd 100644 --- a/drivers/perf/arm_v7_pmu.c +++ b/drivers/perf/arm_v7_pmu.c @@ -857,8 +857,6 @@ static void armv7pmu_enable_event(struct perf_event *event) return; } - armv7_pmnc_disable_counter(idx); - /* * Set event (if destined for PMNx counters) * We only need to set the event for the cycle counter if we @@ -1450,8 +1448,6 @@ static void krait_pmu_enable_event(struct perf_event *event) struct hw_perf_event *hwc = &event->hw; int idx = hwc->idx; - armv7_pmnc_disable_counter(idx); - /* * Set event (if destined for PMNx counters) * We set the event for the cycle counter because we @@ -1762,8 +1758,6 @@ static void scorpion_pmu_enable_event(struct perf_event *event) struct hw_perf_event *hwc = &event->hw; int idx = hwc->idx; - armv7_pmnc_disable_counter(idx); - /* * Set event (if destined for PMNx counters) * We don't set the event for the cycle counter because we
Currently (armv7|krait_|scorpion_)pmu_enable_event() start by disabling the event counter it has been asked to enable. This should not be necessary as the counter (and the PMU as a whole) should not be active when *_enable_event() is called. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- drivers/perf/arm_v7_pmu.c | 6 ------ 1 file changed, 6 deletions(-)