| Message ID | 20250205091455.4593-1-wahrenst@gmx.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dmaengine: fsl-edma: Add missing newlines to log messages | expand |
On Wed, Feb 05, 2025 at 10:14:55AM +0100, Stefan Wahren wrote: > Not all log messages have a newline at the end. So fix it. > > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> > --- Reviewed-by: Frank Li <Frank.Li@nxp.com> > drivers/dma/fsl-edma-main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c > index f989b6c9c0a9..760c9e3e374c 100644 > --- a/drivers/dma/fsl-edma-main.c > +++ b/drivers/dma/fsl-edma-main.c > @@ -164,7 +164,7 @@ static bool fsl_edma_srcid_in_use(struct fsl_edma_engine *fsl_edma, u32 srcid) > fsl_chan = &fsl_edma->chans[i]; > > if (fsl_chan->srcid && srcid == fsl_chan->srcid) { > - dev_err(&fsl_chan->pdev->dev, "The srcid is in use, can't use!"); > + dev_err(&fsl_chan->pdev->dev, "The srcid is in use, can't use!\n"); > return true; > } > } > @@ -822,7 +822,7 @@ static int fsl_edma_suspend_late(struct device *dev) > spin_lock_irqsave(&fsl_chan->vchan.lock, flags); > /* Make sure chan is idle or will force disable. */ > if (unlikely(fsl_chan->status == DMA_IN_PROGRESS)) { > - dev_warn(dev, "WARN: There is non-idle channel."); > + dev_warn(dev, "WARN: There is non-idle channel.\n"); > fsl_edma_disable_request(fsl_chan); > fsl_edma_chan_mux(fsl_chan, 0, false); > } > -- > 2.34.1 >
On Wed, 05 Feb 2025 10:14:55 +0100, Stefan Wahren wrote: > Not all log messages have a newline at the end. So fix it. > > Applied, thanks! [1/1] dmaengine: fsl-edma: Add missing newlines to log messages commit: 1c4c8609d498173382913b8ef6a105f3e6ff3472 Best regards,
diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c index f989b6c9c0a9..760c9e3e374c 100644 --- a/drivers/dma/fsl-edma-main.c +++ b/drivers/dma/fsl-edma-main.c @@ -164,7 +164,7 @@ static bool fsl_edma_srcid_in_use(struct fsl_edma_engine *fsl_edma, u32 srcid) fsl_chan = &fsl_edma->chans[i]; if (fsl_chan->srcid && srcid == fsl_chan->srcid) { - dev_err(&fsl_chan->pdev->dev, "The srcid is in use, can't use!"); + dev_err(&fsl_chan->pdev->dev, "The srcid is in use, can't use!\n"); return true; } } @@ -822,7 +822,7 @@ static int fsl_edma_suspend_late(struct device *dev) spin_lock_irqsave(&fsl_chan->vchan.lock, flags); /* Make sure chan is idle or will force disable. */ if (unlikely(fsl_chan->status == DMA_IN_PROGRESS)) { - dev_warn(dev, "WARN: There is non-idle channel."); + dev_warn(dev, "WARN: There is non-idle channel.\n"); fsl_edma_disable_request(fsl_chan); fsl_edma_chan_mux(fsl_chan, 0, false); }
Not all log messages have a newline at the end. So fix it. Signed-off-by: Stefan Wahren <wahrenst@gmx.net> --- drivers/dma/fsl-edma-main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.34.1