| Message ID | 20250205124235.53285-7-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add of_get_available_child_by_name() | expand |
On Wed, Feb 05, 2025 at 12:42:26PM +0000, Biju Das wrote: > Use the helper of_get_available_child_by_name() to simplify > owl_emac_mdio_init(). > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > previous v2->v2: > * Dropped using _free(). > v1-> previous v2: > * Dropped duplicate mdio_node declaration. Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/drivers/net/ethernet/actions/owl-emac.c b/drivers/net/ethernet/actions/owl-emac.c index 115f48b3342c..0a08da799255 100644 --- a/drivers/net/ethernet/actions/owl-emac.c +++ b/drivers/net/ethernet/actions/owl-emac.c @@ -1325,15 +1325,10 @@ static int owl_emac_mdio_init(struct net_device *netdev) struct device_node *mdio_node; int ret; - mdio_node = of_get_child_by_name(dev->of_node, "mdio"); + mdio_node = of_get_available_child_by_name(dev->of_node, "mdio"); if (!mdio_node) return -ENODEV; - if (!of_device_is_available(mdio_node)) { - ret = -ENODEV; - goto err_put_node; - } - priv->mii = devm_mdiobus_alloc(dev); if (!priv->mii) { ret = -ENOMEM;
Use the helper of_get_available_child_by_name() to simplify owl_emac_mdio_init(). Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- previous v2->v2: * Dropped using _free(). v1-> previous v2: * Dropped duplicate mdio_node declaration. --- drivers/net/ethernet/actions/owl-emac.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)