| Message ID | 20250207014437.17920-3-crystal.guo@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add an interface to get current DDR data rate | expand |
On 07/02/2025 02:42, Crystal Guo wrote: > A MediaTek DRAM controller interface to provide the current DDR data rate. > Duplicated patch. You also ignored several comments so that's a NAK. <form letter> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. </form letter> Best regards, Krzysztof
On Sun, 2025-02-09 at 11:51 +0100, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 07/02/2025 02:42, Crystal Guo wrote: > > A MediaTek DRAM controller interface to provide the current DDR > > data rate. Hi Krzysztof, Regarding this commit message, you previously commented as follows: "Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L5 " May I ask if this means that the description "A MediaTek DRAM controller interface to provide the current DDR data rate." needs to be split into two lines? The total number of characters in this description is 74. Thanks Crystal > > > > Duplicated patch. > > You also ignored several comments so that's a NAK. Apologies for any confusion. This latest patch and https://patchwork.kernel.org/project/linux-mediatek/list/?series=931186 do indeed overlap. Due to the fact that https://patchwork.kernel.org/project/linux-mediatek/list/?series=931186 was pushed based on an incorrect base, please ignore the patch series 931186. This latest patch is intended to address the comments provided for the first version in https://patchwork.kernel.org/project/linux-mediatek/list/?series=917099 . It is based on a clean kernel, so could you help review this version? Thanks. Best regards Crystal > > <form letter> > This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion > and > either implement all requested changes or keep discussing them. > > Thank you. > </form letter> > > Best regards, > Krzysztof
On 12/02/2025 04:50, Crystal Guo (郭晶) wrote: > On Sun, 2025-02-09 at 11:51 +0100, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 07/02/2025 02:42, Crystal Guo wrote: >>> A MediaTek DRAM controller interface to provide the current DDR >>> data rate. > > Hi Krzysztof, > > Regarding this commit message, you previously commented as follows: > "Please wrap commit message according to Linux coding style / > submission process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L5 > " > > May I ask if this means that the description "A MediaTek DRAM > controller interface to provide the current DDR data rate." needs to be > split into two lines? The total number of characters in this > description is 74. And what is the wrapping limit? Best regards, Krzysztof
On Wed, 2025-02-12 at 06:34 +0100, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 12/02/2025 04:50, Crystal Guo (郭晶) wrote: > > On Sun, 2025-02-09 at 11:51 +0100, Krzysztof Kozlowski wrote: > > > External email : Please do not click links or open attachments > > > until > > > you have verified the sender or the content. > > > > > > > > > On 07/02/2025 02:42, Crystal Guo wrote: > > > > A MediaTek DRAM controller interface to provide the current DDR > > > > data rate. > > > > Hi Krzysztof, > > > > Regarding this commit message, you previously commented as follows: > > "Please wrap commit message according to Linux coding style / > > submission process (neither too early nor over the limit): > > https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst*L5__;Iw!!CTRNKA9wMg0ARbw!jY0i3mRY0mA3yLhvxm42NZiFnheY6L5Q9dKVJkv911eQ9Z03SBi3-Mgslg_fOzkwAfkJJODcjD6Ka5_I$ > > " > > > > May I ask if this means that the description "A MediaTek DRAM > > controller interface to provide the current DDR data rate." needs > > to be > > split into two lines? The total number of characters in this > > description is 74. > > And what is the wrapping limit? > > > Best regards, > Krzysztof The wrapping limit for the commit message body is 75 columns. I will update the commit message body in next version: A MediaTek DRAM controller interface to provide the current DDR data rate. Is this Okay? Best regards, Crystal
diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,dramc.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,dramc.yaml new file mode 100644 index 000000000000..8bdacfc36cb5 --- /dev/null +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,dramc.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2025 MediaTek Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/memory-controllers/mediatek,dramc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek DRAM Controller (DRAMC) + +maintainers: + - Crystal Guo <crystal.guo@mediatek.com> + +description: + A MediaTek DRAM controller interface to provide the current data rate of DRAM. + +properties: + compatible: + items: + - enum: + - mediatek,mt8196-dramc + + reg: + items: + - description: anaphy registers + - description: ddrphy registers + +additionalProperties: false + +required: + - compatible + - reg + +examples: + - | + soc { + #address-cells = <2>; + #size-cells = <2>; + + memory-controller@10236000 { + compatible = "mediatek,mt8196-dramc"; + reg = <0 0x10236000 0 0x2000>, + <0 0x10238000 0 0x2000>; + }; + };
A MediaTek DRAM controller interface to provide the current DDR data rate. Signed-off-by: Crystal Guo <crystal.guo@mediatek.com> --- .../memory-controllers/mediatek,dramc.yaml | 44 +++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,dramc.yaml