diff mbox series

[resubmit2] spi: atmel-quadspi: remove references to runtime PM on error path

Message ID 20250207122145.162183-2-csokas.bence@prolan.hu (mailing list archive)
State New
Headers show
Series [resubmit2] spi: atmel-quadspi: remove references to runtime PM on error path | expand

Commit Message

Bence Csókás Feb. 7, 2025, 12:21 p.m. UTC 
From: Claudiu Beznea <claudiu.beznea@microchip.com>

There is no need to call runtime PM put APIs on error path of
`atmel_qspi_sama7g5_transfer()` as the caller (`atmel_qspi_exec_op()`)
of it will take care of this if needed.

Fixes: 5af42209a4d2 ("spi: atmel-quadspi: Add support for sama7g5 QSPI")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>
Reported-by: Alexander Dahl <ada@thorsis.com>
Closes: https://lore.kernel.org/linux-spi/20250109-carat-festivity-5f088e1add3c@thorsis.com/
[ csokas.bence: Rebase and clarify msg, fix/add tags ]
Signed-off-by: Bence Csókás <csokas.bence@prolan.hu>
---
 drivers/spi/atmel-quadspi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)


base-commit: d64ebde2a5acd9a516f6ea97ec2c9e6fc697f584

Comments

Mark Brown Feb. 7, 2025, 1:17 p.m. UTC | #1 
On Fri, Feb 07, 2025 at 01:21:45PM +0100, Bence Csókás wrote:
> From: Claudiu Beznea <claudiu.beznea@microchip.com>
> 
> There is no need to call runtime PM put APIs on error path of
> `atmel_qspi_sama7g5_transfer()` as the caller (`atmel_qspi_exec_op()`)
> of it will take care of this if needed.

Please stop sending this out so often, this is the second resend in just
a couple of weeks.  Allow some time for review, having multiple copies
on the list makes it harder to keep track of any reviews that do happen.
Mark Brown Feb. 17, 2025, 12:24 p.m. UTC | #2 
On Fri, 07 Feb 2025 13:21:45 +0100, Bence Csókás wrote:
> There is no need to call runtime PM put APIs on error path of
> `atmel_qspi_sama7g5_transfer()` as the caller (`atmel_qspi_exec_op()`)
> of it will take care of this if needed.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: atmel-quadspi: remove references to runtime PM on error path
      commit: 99e6ea912340d6a262a60d5dd0c87c5e7b2d6ff2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index d8c9be64d006..244ac0106862 100644
--- a/drivers/spi/atmel-quadspi.c
+++ b/drivers/spi/atmel-quadspi.c
@@ -930,11 +930,8 @@  static int atmel_qspi_sama7g5_transfer(struct spi_mem *mem,
 
 	/* Release the chip-select. */
 	ret = atmel_qspi_reg_sync(aq);
-	if (ret) {
-		pm_runtime_mark_last_busy(&aq->pdev->dev);
-		pm_runtime_put_autosuspend(&aq->pdev->dev);
+	if (ret)
 		return ret;
-	}
 	atmel_qspi_write(QSPI_CR_LASTXFER, aq, QSPI_CR);
 
 	return atmel_qspi_wait_for_completion(aq, QSPI_SR_CSRA);