From patchwork Wed Feb 12 00:34:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Hebert X-Patchwork-Id: 13970884 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BB0EC0219B for ; Wed, 12 Feb 2025 00:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=mZNbqOyLMkR4zYGETdYI1Ds8jvtDMMy7KcjMP1dhBIk=; b=y9wToiCL3zoWlUaUILdE8iYBKY lH9lUKXda9HryLtBre/w0cfS3NqKMt+IMoGWTRBGtZ20ndzvTmXOYDkYHkI7BP6ivjdqHm0txeP3j nBDfg70Ho8fyZsRzsJ/BvKV3kOfBRXVRoGUUntslYIoKBXke1qVpvoQRWCgU/qjhst6eSpw6MZDDF 70ACI372ZGJ2FRlVeeW1Q7R77rGHjdwTBUTPhjZTKphTZmk/DGGiMB7JCsqG0wjPSzEgXwfJcVuSy oD/PP0WmloM7RovoloiWlkbyB4KOdR/ldHOmLmtl9veJRcWEimEsbz+USAEi2vmhdhbNHNUgHUdnT UITXhurA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1ti0k6-00000005iYa-2WFL; Wed, 12 Feb 2025 00:36:42 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1ti0if-00000005iHv-3MX4 for linux-arm-kernel@lists.infradead.org; Wed, 12 Feb 2025 00:35:15 +0000 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-2f9b9c0088fso493310a91.0 for ; Tue, 11 Feb 2025 16:35:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739320512; x=1739925312; darn=lists.infradead.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=mZNbqOyLMkR4zYGETdYI1Ds8jvtDMMy7KcjMP1dhBIk=; b=HbGAoPUO23vRKKxTm5aJOhwXS2KAu9zqDJ2Nhorq9xcefiWLuT8XfWtnDeOR3PYcRK kLPAJnmHc/ZI94D8kDq+hZYX1s8FM84rcpSQxThYhlVhY9RJoknTg5jtTCbUySqDbBuU WcMVUktBGRw/ldU5rrA+Y8+L14F5fpqnWCyLY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739320512; x=1739925312; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mZNbqOyLMkR4zYGETdYI1Ds8jvtDMMy7KcjMP1dhBIk=; b=BvUtqzOknSFE2D/Hc0U2AzQMbBvLk2tMto6bIAIjQ1Zt2N2H3PTEZv2SQXUnD8+qcJ X4/0sXcqTZrZNw+5NoIIcR9n+sVSTZB1btwutKkWl3E0dYfmDAjeaGiJ/+e8XkdSFgzD 70oQTSGRLswvAchylHy+jN3bIz9BzQCtCftfg0BzBBzwvxP3R2FgAKOBGMFifwUwemMF R5ttJvbn2h+hkAZlpo3aqmVcBiI1uAI5/M4+fyQqwXAB1FJQERFPrf60b8hYiWqNExuw bD+sBd8r7QsU5jJzd/DMIQ+APidx7nqhXaJeGF+wNkxn6hR0rJIXYi1reptIK3VfFxSg PfmA== X-Forwarded-Encrypted: i=1; AJvYcCXpaku/GkYgi0zm9zlrjQhchzgk6aPednau6hGhh7WjU3PLHcOhxhBmsJBvywpVTFcm4hIRuZlST+EdAYdrnfjc@lists.infradead.org X-Gm-Message-State: AOJu0Yxf/3CS7x8InqgySb9fvUOhdGF62Zhpc2kdZLobsOjvZ+vy9beE In5Lg4T4if6Gkm9aWY7Sos5FPgSe4vC0QBZRbZRWw0AXEwPZxEyB6RapxZnZuw== X-Gm-Gg: ASbGncvmLAQfeq9B1+iJVQa+WIB1llqARGW6OAOC+wt8OjJWACzWSrmAYzl1Na4YKTM 2cpzXOe29aGjIsKbH/mkSMoP+4gSFQn0HQV77Ece3CjxVhBublPkhFDi8lZMhGXsPtkglCKWl3r uMV8stOrcK7t4DelvKwgXyuF0NZj9a1y6cnQ02BVmln1OjMhPnHxy6uhTzXZT1eZ/wXaaaPpQ05 d7M9YmaVviUqb555zfd0OOz52ZQUmcwKDl4uNXOPEERnhjc8d3K7aPxsrMnOjIwJNimUMWR/VjW LOshksbPW8fvMx5aOd11ZKCH6dzOZlE6sn4AfDXRNOh7rJs0/DhhqC8GjQU5Ak2VV1CKg3XY X-Google-Smtp-Source: AGHT+IGU2vBf6I17uMlZ6vPzIppLSPDMm3Mc2t33rkKE8ywv2pPmz0SDcC2eFj6qRDS96L9Z49Rppg== X-Received: by 2002:a17:90b:510a:b0:2fa:2c61:3e5a with SMTP id 98e67ed59e1d1-2faa0913af0mr8652088a91.10.1739320512530; Tue, 11 Feb 2025 16:35:12 -0800 (PST) Received: from nhebert9.pdx.corp.google.com ([2a00:79e0:2e13:6:34c2:323:b5a8:3074]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fbf999b639sm165958a91.38.2025.02.11.16.35.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 16:35:12 -0800 (PST) From: Nathan Hebert Date: Tue, 11 Feb 2025 16:34:51 -0800 Subject: [PATCH] media: mediatek: vcodec: Enable HEVC main still picture decode MIME-Version: 1.0 Message-Id: <20250211-enable_hevc_still_picture-v1-1-0c06c0c9add2@chromium.org> X-B4-Tracking: v=1; b=H4sIAKrsq2cC/x3MWwqDMBBG4a3IPDeQjHihWxEJJv7qQEglsVIQ9 27o4/dwzkUZSZDpXV2UcEqWTywwr4r8NsUVSuZiYs2NZmMU4uQC7IbT23xICHYXf3wTFLeubuB 0z52m0u8Ji/z+72G87wcNGPdLawAAAA== To: Yunfei Dong , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nathan Hebert X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250211_163513_999147_B522197B X-CRM114-Status: GOOD ( 12.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Mediatek devices that support HEVC also support the main still picture profile, but today, the main still picture profile is excluded. This removes the skip mask for HEVC, and enables the main still picture profile decoding. Signed-off-by: Nathan Hebert --- On Mediatek devices that support HEVC decoding, HEVC Main Still Picture profile is also supported by the SOC and firmware. However, this capability is turned off in the vcodec driver. This removes the code that disables HEVC Main Still Picture profile decoding. Validation of the decoder has been done via V4L2-backed Android CTS tests on an MT8196 device. --- .../media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c | 2 -- 1 file changed, 2 deletions(-) --- base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04 change-id: 20250211-enable_hevc_still_picture-26b35eb08270 Best regards, diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c index afa224da0f41..d873159b9b30 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c @@ -152,8 +152,6 @@ static const struct mtk_stateless_control mtk_stateless_controls[] = { .id = V4L2_CID_MPEG_VIDEO_HEVC_PROFILE, .def = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN, .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10, - .menu_skip_mask = - BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE), }, .codec_type = V4L2_PIX_FMT_HEVC_SLICE, },