| Message ID | 20250212204258.57514-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] ARM: dts: marvell: armada: Align GPIO hog name with bindings | expand |
On Wed, 12 Feb 2025 21:42:58 +0100, Krzysztof Kozlowski wrote: > Bindings expect GPIO hog names to end with 'hog' suffix, so correct it > to fix dtbs_check warnings like: > > armada-385-clearfog-gtr-s4.dtb: wifi-disable: $nodename:0: 'wifi-disable' does not match '^.+-hog(-[0-9]+)?$' > > Reviewed-by: Andrew Lunn <andrew@lunn.ch > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes in v2: > 1. Add forgotten Rb tag. > --- > arch/arm/boot/dts/marvell/armada-385-clearfog-gtr.dtsi | 8 ++++---- > arch/arm/boot/dts/marvell/armada-388-clearfog-base.dts | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/marvell/' for 20250212204258.57514-1-krzysztof.kozlowski@linaro.org: arch/arm/boot/dts/marvell/armada-388-clearfog-base.dtb: gpio@18100: Unevaluated properties are not allowed ('gpio-ranges', 'phy1-reset-hog' were unexpected) from schema $id: http://devicetree.org/schemas/gpio/gpio-mvebu.yaml# arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-s4.dtb: gpio@18100: Unevaluated properties are not allowed ('gpio-ranges', 'wifi-disable-hog' were unexpected) from schema $id: http://devicetree.org/schemas/gpio/gpio-mvebu.yaml# arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-s4.dtb: gpio@18140: Unevaluated properties are not allowed ('gpio-ranges', 'lte-disable-hog', 'poe-reset-hog', 'sar-isolation-hog' were unexpected) from schema $id: http://devicetree.org/schemas/gpio/gpio-mvebu.yaml# arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dtb: gpio@18100: Unevaluated properties are not allowed ('gpio-ranges', 'wifi-disable-hog' were unexpected) from schema $id: http://devicetree.org/schemas/gpio/gpio-mvebu.yaml# arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dtb: gpio@18140: Unevaluated properties are not allowed ('gpio-ranges', 'lte-disable-hog', 'poe-reset-hog', 'sar-isolation-hog' were unexpected) from schema $id: http://devicetree.org/schemas/gpio/gpio-mvebu.yaml#
diff --git a/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr.dtsi b/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr.dtsi index 8208c6a9627a..7aa71a9aa1bb 100644 --- a/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr.dtsi +++ b/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr.dtsi @@ -453,7 +453,7 @@ &gpio0 { pinctrl-0 = <&cf_gtr_fan_pwm &cf_gtr_wifi_disable_pins>; pinctrl-names = "default"; - wifi-disable { + wifi-disable-hog { gpio-hog; gpios = <30 GPIO_ACTIVE_LOW>, <31 GPIO_ACTIVE_LOW>; output-low; @@ -465,7 +465,7 @@ &gpio1 { pinctrl-0 = <&cf_gtr_isolation_pins &cf_gtr_poe_reset_pins &cf_gtr_lte_disable_pins>; pinctrl-names = "default"; - lte-disable { + lte-disable-hog { gpio-hog; gpios = <2 GPIO_ACTIVE_LOW>; output-low; @@ -476,14 +476,14 @@ lte-disable { * This signal, when asserted, isolates Armada 38x sample at reset pins * from control of external devices. Should be de-asserted after reset. */ - sar-isolation { + sar-isolation-hog { gpio-hog; gpios = <15 GPIO_ACTIVE_LOW>; output-low; line-name = "sar-isolation"; }; - poe-reset { + poe-reset-hog { gpio-hog; gpios = <16 GPIO_ACTIVE_LOW>; output-low; diff --git a/arch/arm/boot/dts/marvell/armada-388-clearfog-base.dts b/arch/arm/boot/dts/marvell/armada-388-clearfog-base.dts index f7daa3bc707e..cf32ba9b4e8e 100644 --- a/arch/arm/boot/dts/marvell/armada-388-clearfog-base.dts +++ b/arch/arm/boot/dts/marvell/armada-388-clearfog-base.dts @@ -34,7 +34,7 @@ ð1 { }; &gpio0 { - phy1_reset { + phy1-reset-hog { gpio-hog; gpios = <19 GPIO_ACTIVE_LOW>; output-low;