| Message ID | 20250212213518.69432-1-chenyuan0y@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | soc: samsung: exynos-chipid: Add NULL pointer check in exynos_chipid_probe() | expand |
On 12/02/2025 22:35, Chenyuan Yang wrote: > soc_dev_attr->revision could be NULL, thus, > a pointer check is added to prevent potential NULL pointer dereference. > This is similar to the fix in commit 3027e7b15b02 > ("ice: Fix some null pointer dereference issues in ice_ptp.c"). That's not really relevant. Drop. > > This issue is found by our static analysis tool. > Missing Fixes tag and Cc-stable. Best regards, Krzysztof
On Wed, 12 Feb 2025 15:35:18 -0600, Chenyuan Yang wrote: > soc_dev_attr->revision could be NULL, thus, > a pointer check is added to prevent potential NULL pointer dereference. > This is similar to the fix in commit 3027e7b15b02 > ("ice: Fix some null pointer dereference issues in ice_ptp.c"). > > This issue is found by our static analysis tool. > > [...] Applied, thanks! [1/1] soc: samsung: exynos-chipid: Add NULL pointer check in exynos_chipid_probe() https://git.kernel.org/krzk/linux/c/c8222ef6cf29dd7cad21643228f96535cc02b327 Best regards,
diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c index e37dde1fb588..95294462ff21 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -134,6 +134,8 @@ static int exynos_chipid_probe(struct platform_device *pdev) soc_dev_attr->revision = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%x", soc_info.revision); + if (!soc_dev_attr->revision) + return -ENOMEM; soc_dev_attr->soc_id = product_id_to_soc_id(soc_info.product_id); if (!soc_dev_attr->soc_id) { pr_err("Unknown SoC\n");
soc_dev_attr->revision could be NULL, thus, a pointer check is added to prevent potential NULL pointer dereference. This is similar to the fix in commit 3027e7b15b02 ("ice: Fix some null pointer dereference issues in ice_ptp.c"). This issue is found by our static analysis tool. Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com> --- drivers/soc/samsung/exynos-chipid.c | 2 ++ 1 file changed, 2 insertions(+)