From patchwork Sun Feb 16 11:41:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13976525 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D718EC02198 for ; Sun, 16 Feb 2025 11:43:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Z+YOIFY1QqnkQull6bw6UkU5fZ1LXxRkH++QD8PUiro=; b=NeChEuQbnCtp98lyz+qEqTfj0X 2dCh/yTIqZ4Nu34dxF90ykNCnQEs9b24OTJ/cj/y7tLFW+kpGr3N3Dn7Gt5AAV5Pxc2J03lfBDYxy tFqGhkxRHjJmcpSfIqT1dOVZHNybHCtld2JgWlCjkpXgUSliYDRJRJxgwnbg1j495/yCknZkY4wd9 OUuLp1e5FAO+NQ+8NcrfwBW4yAEHhq7p0eM44Ge43P+lz+xPpVW90bxQB6GpuwLyBGdvbAEPcsfLt 4O1ocBnOrHCMKf0BaEoC6c0JN+LbunAkgRLc5AoBO+L922yzxKSlb3Q/4GUCRdj8UovB2qGzMTBaM tAHqzJiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tjd3I-00000001isw-2c2i; Sun, 16 Feb 2025 11:43:12 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tjd1p-00000001ijZ-31nC for linux-arm-kernel@lists.infradead.org; Sun, 16 Feb 2025 11:41:44 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-ab7c4350826so57361366b.3 for ; Sun, 16 Feb 2025 03:41:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739706099; x=1740310899; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Z+YOIFY1QqnkQull6bw6UkU5fZ1LXxRkH++QD8PUiro=; b=E3wggHKVwyBZeeSC4ag+OCggPfHr3N4z4WWe8A/RQFzzQmfHuQXGh9zkTQvPkfNdkW VPVyvBgaCMAoMNkY78EigaeIPYr9FOWCBlNOhCtSUrUsNOmaOSHxmQUw5ZgoNoEUfLBj 0JuUki8BNxeSZptUhzAS2Zq8z7c2xuvvI8aqFv26D3MowEYdalVSgONTGtQhl1ULtGrq r3zmrHFX2oXqfnzKPDcV57VrhftHJyXu7KNBE71mcbIWinhZPNKjptxIKVYGE1jQjQkh Fd+5Fe14Inl1JXVN42CLdylHF+eI5QaTGZ1vAUC7PjGOfzuASnW3iolCNknJ/MuqKfi+ vNFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739706099; x=1740310899; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z+YOIFY1QqnkQull6bw6UkU5fZ1LXxRkH++QD8PUiro=; b=YC4eVISFlNB9i40+BTo7cSYQxne9+hw1A7fJEpm7Logs8A736EgDHzGjJr963w1z5J LmlsEjruCHffjL/fzq67VwTNGTEaBg1HiUhA/AEKnnf74tKw7kIkJMPad+VWINRPBGXv FvUMqbjEgWQeCwLQdHhqhFCAB992nSx3O+5bbzsdzDXEOyq8MRGbIiEswfULT367nHLn OBFPlz9To5rr0t7DNHqUJsKQYiAwdLvD5KGk+32sRmPfEagIsJW8mr/dbvpMQzuiU85w qc7x2+Xv3gkDdBasvgskySmk3Tbb6rZjkmCcUSyggzoThVZJL3t27/YD6JWsz0jlEiF4 fOag== X-Forwarded-Encrypted: i=1; AJvYcCUwyhNIuutB9g63/uuMF4+Cf4mxP2BH0fznWcIQgvMdEu8Ws3GBQ9zGJZ1XFzhqV06YsvvFeYeorQrdi6aAbp1e@lists.infradead.org X-Gm-Message-State: AOJu0YwMu1AXD/YqBnp3jbd+45MpfEviJLyUhIJQDEH7mBTnOdZ0Un+w wCgQBj6eIUby9XDw5b9kLKTKCi7olaAr5h2myR06VsYqqyyCbx414jyTwIGSy34= X-Gm-Gg: ASbGncsXhzZ3D0CjtvLuPrfdE4NtaJNVTySZBlskYI/4TgatLoPzJEJNyNgzCrdWlAo PiV3m2ubg4MTX4BUL9gcxYDFMzHukZMLS2T6TI3X9/uyMkBnaGBFLVNk+797uqLbgtZPmq4L7U/ R6IQbBtPMVZaxuMPHrnRvpAv8VI2n85zpqfIJYnH3Fxa4MEX1yiSeUvnxCall//TJ/UInbfbqzF OpCi4RF9dM/23i9Yeh0frExueOwnqiCx8sUqipMMlltC4N7Cz18yHqap1nS8aSZKh2jmLWBnXhH 5F6F48GE2rswoccd82esgmgDv5+GBA== X-Google-Smtp-Source: AGHT+IGC7GfLml1oeu8oNIX5tls4ha6EZGX1Ok0ynCFcQ9rntDrsSXbTflTn2CbbuY9r3Pnoy6M6hQ== X-Received: by 2002:a17:907:7248:b0:ab6:6176:9dff with SMTP id a640c23a62f3a-abb7053d8e7mr248373666b.0.1739706099492; Sun, 16 Feb 2025 03:41:39 -0800 (PST) Received: from krzk-bin.. ([178.197.218.144]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aba533bdc41sm682048066b.162.2025.02.16.03.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 03:41:38 -0800 (PST) From: Krzysztof Kozlowski To: Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Alim Akhtar , =?utf-8?q?Andr=C3=A9_Draszik?= , Peter Griffin , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski , Marek Szyprowski Subject: [PATCH v2] phy: exynos5-usbdrd: Fix broken USB on Exynos5422 (TYPEC dependency) Date: Sun, 16 Feb 2025 12:41:36 +0100 Message-ID: <20250216114136.245814-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250216_034141_773511_707261BD X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Older Exynos designs, like Exynos5422, do not have USB Type-C and the USB DRD PHY does not really depend on Type-C for these devices at all. Incorrectly added optional dependency on CONFIG_TYPEC caused this driver to be missing for exynos_defconfig and as result Exynos5422-based boards like Hardkernel Odroid HC1 failed to probe USB. However ARM64 boards should have CONFIG_TYPEC enabled and in proper state (e.g. =y when PHY_EXYNOS5_USBDRD is =y) for proper USB support on Google GS101 boards. Add itermediate CONFIG_PHY_EXYNOS5_USBDRD_TYPEC symbol to skip TYPEC on older boards, while still expressing optional dependency. Reported-by: Krzysztof Kozlowski Closes: https://krzk.eu/#/builders/21/builds/6139 Reported-by: Marek Szyprowski Closes: https://lore.kernel.org/all/3c0b77e6-357d-453e-8b63-4757c3231bde@samsung.com/ Fixes: 09dc674295a3 ("phy: exynos5-usbdrd: subscribe to orientation notifier if required") Signed-off-by: Krzysztof Kozlowski --- Patch for issue in linux-next Changes in v2: 1. Add PHY_EXYNOS5_USBDRD_TYPEC, so arm64 defconfig will have both symbols in-sync --- drivers/phy/samsung/Kconfig | 12 +++++++++++- drivers/phy/samsung/phy-exynos5-usbdrd.c | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig index 7fba571c0e2b..b20ac6b75993 100644 --- a/drivers/phy/samsung/Kconfig +++ b/drivers/phy/samsung/Kconfig @@ -77,12 +77,22 @@ config PHY_S5PV210_USB2 particular SoC is compiled in the driver. In case of S5PV210 two phys are available - device and host. +# None of ARM32 Samsung boards use Type-C, however newer ARM64 do and +# PHY_EXYNOS5_USBDRD driver needs TYPEC to be in a matching state to avoid link +# failures (see optional dependencies in kconfig-language.rst). Intermediate +# PHY_EXYNOS5_USBDRD_TYPEC symbol allows to skip TYPEC on ARM32 boards. +config PHY_EXYNOS5_USBDRD_TYPEC + tristate + depends on ARCH_EXYNOS + depends on ARM || TYPEC || !TYPEC + default y + config PHY_EXYNOS5_USBDRD tristate "Exynos5 SoC series USB DRD PHY driver" depends on (ARCH_EXYNOS && OF) || COMPILE_TEST depends on HAS_IOMEM - depends on TYPEC || (TYPEC=n && COMPILE_TEST) depends on USB_DWC3_EXYNOS + depends on PHY_EXYNOS5_USBDRD_TYPEC select GENERIC_PHY select MFD_SYSCON default y diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index ff2436f11d68..6d571dff2898 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -1456,6 +1456,7 @@ static int exynos5_usbdrd_setup_notifiers(struct exynos5_usbdrd_phy *phy_drd) { int ret; + /* See CONFIG_PHY_EXYNOS5_USBDRD_TYPEC */ if (!IS_ENABLED(CONFIG_TYPEC)) return 0;