diff mbox series

[4/7] dt-bindings: display: mediatek: ccorr: Add support for MT8196

Message ID 20250219092040.11227-5-jay.liu@mediatek.com (mailing list archive)
State New
Headers show
Series porting pq compnent for MT8196 | expand

Commit Message

Jay Liu Feb. 19, 2025, 9:20 a.m. UTC
Add a compatible string for MediaTek MT8196 SoC

Signed-off-by: Jay Liu <jay.liu@mediatek.com>
---
 .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml     | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Feb. 19, 2025, 9:23 a.m. UTC | #1
On 19/02/2025 10:20, Jay Liu wrote:
> Add a compatible string for MediaTek MT8196 SoC

You do not add compatible for soc but its component. But even if this
was correct commit msg, you still repeat what is in the diff. Say
something useful, is it compatible with 8195 maybe? Or with something else?


Best regards,
Krzysztof
AngeloGioacchino Del Regno Feb. 19, 2025, 12:49 p.m. UTC | #2
Il 19/02/25 10:20, Jay Liu ha scritto:
> Add a compatible string for MediaTek MT8196 SoC
> 

Add a compatible string for the CCORR IP found in the MT8196 SoC.
Each CCORR IP of this SoC is fully compatible with the ones found in MT8192.


Please fix the commit description here, other than in dither and gamma.

After which,

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> Signed-off-by: Jay Liu <jay.liu@mediatek.com>
> ---
>   .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml     | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> index fca8e7bb0cbc..581003aa9b9c 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> @@ -32,6 +32,7 @@ properties:
>                 - mediatek,mt8186-disp-ccorr
>                 - mediatek,mt8188-disp-ccorr
>                 - mediatek,mt8195-disp-ccorr
> +              - mediatek,mt8196-disp-ccorr
>             - const: mediatek,mt8192-disp-ccorr
>   
>     reg:
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
index fca8e7bb0cbc..581003aa9b9c 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
@@ -32,6 +32,7 @@  properties:
               - mediatek,mt8186-disp-ccorr
               - mediatek,mt8188-disp-ccorr
               - mediatek,mt8195-disp-ccorr
+              - mediatek,mt8196-disp-ccorr
           - const: mediatek,mt8192-disp-ccorr
 
   reg: