From patchwork Wed Feb 26 05:01:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Kshevetskiy X-Patchwork-Id: 13991521 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0A3BC021A4 for ; Wed, 26 Feb 2025 05:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-ID:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=I7JGj9Y2NvlR+Ur5b6WMaXa2nlsT9ZFJEwFDS8Jks74=; b=Q5B0eFc4bbg+hFqt627jiK6eze DnPQdnU1rwBNIAGvvAa45Fg0wBAAvyDsbQvEVUiUrw7j0BjqhN14JIXtqUA8LQhShqYBDnjj2DZ7F pNddPE8H0kMFD+ktPDsrrHjN8yuLbN3pT+XqoakaHzXmKfVGB3MoGUVC2pY1AHVLcb+CyC5Qtx0YH 1t/6AZi02TVUfyq5erkKMcYvmaNncclU/FZO+Nn6e6MPTkdq3u1kznrRHZAadEbNV1UYfnd3wFbU5 reZzo0b1jn7CjVhyjImZyZpzRQMWmL0vEWM5ioTcDuRxPRmSstx9hBWoOxj5s9QBJWVnQ0RbgEG9D IMTzGCjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tn9Zu-00000002Pjb-2sIg; Wed, 26 Feb 2025 05:03:26 +0000 Received: from mail-am7eur03on2072c.outbound.protection.outlook.com ([2a01:111:f403:260e::72c] helo=EUR03-AM7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tn9YN-00000002PcC-05Wa; Wed, 26 Feb 2025 05:01:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WAZnJaTmXnct5UsbhJ/oExfLpSzoN0O0L+jZ5RkDbdO9zgdfWPD+F6mKi9nRAi39cH8KAh62ToMY0iQ8jNVaAiOZqgAE3VGkrf/XozTHE8B1JpE9WsZSTOlJxiOL2b2zCDwkKuF4O0lALPm0/54PpSdKQn8rZJeUDJEuK9ondoRm2NiLsLyC7IcuhLOc8jYTQgdqNj3Y1AgwRD6roG2CH6BPZx/MRJmMyVOhNFV7Gf7Xj/wBPwZG5zZULkNZlp+OLBu8s9vcYd6pDRwNjQdC56OKYJ5JOmQZpBQXjTOaeiJ1ZIY12jbYEEIUIFT6Kbht15HF2lnc/CDNKd/KMTcPIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I7JGj9Y2NvlR+Ur5b6WMaXa2nlsT9ZFJEwFDS8Jks74=; b=lKxaa5jTbbdZ2Y2aqsv4S4lgICG8Fo2tXFH4YSPy9JCEgYwP50rYIFO/fsakykEGAd8aKM9Z23C9yVpFHn/Bio5KK2kc2HC3qUoBhFyoIieV4BVfroL7fDIpYK+SfkEpF7z3WWEQvQj6KYmaRwclbzpwg8zwgP/hyipMd25RViV1fubyNuCFe4YIoeL6gTso/D9kNox3ZGM0D3vjhREPvq47O0++Aw+N5CIZtGxMXxrEXHKlaUs24PR9dDFRI7arw14HuI1EACZNs1Pci9XzURN8qgfeGrRfi3YASThtEN2fpf9Lqw1yLC9of+mYAVq4plHnRraB2EgqqU7pHJB6Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I7JGj9Y2NvlR+Ur5b6WMaXa2nlsT9ZFJEwFDS8Jks74=; b=KsEQbYGzBH1LFIEJvy36thpFi6D+28zYnTG5OjheGt9wPkpQCQFXl7KNmearqZG7sCfUTHx/4IvqhcvvZPg1bu0TmtH+8flyRK1zqyp2jn9Hfbzk/8zEdHUR5iVYY80Z6OFSL+xnu0PyrKV+W4WQ9dCS6tcRMKyRRR9L62iW27inkG6tj2uGf91GR11NkJbRfX162lCAzHrC9vRQpZWyzrsUAwKN9xPAGgFvsrDJwBq1BCLNw8faqEWwzd/0F5LEI0M1ezXa2DBf2sV9y/UwSBW3NoaICHzvpsKgUN2PqkqC9qIo80uJK3eMFoRtVGOeNtPvLuOJKqJlmgs3n0K6QQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by AS2PR08MB10054.eurprd08.prod.outlook.com (2603:10a6:20b:649::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.19; Wed, 26 Feb 2025 05:01:40 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%4]) with mapi id 15.20.8466.016; Wed, 26 Feb 2025 05:01:40 +0000 From: Mikhail Kshevetskiy To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Mikhail Kshevetskiy Subject: [RESEND][PATCH] arm64: dts: mediatek: mt7986: fix pwn fan settings for sinovoip bpi-r3 board Date: Wed, 26 Feb 2025 08:01:32 +0300 Message-ID: <20250226050132.547353-1-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.47.2 X-ClientProxiedBy: FR3P281CA0095.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::7) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|AS2PR08MB10054:EE_ X-MS-Office365-Filtering-Correlation-Id: 80a18c20-411c-4d20-b564-08dd5622a7d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: ZGN4iA1L2aGqn8h0CR+lPV7gzMfGBW8T9+K9M0pIIefSsJYCy5BkQIml6z4xQfO49LgCTLWnhbycDW3ZMbcsxNYctEEqXnP5zYZdcFvbo0Q2GjjwDLFQrpYHKxSCVrVJ6s9ixLRa2Mun3iPdOJFzOuCi0RkRtXSP8DLRX4DxlyWJyyx7jm59WSddDzGxzwfKNimCh6081XbUcU4lRiCo80lp5eQgbL6MSrDnzXRRFvdtngGH1Xh0sJ9eTi2sFQKR9yCOX+aPVRsZGkdqD4VYf1RVeizERQpPDMfCLeav/LRXg9H/YXXIDvOv0D1hY65JDP2KO13gHoIrt4qrxa4jjFiH+i4TgaIT+r8Rv2G5rZHHVNpUKV4rtS26ZTxET1KU8cVH//cW1B5MMJvhyoyY6w1oFSQavylfaIs0MF1glPPQa8zUGXrgtxYOuE2VmC2E4e60h4zev+0FLLj1EXnVMV0TEVXByOYLa4WTScEnZOcefNPkXdUQBQ371lxEClyk5ECbVCgkCnzC6YRgSZPI98dJSTcz8WOlYbaHSbnRizyZW7btF2jBH+0YC84Dfel/jO9tu7zW7yjH5pNLd9fm7nGE+4P7mM2XuT1peVJozguQfqkrZ2T1ya26exZhTFAlOZlHNAxQ59tA3rTFWBfjuLeAavcgDM57xd4pxA4YECm3yV+bruhVNEQajczziT0AuFVw++0HGF5a40tST5VXp3fgHxNVOEUpv5RjgFeHUvNGj8F3FdcXo0Dy9gTvddn/PS97k/VFybYigSP0Av2g2rTfOKoaicTJ5Di0Lj15yTLRP7TqzXFRHk9V7JnYhSh3ysMATewMx7i2U20gtifFfhwi7pNe3sB2fvmzSvAlL/4iXNhgw6tNYKOSlMBUQ5E0VATB97UyBl4I1Zt2yDkdqvshK94vV42QA3DZECHQtOr6kChZG/vqqxGoLcYl9M8bCxF60ThIruMZcG1+B92XR5v5hGRV3JrU24saIC+MjjeLSxlc7CLGdM9tmgxPws5Vl1Zu6v5hTeHWaOpUCP0ZYaZvKQ7BKRRfv3MHzBTCMrCLnjHl+lL1WcYE7DM1riv38ud5oB34mB80WPpn4odhjUfYzHho25V++wJYxLrHujgzkNmZGYxIdO4tx/d6g0nENKn2Kfwhum9tBNa7+w0KhsQEU80ggYGTOfX3Egl+wpkVMxATDaC/CD9m5sPI33RkYCBXcnaOsy0X0Vm94P3Tx785Gd8v6gyo9COGJEGPe2s3RmwG2gJ/9enFtLLzpEBdDRA1ekkFCNddCRn3J+fQbOcAuGN1Y+yg3VckLe8nR9rqoURlV4XVgFUY29lwpF8rjjpK6B6lZP3MaG/XpBTm3HKhw4cr+yR47cF8QMy+1ZtVKPdZEP5UmZM6/ywA/sYNACyF4LZSFxbFwqslUN0bx6oXb0g52mA0G19WNAXz1q5rr8pcYWEPLNaSyoL67mwp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CMTHOU7YEj+vNhktFXXa9uPRO2uxp/iWpB3hm1FxJYjPHvjB8xGiG4NFlzvh8CcCoIa1siP+wvIUXInPUV0oQNcYh4Xk6jOQXNX1/113AIKKPyYg2l8IgqZB7vj3QzO/0HFjYGjayKRi6qnrTg1+IyE10mqz7S4DjLm6l4ddsBmAWve02wvnrM5KlCC8lWMlNQ/rmC1TrFNu6504YbiBSoSbO/Jt2U5tXe+vZh/ZW+/T0Lmw+R3RBdUNazDMVPCubFmgGHFjUsF+afSRZb6hUeb8tCrhuZHmCjoQp3cKO6n1fN7wi1vkf3OjSgSbzA3SDBK2VO344Iv8XC9Y/gopyZpOcHT54GGP4ln4XIzHy9BBiAMELsGaTe53sjpmYQaeBwJX9jgO55lfP+Dl4x/cUnm+xCPkroj4pbLsFGexF8sAwAuCXvgFkIhI+5+/vJkge378g+E1nVkbtwzcoI9oA942ipF1jBSovOlEEp5pwiKA8N0sEMIG6yHSKTeLvmfqUwqFyck3OsZ2EmqevZsUzDKGBZKei5gYXKZCsSLHo5gJ3SFYB7LUXV3VudCe6EeKHHONbqrK21S5IjZsjwaZCm+fzcClgD15BjswAuNoCPGySAS9PovO/eqUK6arJ4ViWd9MAXiHZLA+c+kpMFqlCgyN4etlHn9DJn15oU3+7yVj6KCvlEWII4TKrlenTUp1DD2Vz36Uo4mogIvK5svUqS73bDwm5S7+O5tSjtvLOrI8gbWfwyXn92Veyu2E61advljuArarpxefGnzRiGgmkLbsfSYmqYI2TgDxHALI9iHQPc2vYwWrimWrexY/iXwQNjTiXnZ4doiUk2T/UZZlf7aJcKfHDN4Ww3XINbHwknYqaAiYA11hW5wqF5iAYFroqktUI+ziRFpNUz1qJyHLx/4GIQDnKr7NK3DGyv5Mtz9jl8PWD/oIipj9FL5/icemJPqHvoJmSqDlwPMNh/uLavKfX6a8nNRAQZrIrEequO+v/PCW6b9ReBIWVif2paq+X9/c3DlAKBFv+r2R9sB+JkAWTIYTHZNORA3/WTg9WHUjlqmyfHf1B6Aq/vNKCpAyxPgJE89PC1pWoSRfMhACzoerCSwz2pqkJhy1AC7beBK8VV6diIN/mWsV2f1dVhaNSLePMjwb//CQT0Siho3jEjWPxUpIfPkV6KnJ7k9kC2QpxiSidNBkBZw+tjLA4i/PPcIvshWwf3+EFrNAzozhmtcwVEymXFTGmRx/EPZGxWR0CW3uGNGfgnUZJHjfv6zVjoNdnn/jI64Ao9Az9u5ZiWFGDKxf37vGCPEeF5aSkxLYSofAxrzhQ+0Pvs1byoc/BxUETL8oCSKdsBh6c2US0FowOkpmL0MauxXgR0wUBY3N6/FrMlKFFHvf4iR77ehPl/TPv2Gs2/XoMg35QysSKH68/jRWo0Oltu93K5K65oZbCCeO4r8pvtGRlBLgFOSSr/xYRObY7dae2lr53xVR2GD7XugftHyPAmy0syESXGJWUvvA64xAo4WO0egj/FQAlLPUQcnxVUHFD2+13qSIMnexVmw/YyIbQWcqhA9m3PcZiWfeC1tyA+GEw5kmP6zbX4A9V801IsgszHGaNPvXUAa6WpbQMrji0T2a6+sMuFA= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 80a18c20-411c-4d20-b564-08dd5622a7d6 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 05:01:40.3271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fICigIYkSGIJHHNroR+CmPxxZqJSLv5UPCilTr9L04MHGSz57pm2QRX1XUSltIs34UcuRS7vfikTW9E4stEEvnTNBp/qqLlmEyLvgTNztMA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10054 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250225_210151_475104_30043202 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Popular bpi-r3 pwm fans like this one https://www.amazon.com/youyeetoo-Barebone-Fan-BPI-R3-Integrated/dp/B0CCCTY8PS will not work properly. Trying different pwm setting using a command echo $value > /sys/devices/platform/pwm-fan/hwmon/hwmon1/pwm1 I found: pwm1 value fan rotation speed cpu temperature notes ----------------------------------------------------------------- 0 maximal 31.5 Celsius too noisy 40 optimal 35.2 Celsius no noise hearable 95 minimal above 95 does not rotate 55.5 Celsius ----------------------------------------------------------------- At the moment we have following cooling levels defined: cooling-levels = <255 96 0>; for cpu-active-low, cpu-active-medium and cpu-active-high modes correspondingly. Thus only cpu-active-high and cpu-active-low are usable. I think this is wrong. This patch fixes cpu-active-medium settings for bpi-r3 board. PS: I know, the patch is not ideal as it can break pwm fan for some users. There are some peoples that use handmade cooling solutions, but: * discussed cooler is the only 'official' pwm cooler for bpi-r3 available on the market. * most peoples will use passive cooling available on the market or the discussed cooler. * the pwm-fan dts section was added before the official cooler appears on the market. Thus it should not be a lot of harm from this fix. This patch may not be enough. Users may wants to tweak their thermal_zone0 trip points, thus tuning fan rotation speed depending on cpu temperature. That can be done on the base of the folloving example: === example ========= # cpu temterature below 25 Celsius degrees, no rotation echo 25000 > /sys/class/thermal/thermal_zone0/trip_point_4_temp # cpu temperature in [25..32] Celsius degrees, normal rotation speed echo 32000 > /sys/class/thermal/thermal_zone0/trip_point_3_temp # cpu temperature above 50 Celsius degrees, max rotation speed echo 50000 > /sys/class/thermal/thermal_zone0/trip_point_2_temp ===================== Signed-off-by: Mikhail Kshevetskiy --- arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts index ed79ad1ae871..b0cc0cbdff0f 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts @@ -42,7 +42,7 @@ fan: pwm-fan { compatible = "pwm-fan"; #cooling-cells = <2>; /* cooling level (0, 1, 2) - pwm inverted */ - cooling-levels = <255 96 0>; + cooling-levels = <255 40 0>; pwms = <&pwm 0 10000>; status = "okay"; };