From patchwork Wed Mar 12 11:14:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 14013505 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17575C28B28 for ; Wed, 12 Mar 2025 13:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YTLAF0tIpFzXbv7BL0TTLvyumrvT+IHuJUXwb+Jj2tI=; b=QG02QevU6TiCSk89ArZ4sTKBgX +73VYqJ3nPf/RE9FJQF/6mUYlnbPIMZQOXDPWdHOdTjmEPN/nULpB5mMaDUHgUuYFys7+m4iCNOb4 6BHINLmfgEnvmT3Q18oqAp4IvJv6CSaVyd2VR5wRrLvtuF4SCy0lAHXyaohgHUi4WvMvdMwHxjSEP kxKWRhTbirtvicglS1a/WYiOBjjaDD/EIfgShCsXht6k3S0Qu5op9LKWxkjiwedfIE7hZFF9ajy28 6cXtcoCVXfFLEEGYHkDDXHQDVYgwihl33jmpQ517X7nWoVHucXwvi6fos4desmqmBZMUEGGP4mDk4 qW0pvg1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsLmM-00000008Ukp-2bYn; Wed, 12 Mar 2025 13:05:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsK39-00000008E6M-3XUU for linux-arm-kernel@lists.infradead.org; Wed, 12 Mar 2025 11:15:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4CCD91516; Wed, 12 Mar 2025 04:15:10 -0700 (PDT) Received: from e133711.arm.com (e133711.arm.com [10.1.196.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EF4903F694; Wed, 12 Mar 2025 04:14:58 -0700 (PDT) From: Sudeep Holla Date: Wed, 12 Mar 2025 11:14:34 +0000 Subject: [PATCH 3/3] firmware: arm_scmi: Refactor error logging from SCMI device creation to single helper MIME-Version: 1.0 Message-Id: <20250312-b4-scmi_minor_cleanup-v1-3-51a514282794@arm.com> References: <20250312-b4-scmi_minor_cleanup-v1-0-51a514282794@arm.com> In-Reply-To: <20250312-b4-scmi_minor_cleanup-v1-0-51a514282794@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla , Cristian Marussi X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3348; i=sudeep.holla@arm.com; h=from:subject:message-id; bh=0VunvKId+eIYxYj8ySEheQ8DibsTe7qSHuPUkpqsZwU=; b=owEBbQKS/ZANAwAIAQBBurwxfuKYAcsmYgBn0WywkmNMuJyVsypRHtvfrfmPyNGZ4JyQx871N /4f3Pv+OJqJAjMEAAEIAB0WIQS6ceUSBvMeskPdk+EAQbq8MX7imAUCZ9FssAAKCRAAQbq8MX7i mL16D/9grXv2l3vMUtt7/b0gjFh8JtrgFpbcNvJoonjeuOQcMgdiIhbRLEDiTtVm9EUf3TBozl2 j7HXc7Y3daO01ERhEeNs3vrd0twnpi7qQH5TYLKfXpLiBdMZmadx9H47xsCmY1sSmjFBJtrPH2y FRBEM2yNKu48FNbgUH8jkuHXLYNxoC5ZU/q46imasmWrhIe20xF2hlB2IyL/AHRud+Lf7n5b1/D 7MzFOJ/d01FntSuLduDfx/+Bn7ZbpVWKvdZq4LgaRXan81ds+1O1qX8O7R0Kv6gN1Gc3Rt41CPF k95V3vsS+buQm/PDJm9StQ6iYw5P+cNufXJoxr1K47mOl9AUI2qFhVNy/w5l+8Vw57qE6fyVjhy s1NoC/K6rTX1/Wd0FNuHnfXE83TmPedmkS8Fx2/HKMq8bhgQx/0tazBjgxkasRCy7+jiQjJNvc0 YvP4VfbW1x0EHyQiDsP9TSsRZFYOHNedjk8R7e3/zkDV56XElN185lHpfEjCGYBJHDIe1LposOo iHF1e7d5EmaqFjDPF2O8KyA7NjhY5FkhdiCKp0GGqJU9BKqHiBUjleFh6hiasKj46+xyHnZXo7d jhkWeuQzZ6Tue6Hhsi4zEDf57ty7B3Jzk3RBzhYiu3ZeR3j6jwaXc3v0hH1UTCEY2Yx+YUN6MAn mYlrX2C2Y5CZIVA== X-Developer-Key: i=sudeep.holla@arm.com; a=openpgp; fpr=7360A21742ADF5A11767C1C139CFD4755FE2D5B4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250312_041459_975669_81A7FB5E X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Refactors the error logging related to SCMI device creation. The goal is to remove duplicated error-handling code and centralize it into a single helper function: _scmi_device_create(). By doing so, any code redundancy around error logging is avoided, as error logging during device creation will now be handled by a unified helper function. Signed-off-by: Sudeep Holla --- drivers/firmware/arm_scmi/bus.c | 29 +++++++++++++++++++---------- drivers/firmware/arm_scmi/driver.c | 8 +------- 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c index a30fd8e05e423e226a63833f309d8d30c400fabd..493e2c63b107fd9063f11034b71d65f567bb0778 100644 --- a/drivers/firmware/arm_scmi/bus.c +++ b/drivers/firmware/arm_scmi/bus.c @@ -411,6 +411,20 @@ __scmi_device_create(struct device_node *np, struct device *parent, return NULL; } +static struct scmi_device * +_scmi_device_create(struct device_node *np, struct device *parent, + int protocol, const char *name) +{ + struct scmi_device *sdev; + + sdev = __scmi_device_create(np, parent, protocol, name); + if (!sdev) + pr_err("(%s) Failed to create device for protocol 0x%x (%s)\n", + of_node_full_name(parent->of_node), protocol, name); + + return sdev; +} + /** * scmi_device_create - A method to create one or more SCMI devices * @@ -443,7 +457,7 @@ struct scmi_device *scmi_device_create(struct device_node *np, struct scmi_device *scmi_dev = NULL; if (name) - return __scmi_device_create(np, parent, protocol, name); + return _scmi_device_create(np, parent, protocol, name); mutex_lock(&scmi_requested_devices_mtx); phead = idr_find(&scmi_requested_devices, protocol); @@ -457,18 +471,13 @@ struct scmi_device *scmi_device_create(struct device_node *np, list_for_each_entry(rdev, phead, node) { struct scmi_device *sdev; - sdev = __scmi_device_create(np, parent, - rdev->id_table->protocol_id, - rdev->id_table->name); - /* Report errors and carry on... */ + sdev = _scmi_device_create(np, parent, + rdev->id_table->protocol_id, + rdev->id_table->name); if (sdev) scmi_dev = sdev; - else - pr_err("(%s) Failed to create device for protocol 0x%x (%s)\n", - of_node_full_name(parent->of_node), - rdev->id_table->protocol_id, - rdev->id_table->name); } + mutex_unlock(&scmi_requested_devices_mtx); return scmi_dev; diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 60050da54bf24c0245290e846f91aea62392855b..b80c574cb3bb2f12b2980fc844ea3da10abdc9f1 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -439,14 +439,8 @@ static void scmi_create_protocol_devices(struct device_node *np, struct scmi_info *info, int prot_id, const char *name) { - struct scmi_device *sdev; - mutex_lock(&info->devreq_mtx); - sdev = scmi_device_create(np, info->dev, prot_id, name); - if (name && !sdev) - dev_err(info->dev, - "failed to create device for protocol 0x%X (%s)\n", - prot_id, name); + scmi_device_create(np, info->dev, prot_id, name); mutex_unlock(&info->devreq_mtx); }