From patchwork Tue Mar 25 10:26:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Zyngier X-Patchwork-Id: 14028314 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0FCEC35FFC for ; Tue, 25 Mar 2025 10:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JXTihVp9TI+uA9H0iO/Auwj8sQFOMHNaVtdzWkEsf6Y=; b=CCf1bTorTeS6QGM1POxq9Is1a/ pvEts0bZKmk8Y6uXadFjdVtVxrAvu7IObVPh1d9NxHXhp/0eszf6FDdBdeuQVlULu5cB+4YwyUjYi /R9k15Z3MO6E5JsRHbYhh+bPGh5a2dwzTw42/1qd0zQXrvWiUFgnz/4HoC6XKXVPfY7+uAUvEqADN a0EkBbYRnrUZLHgK9/JJWhJ+Syuaa9a6b8C3dk+glcuvF3h1NItIOsBBFQlShYd1wEe/TSwBTe9Qo 1ZFpwEyBSPYREzaPpbHxueVTm90rPg/gTSEieuFnFzPEPVKtVDjIagScK28Ey1WhRvjRvAj6eT8xu Q9sXcsNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tx1i5-00000005TVa-0J0z; Tue, 25 Mar 2025 10:40:41 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tx1US-00000005QoM-1gqG for linux-arm-kernel@lists.infradead.org; Tue, 25 Mar 2025 10:26:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 92BEA43BD9; Tue, 25 Mar 2025 10:26:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B939FC4CEF5; Tue, 25 Mar 2025 10:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742898395; bh=deykT+fK/heCGjU9D2cdIQGrZpoQPM8vhfLPU4LVQ/c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=egNIEUmH36TMSiDDM0AzxmqrYCvi8w6a48gKuaX6f5j1XpGhNEqtvIRDHeJFB0/bP y77QEcJCxC41buXFCp4qsdQO08uqtVorj4eGOSauLAoMYjiwBNxrrgh41HqePAHHyk Zsout6G3OIVLGdi7+7V0otOq2x+9lTkp9oIjfGjQQKaRxfU+hikepODj7xEwNIXnrM mS0N/j0SAhSRlAMI+/F1jcMen+slb27DBb/+q/W1ik3D/baV0kRuzL0f9JMyl1XgV8 gP0HPR44lY9+X7CyEC2mfCQsqvSlRRQGlsYyzvLi5od3k0OEoaYdOKn04Xwtra8C2X Ke+DjVjpelHyg== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tx1UP-00GsRS-P4; Tue, 25 Mar 2025 10:26:33 +0000 From: Marc Zyngier To: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Cc: Alyssa Rosenzweig , Janne Grunau , Hector Martin , Sven Peter , Bjorn Helgaas , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski Subject: [PATCH v2 07/13] PCI: apple: Fix missing OF node reference in apple_pcie_setup_port Date: Tue, 25 Mar 2025 10:26:04 +0000 Message-Id: <20250325102610.2073863-8-maz@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20250325102610.2073863-1-maz@kernel.org> References: <20250325102610.2073863-1-maz@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, alyssa@rosenzweig.io, j@jannau.net, marcan@marcan.st, sven@svenpeter.dev, bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, krzk+dt@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250325_032636_459455_17D2F89F X-CRM114-Status: GOOD ( 11.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Hector Martin In the success path, we hang onto a reference to the node, so make sure to grab one. The caller iterator puts our borrowed reference when we return. Signed-off-by: Hector Martin Signed-off-by: Alyssa Rosenzweig Signed-off-by: Marc Zyngier --- drivers/pci/controller/pcie-apple.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c index 63ceb5e3debaf..6271533f1b042 100644 --- a/drivers/pci/controller/pcie-apple.c +++ b/drivers/pci/controller/pcie-apple.c @@ -593,6 +593,9 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, list_add_tail(&port->entry, &pcie->ports); init_completion(&pcie->event); + /* In the success path, we keep a reference to np around */ + of_node_get(np); + ret = apple_pcie_port_register_irqs(port); WARN_ON(ret);