diff mbox series

[1/3] dt-bindings: add imx8mp-libra-rdk-fpsc

Message ID 20250328-wip-y-moog-phytec-de-imx8mp-phycore-fpsc-v1-1-28324c7f81fa@phytec.de (mailing list archive)
State New
Headers show
Series Add new imx imx8mp-libra-rdk-fpsc SBC | expand

Commit Message

Yannic Moog March 28, 2025, 1:04 p.m. UTC
imx8mp-libra-rdk-fpsc is a development board based on the phyCORE-i.MX 8M
Plus FPSC SoM. Add its description and binding.

Signed-off-by: Yannic Moog <y.moog@phytec.de>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Krzysztof Kozlowski March 28, 2025, 1:58 p.m. UTC | #1
On 28/03/2025 14:04, Yannic Moog wrote:
> imx8mp-libra-rdk-fpsc is a development board based on the phyCORE-i.MX 8M
> Plus FPSC SoM. Add its description and binding.
> 
> Signed-off-by: Yannic Moog <y.moog@phytec.de>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 1b90870958a22e49355dd1f932bf3d84cd864b5f..22f05e6709fd60bef1d22a378cf0bd57090774d4 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1156,6 +1156,13 @@ properties:
>            - const: kontron,imx8mp-osm-s               # Kontron i.MX8MP OSM-S SoM
>            - const: fsl,imx8mp
>  
> +      - description: PHYTEC phyCORE-i.MX8MP FPSC based boards
> +        items:
> +          - enum:
> +              - phytec,imx8mp-libra-rdk-fpsc  # i.MX 8M Plus Libra RDK
> +          - const: phytec,imx8mp-phycore-fpsc # phyCORE-i.MX 8M Plus FPSC

And that's different than existing phycore som? You have entire commit
msg to explain that.

Best regards,
Krzysztof
Yannic Moog March 31, 2025, 6:03 a.m. UTC | #2
Hi Krzysztof,

On Fri, 2025-03-28 at 14:58 +0100, Krzysztof Kozlowski wrote:
> On 28/03/2025 14:04, Yannic Moog wrote:
> > imx8mp-libra-rdk-fpsc is a development board based on the phyCORE-i.MX 8M
> > Plus FPSC SoM. Add its description and binding.
> > 
> > Signed-off-by: Yannic Moog <y.moog@phytec.de>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> > b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 1b90870958a22e49355dd1f932bf3d84cd864b5f..22f05e6709fd60bef1d22a378cf0bd57090774d4 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -1156,6 +1156,13 @@ properties:
> >            - const: kontron,imx8mp-osm-s               # Kontron i.MX8MP OSM-S SoM
> >            - const: fsl,imx8mp
> >  
> > +      - description: PHYTEC phyCORE-i.MX8MP FPSC based boards
> > +        items:
> > +          - enum:
> > +              - phytec,imx8mp-libra-rdk-fpsc  # i.MX 8M Plus Libra RDK
> > +          - const: phytec,imx8mp-phycore-fpsc # phyCORE-i.MX 8M Plus FPSC
> 
> And that's different than existing phycore som? You have entire commit
> msg to explain that.

Yes, it is different to the existing phycore som.
I explained the differences in the second patch which introduces the device trees.
Would you like me to also add the explanation to this patch, or move it here from the second patch?

Yannic

> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 1b90870958a22e49355dd1f932bf3d84cd864b5f..22f05e6709fd60bef1d22a378cf0bd57090774d4 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1156,6 +1156,13 @@  properties:
           - const: kontron,imx8mp-osm-s               # Kontron i.MX8MP OSM-S SoM
           - const: fsl,imx8mp
 
+      - description: PHYTEC phyCORE-i.MX8MP FPSC based boards
+        items:
+          - enum:
+              - phytec,imx8mp-libra-rdk-fpsc  # i.MX 8M Plus Libra RDK
+          - const: phytec,imx8mp-phycore-fpsc # phyCORE-i.MX 8M Plus FPSC
+          - const: fsl,imx8mp
+
       - description: PHYTEC phyCORE-i.MX8MP SoM based boards
         items:
           - const: phytec,imx8mp-phyboard-pollux-rdk # phyBOARD-Pollux RDK