From patchwork Fri Mar 28 03:02:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Zhu X-Patchwork-Id: 14031590 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBF7EC3600B for ; Fri, 28 Mar 2025 03:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k1HBKlc4akohXR2vCAAU8ZQjNpnESt0CqhEjTdNp8hE=; b=Ejh3a7n61t9ZnCajBJv1JTRJUj g34xcUJS63ixpbqpWanG3nQnB8hxjQ5EfcbZd1G2G+xZyIQ1wrpn2WMxKMIDE846Kdq7e1M8U1/9c EbBOxkjekQYE09NCqQa4W+dIzM3FuEPl4c/TcWxGBBaLvK1Xz68bEdvXMr/SerwkGeZLUpfZs/tNw GbqeRl6Q2DKFqQ62XZ7wCYq6I6xbhvHdNm/CndoV8qUAde/Vjw+w/y/K3Eg5FByWG64Ja4Qe9ANB/ MX+Ad0Ur19ci52vXPAcyum94Ljsv82+o+9NaQcm9GHFsnq2fTSBpwQbTihLgqY0uu+ylIgKZ5lHm2 76Je4V4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1ty05Y-0000000CTRJ-31YK; Fri, 28 Mar 2025 03:08:56 +0000 Received: from mail-db5eur02on20616.outbound.protection.outlook.com ([2a01:111:f403:2608::616] helo=EUR02-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1ty00R-0000000CSi2-2Xnu for linux-arm-kernel@lists.infradead.org; Fri, 28 Mar 2025 03:03:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UuBCjF53NEyLaSIOTnrOk/vEom18Ibh+EvX209Ps9ESONH0rsyowahRTnPCabtDqskjwJ74Wf+EvuIjnZZzEcXwvHJmeqzDaCEtryjk4E+kkfZtjv5ttUwYoxusvJyep197KxT7cRGqGz5cVDDFf7LGltJWnI7da4Lc53W9WTTq7Y708riFMA1F0IhsAqww1PaqKMn1ME4v7rEqSxEHl6INowU0dpydeOk5F0NzK984MTsvC4KlYQMcw5HtyBuox7Cziljd0ZO0ZW4H4JX4puoHCP9RIk4n/WjIG3xSz5kld11EbrkGSyCwCmdGjc/61aMM5Od/fPbLHIvbis/hjdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k1HBKlc4akohXR2vCAAU8ZQjNpnESt0CqhEjTdNp8hE=; b=DRSI3QqSbIrxj1JLWKqM5uSbTXVUpo0LCGJYSnTfWAE2LVrOYlg2s2QaKugFfYnl7ZwwxCSnp8w+hfdsWW4TtozG1S9+tNVzZufZIl62Fyv90P3yhOao/pipFjdP6h7rMQm/nfuiSFT0zq5YF8COHNjJxHb4PP+DCTa7bS+cNHzO1x/CA6mOiSB075NcLREBYVQ2z1nmhAvsx2nW/hhng8Hv/l8U9ACvQW4g/ALn/K+rT8LZb0LX1tZvHyiREv6MKFAcoZ2LtArnBTiQkf8zy/qtEc+pOZhRE0xRS8bfd7XoKSzc7ZPYXXN1aSntLX/paXVWPmiU7JrMq0nQ9uQ3/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k1HBKlc4akohXR2vCAAU8ZQjNpnESt0CqhEjTdNp8hE=; b=ZUI4ISac+AiHoH3zl618++su/RLZ7t5iDpiTMdBjdD43ak+jLgxTIXmQRfVZglu6c6R1rfBIi96tf8aFBSzJ0WysoEYTy9e2089IAIz8urPiSl70m4OQm6Pg8FJsyxJnf9t+aSggKPG0mDdnmHnSNbcwUCkZHuDDWbuZK7I9t62h53wRgz2OktCOnFpTnREMJhtvHT7gVOgwIhHxPb/jQ7i6vd3NjdMw1V6KIq0+uox/zAEenja5oL8ntzzOvCQ6oTPkukgpX+aqYhRn4QLpr7P8QEn8Y+T5U4kQ95LCbxEP+4oSU7BFlaCGrgsHhpYyUHHy80Z5/QUwFki8PUQyAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by AS8PR04MB8961.eurprd04.prod.outlook.com (2603:10a6:20b:42c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.44; Fri, 28 Mar 2025 03:03:38 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93%5]) with mapi id 15.20.8534.043; Fri, 28 Mar 2025 03:03:38 +0000 From: Richard Zhu To: frank.li@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu Subject: [PATCH v3 2/6] PCI: imx6: Toggle the cold reset for i.MX95 PCIe Date: Fri, 28 Mar 2025 11:02:09 +0800 Message-Id: <20250328030213.1650990-3-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250328030213.1650990-1-hongxing.zhu@nxp.com> References: <20250328030213.1650990-1-hongxing.zhu@nxp.com> X-ClientProxiedBy: SG2PR02CA0047.apcprd02.prod.outlook.com (2603:1096:3:18::35) To AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8676:EE_|AS8PR04MB8961:EE_ X-MS-Office365-Filtering-Correlation-Id: 1eebecd4-fa0e-4389-1c9b-08dd6da52329 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|1800799024|366016|38350700014|921020; X-Microsoft-Antispam-Message-Info: R0SubXs93naHdAB4QgqlojtH5AeC5CQs5nb5dLWm1DHI2l/Q/g2irpWpUYCGl+wmbR/K6aNaTYSL3HEJqqD8/OkYD2ay5ttjw5Kv7nSGZVB9rAcHjFjsmshWZ+93fYRoF8pVMvp3IVL1RiIXZPS9DuFqGtBJ9bOp5TwXOQmVOigkzhnlKva9D8hBDAh/gg0h4EsEQCJNRxvZyWvOjfDTvmWRfzEqlUOCLjqd+bg9MV88uOcXE6ELxoty4X0nfpt8iYAU0LlnkDAC2MUlVwoxX/PtD0DRY0rGbfYAUvniYsFUPvOb+ya8gywmQgC+EcHMV9TcBxg2XOp712NN5ytdY5m2NXkDRh53PpFsaPLsWs2F8jNl/TsFZWH7oWiiFe5Bwe1M+Lrv6aeCv+NWNmP2QbBflsa0c7l1EfKTyX1W+jn2W6APCYGrBUmj4RqusZWsMpfnxSB0jXLh6tlEEseQHY3g/oTqtaI7I3CDbnwotKy4sJ2N/r5kEG7Ieo7yHHQ8+0ByNmY1R8EOBDbENR7yvj0AJvwDIK3fi6yMzUl/Sd5BmlWAhK0j3bzTByq/9shgdMrqY2uqVEVEgb2sY5dMVmAR1XhAb47v7OOA2qjBwEyURise3BqWKt9FGMtis7EMAYXFduZsVlUk+XjYOY/lWO8liFvsQHWdyd3nW+wxa8KbOCjKfaV12/QXE6lnhnYXrCifBDVwCp/9GR2jkpxAtQI9uIP9lSOhcG4r0yVWrVv7XkW1WbBvQB/+fUA28cJnp47aPng7Jedf5bF7FWxKXYtaSfhYkoiRr0LDooAIOZusYn1UJytmIVzc9uv/2KmD1Ijef/Y6p0pyvBdclrfeNr8uUHcDiKxkgeXOAEm/oXhAEPGMOCpnwK6oZukmbUr2gbVZ5U9bzm2TmjPF59nYgbIVeGRKmNELKTjKb28QAIKnd0+IgipxIOjoGYNL+XaOUrjNNJ8ZaLRG44cYYNZ7mdMxbQuAacVb32Hynd1kumsSlcSbP+NUmYlmyG1kUx+0+qt+RrEkrhVKmlZVEBVI/B6YlR4F21SZS2v5p60Vmca1p8aICC21D6iDLdA7OkYfxhlzolr3sviLnzDEPVOnERkbigxKdFKTT3phum2MhJFAJzemWG6C3QbyI9lyqhQ1b7DDxTZiFv17M4PGnqxnUa9vw8XRYk73nvDySx8Xyf5V/K8FguN1n7HLZp3IIbKE7Y1uW/goKENjnrz7EvRjn8laicEbW8kXchH+4YSUXHmEWJK8v6+4St3RB8i+h3EL0JOmz+1FOCBpVyt6r9t0GGo0jeFuZ1UYRq5XbjtnM7ETEUI+Mduzb4m6NDAQLrtGwacJ9mixZm3TtTkFgL/dg9EvrVmTL1rhAZov9bV/3AoDRC/U0epNzLR2f7g64pkd1+cIQRvDiPwFmaPQHcNzxPuYwf+dwXEsBuTlv52qGoPIe2YqCQcZs3jVZLoPRHibglQ3ZEYGOgPougCQA4GSfg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8676.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(1800799024)(366016)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: AWTKiivEjK2VdaxiFgBEU+ftLDxc6z1nZjETDW37q3qspB7Y3Jq6lWXtjWNNJhPOA932hnQegEIJQChwO5ELh/+46vABmCrC2oRKIuc6rN7WONS2whZ7CODMigY1s8rLGHAh0VNvh4Ljtp3ewRw1jVxTbZOeARm5dcGZeZUmeTnXovzWs5izZzKbw3qnk5CMaGieMGigmqK+vos9IwMBw5qu3kj06KyZHLWZL1/fEvfl4rd8g3Y3LdTJISBS+mT447Za+BvraZIsgAE5uYWTiTcU8pKmuGOcxKmI7yQ5i8GOBxqDZ+rb3Ak7NcFKjx8dsmyXVPCMsSmknkS6Fp3bgyQbASfkryNxd4dDNLq73VN8yOMJNO+EwNQOdLooVCM2W8AFQ9ve8u5eYpQK+4Co2yeMKE5LrxL9uRt2zM8qm7WvcBeD9EkKXHuWwZxwNJt8wcj2tdLjMlAAiwesDr0SVfQxfFGacqeprel2RmCaOkyPcqWBHQqljauW0Xn0cwhrY3nIZ7upjiN7OWOMBgEQrVuCfD1iz6I1Xh/qUQZ9+hoSoVx3BO6ZFTxE5yfsGywFan3OdPSF/jnIvAThnqGWr12u4FhxKwZb6gg5KlWHB0fi9EslT9GDO5gdbXKCwf0RnebkwF/QGJ57nO87TUdfn2U4NL7QD2XBMO9KSOM1ix/S+z6Xjwlhf3Ka6wPHv3b5BlKBGd74t5io9+nkl4xsqyYxsaD2aCosHBFndMcWx7gjduZwVs7vnHIJ+pXY+0JmkdRYX1YepiHeUlfl3d1cW7+VmvDzZcXjr9g/Q1JRoWoCXFYGPAA86/s2SEjdGcdLCpHy7XGG5A7bt9khrvzyZdn2OwRcX6u63h/T7mCCQUgDHj3mbJdmtpL+NwRWpwMx+yI2EGsBETCFKC7QvK/dtGFhpm1LsOyjRmfudauDV/MuMNaGNS32wvZpJ+Or2MmbSsw0YmjZGEDh1AT8ccgQd/SXR1IHwiwv/Em/NV/OXFaoxRSmyWube1V7boSe/E7yAHmlM0fkp7b4VdMOC/vOcbyRuUhZpyWEMmO+oMm6aoRlIMO560kNi0N6ARonBWxgzv7kcqXbC9sqpnvixtVR4Uclo101Q/5FomBDLdZ6CFDSb8wZREQ5uqaC/5bPzT+O9vqF5U+MUrQcbSAy3H4sTVWlaje3pp3B7TlhJkm6S5kmVSNl/xzYa2/HvS9JUrNFF+8h/9qy/xxsgm7MG8nX15WZOT5p4nSftCSA28jK7UBuyOrWv/s3JFn63E/InkUxPVJy4i3OmCipTXi0LVJoKiSHKWzXI/McHMOR0imuFGArpPZxpL5uc6A2rz15T8/lpFDgy9j6u4FOnOD8EsWJOWqVPiTgrjzJANjIecTBkcxNTGN7rvpTz8v8KfBbYQdYHY0bQrY9MkSuuPSVjG+cyLETBcF6RJ5lW6ZfrJ0ONoBC6E9sfsAEEKb8V5YRBqPPolOrGdtUSlsbjj+Opw+Wed9juQGdJR9JIojF0RMLcHbvNc7AHw6njzLs61R8hbvj6GfvIFfjQLGgpoD86cfkFQQEOZ3lqY4QSI1mat4LotS/Xb9SewkZ3h5wBnXEaZZk X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1eebecd4-fa0e-4389-1c9b-08dd6da52329 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2025 03:03:38.6277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qxzPK015uO+4Gc62B1zEeN9FUCnIWm1j0wRmm/6loNbs5MrYMNjhRbBePA5DEXKLtEZ7LAqacYN8eBoxREbysA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8961 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250327_200339_646824_1A5E2179 X-CRM114-Status: GOOD ( 12.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add the cold reset toggle for i.MX95 PCIe to align PHY's power up sequency. Signed-off-by: Richard Zhu Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 42 +++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 57aa777231ae..6051b3b5928f 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -71,6 +71,9 @@ #define IMX95_SID_MASK GENMASK(5, 0) #define IMX95_MAX_LUT 32 +#define IMX95_PCIE_RST_CTRL 0x3010 +#define IMX95_PCIE_COLD_RST BIT(0) + #define to_imx_pcie(x) dev_get_drvdata((x)->dev) enum imx_pcie_variants { @@ -773,6 +776,43 @@ static int imx7d_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) return 0; } +static int imx95_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) +{ + u32 val; + + if (assert) { + /* + * From i.MX95 PCIe PHY perspective, the COLD reset toggle + * should be complete after power-up by the following sequence. + * > 10us(at power-up) + * > 10ns(warm reset) + * |<------------>| + * ______________ + * phy_reset ____/ \________________ + * ____________ + * ref_clk_en_______________________/ + * Toggle COLD reset aligned with this sequence for i.MX95 PCIe. + */ + regmap_set_bits(imx_pcie->iomuxc_gpr, IMX95_PCIE_RST_CTRL, + IMX95_PCIE_COLD_RST); + /* + * To make sure delay enough time, do regmap_read_bypassed + * before udelay(). Since udelay() might not use MMIO, and cause + * delay time less than setting value. + */ + regmap_read_bypassed(imx_pcie->iomuxc_gpr, IMX95_PCIE_RST_CTRL, + &val); + udelay(15); + regmap_clear_bits(imx_pcie->iomuxc_gpr, IMX95_PCIE_RST_CTRL, + IMX95_PCIE_COLD_RST); + regmap_read_bypassed(imx_pcie->iomuxc_gpr, IMX95_PCIE_RST_CTRL, + &val); + udelay(10); + } + + return 0; +} + static void imx_pcie_assert_core_reset(struct imx_pcie *imx_pcie) { reset_control_assert(imx_pcie->pciephy_reset); @@ -1762,6 +1802,7 @@ static const struct imx_pcie_drvdata drvdata[] = { .ltssm_mask = IMX95_PCIE_LTSSM_EN, .mode_off[0] = IMX95_PE0_GEN_CTRL_1, .mode_mask[0] = IMX95_PCIE_DEVICE_TYPE, + .core_reset = imx95_pcie_core_reset, .init_phy = imx95_pcie_init_phy, }, [IMX8MQ_EP] = { @@ -1815,6 +1856,7 @@ static const struct imx_pcie_drvdata drvdata[] = { .mode_off[0] = IMX95_PE0_GEN_CTRL_1, .mode_mask[0] = IMX95_PCIE_DEVICE_TYPE, .init_phy = imx95_pcie_init_phy, + .core_reset = imx95_pcie_core_reset, .epc_features = &imx95_pcie_epc_features, .mode = DW_PCIE_EP_TYPE, },