| Message ID | 20250331103116.2223899-2-lukma@denx.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | net: mtip: Add support for MTIP imx287 L2 switch driver | expand |
Hi Lukasz, On Mon, Mar 31, 2025 at 7:31 AM Lukasz Majewski <lukma@denx.de> wrote: > +properties: > + compatible: > + const: nxp,imx287-mtip-switch For consistency, please use "nxp,imx28-mtip-switch" instead. imx287 is not used anywhere in the kernel.
Hi Fabio, > Hi Lukasz, > > On Mon, Mar 31, 2025 at 7:31 AM Lukasz Majewski <lukma@denx.de> wrote: > > > +properties: > > + compatible: > > + const: nxp,imx287-mtip-switch > > For consistency, please use "nxp,imx28-mtip-switch" instead. > > imx287 is not used anywhere in the kernel. Ok. Thanks for the info. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Mon, Mar 31, 2025 at 12:31:13PM +0200, Lukasz Majewski wrote: > This patch provides description of the MTIP L2 switch available in some > NXP's SOCs - e.g. imx287. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > --- > Changes for v2: > - Rename the file to match exactly the compatible > (nxp,imx287-mtip-switch) > > Changes for v3: > - Remove '-' from const:'nxp,imx287-mtip-switch' > - Use '^port@[12]+$' for port patternProperties > - Drop status = "okay"; > - Provide proper indentation for 'example' binding (replace 8 > spaces with 4 spaces) > - Remove smsc,disable-energy-detect; property > - Remove interrupt-parent and interrupts properties as not required > - Remove #address-cells and #size-cells from required properties check > - remove description from reg: > - Add $ref: ethernet-switch.yaml# > --- > .../bindings/net/nxp,imx287-mtip-switch.yaml | 154 ++++++++++++++++++ > 1 file changed, 154 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > diff --git a/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > new file mode 100644 > index 000000000000..98eba3665f32 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > @@ -0,0 +1,154 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/nxp,imx287-mtip-switch.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP SoC Ethernet Switch Controller (L2 MoreThanIP switch) > + > +maintainers: > + - Lukasz Majewski <lukma@denx.de> > + > +description: > + The 2-port switch ethernet subsystem provides ethernet packet (L2) > + communication and can be configured as an ethernet switch. It provides the > + reduced media independent interface (RMII), the management data input > + output (MDIO) for physical layer device (PHY) management. > + > +$ref: ethernet-switch.yaml# This needs to be: ethernet-switch.yaml#/$defs/ethernet-ports With that, you can drop much of the below part. More below... > + > +properties: > + compatible: > + const: nxp,imx287-mtip-switch > + > + reg: > + maxItems: 1 > + > + phy-supply: > + description: > + Regulator that powers Ethernet PHYs. > + > + clocks: > + items: > + - description: Register accessing clock > + - description: Bus access clock > + - description: Output clock for external device - e.g. PHY source clock > + - description: IEEE1588 timer clock > + > + clock-names: > + items: > + - const: ipg > + - const: ahb > + - const: enet_out > + - const: ptp > + > + interrupts: > + items: > + - description: Switch interrupt > + - description: ENET0 interrupt > + - description: ENET1 interrupt > + > + pinctrl-names: true > + > + ethernet-ports: > + type: object > + additionalProperties: false > + > + properties: > + '#address-cells': > + const: 1 > + '#size-cells': > + const: 0 > + > + patternProperties: > + '^port@[12]+$': Note that 'ethernet-port' is the preferred node name though 'port' is allowed. > + type: object > + description: MTIP L2 switch external ports > + > + $ref: ethernet-controller.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + items: > + - enum: [1, 2] > + description: MTIP L2 switch port number > + > + label: > + description: Label associated with this port > + > + required: > + - reg > + - label > + - phy-mode > + - phy-handle All the above under 'ethernet-ports' can be dropped though you might want to keep 'required' part. > + > + mdio: > + type: object > + $ref: mdio.yaml# > + unevaluatedProperties: false > + description: > + Specifies the mdio bus in the switch, used as a container for phy nodes. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - mdio > + - ethernet-ports > + > +additionalProperties: false > + > +examples: > + - | > + #include<dt-bindings/interrupt-controller/irq.h> > + switch@800f0000 { > + compatible = "nxp,imx287-mtip-switch"; > + reg = <0x800f0000 0x20000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&mac0_pins_a>, <&mac1_pins_a>; > + phy-supply = <®_fec_3v3>; > + interrupts = <100>, <101>, <102>; > + clocks = <&clks 57>, <&clks 57>, <&clks 64>, <&clks 35>; > + clock-names = "ipg", "ahb", "enet_out", "ptp"; > + > + ethernet-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mtip_port1: port@1 { > + reg = <1>; > + label = "lan0"; > + local-mac-address = [ 00 00 00 00 00 00 ]; > + phy-mode = "rmii"; > + phy-handle = <ðphy0>; > + }; > + > + mtip_port2: port@2 { > + reg = <2>; > + label = "lan1"; > + local-mac-address = [ 00 00 00 00 00 00 ]; > + phy-mode = "rmii"; > + phy-handle = <ðphy1>; > + }; > + }; > + > + mdio_sw: mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reset-gpios = <&gpio2 13 0>; > + reset-delay-us = <25000>; > + reset-post-delay-us = <10000>; > + > + ethphy0: ethernet-phy@0 { > + reg = <0>; > + }; > + > + ethphy1: ethernet-phy@1 { > + reg = <1>; > + }; > + }; > + }; > -- > 2.39.5 >
Hi Rob, > On Mon, Mar 31, 2025 at 12:31:13PM +0200, Lukasz Majewski wrote: > > This patch provides description of the MTIP L2 switch available in > > some NXP's SOCs - e.g. imx287. > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > > --- > > Changes for v2: > > - Rename the file to match exactly the compatible > > (nxp,imx287-mtip-switch) > > > > Changes for v3: > > - Remove '-' from const:'nxp,imx287-mtip-switch' > > - Use '^port@[12]+$' for port patternProperties > > - Drop status = "okay"; > > - Provide proper indentation for 'example' binding (replace 8 > > spaces with 4 spaces) > > - Remove smsc,disable-energy-detect; property > > - Remove interrupt-parent and interrupts properties as not required > > - Remove #address-cells and #size-cells from required properties > > check > > - remove description from reg: > > - Add $ref: ethernet-switch.yaml# > > --- > > .../bindings/net/nxp,imx287-mtip-switch.yaml | 154 > > ++++++++++++++++++ 1 file changed, 154 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > new file mode 100644 index 000000000000..98eba3665f32 --- /dev/null > > +++ > > b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > @@ -0,0 +1,154 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR > > BSD-2-Clause) +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/nxp,imx287-mtip-switch.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NXP SoC Ethernet Switch Controller (L2 MoreThanIP switch) > > + > > +maintainers: > > + - Lukasz Majewski <lukma@denx.de> > > + > > +description: > > + The 2-port switch ethernet subsystem provides ethernet packet > > (L2) > > + communication and can be configured as an ethernet switch. It > > provides the > > + reduced media independent interface (RMII), the management data > > input > > + output (MDIO) for physical layer device (PHY) management. > > + > > +$ref: ethernet-switch.yaml# > > This needs to be: ethernet-switch.yaml#/$defs/ethernet-ports > > With that, you can drop much of the below part. More below... > > > + > > +properties: So it shall be after the "properties:" $ref: ethernet-switch.yaml#/$defs/ethernet-ports [*] > > + compatible: > > + const: nxp,imx287-mtip-switch > > + > > + reg: > > + maxItems: 1 > > + > > + phy-supply: > > + description: > > + Regulator that powers Ethernet PHYs. > > + > > + clocks: > > + items: > > + - description: Register accessing clock > > + - description: Bus access clock > > + - description: Output clock for external device - e.g. PHY > > source clock > > + - description: IEEE1588 timer clock > > + > > + clock-names: > > + items: > > + - const: ipg > > + - const: ahb > > + - const: enet_out > > + - const: ptp > > + > > + interrupts: > > + items: > > + - description: Switch interrupt > > + - description: ENET0 interrupt > > + - description: ENET1 interrupt > > + > > + pinctrl-names: true > > + > > > + ethernet-ports: And then this "node" can be removed as it has been referenced above [*]? (I shall only keep the properties, which are not standard to [*] if any). > > + type: object > > + additionalProperties: false > > + > > + properties: > > + '#address-cells': > > + const: 1 > > + '#size-cells': > > + const: 0 > > + > > + patternProperties: > > + '^port@[12]+$': > > Note that 'ethernet-port' is the preferred node name though 'port' is > allowed. Ok. That would be the correct define: ethernet-ports { mtip_port1: ethernet-port@1 { reg = <1>; label = "lan0"; local-mac-address = [ 00 00 00 00 00 00 ]; phy-mode = "rmii"; phy-handle = <ðphy0>; }; mtip_port2: port@2 { .... }; > > > + type: object > > + description: MTIP L2 switch external ports > > + > > + $ref: ethernet-controller.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + reg: > > + items: > > + - enum: [1, 2] > > + description: MTIP L2 switch port number > > + > > + label: > > + description: Label associated with this port > > + > > + required: > > + - reg > > + - label > > + - phy-mode > > + - phy-handle > > All the above under 'ethernet-ports' can be dropped though you might > want to keep 'required' part. Ok, I will keep it. > > > + > > + mdio: > > + type: object > > + $ref: mdio.yaml# > > + unevaluatedProperties: false > > + description: > > + Specifies the mdio bus in the switch, used as a container > > for phy nodes. + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - interrupts > > + - mdio > > + - ethernet-ports > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include<dt-bindings/interrupt-controller/irq.h> > > + switch@800f0000 { > > + compatible = "nxp,imx287-mtip-switch"; > > + reg = <0x800f0000 0x20000>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&mac0_pins_a>, <&mac1_pins_a>; > > + phy-supply = <®_fec_3v3>; > > + interrupts = <100>, <101>, <102>; > > + clocks = <&clks 57>, <&clks 57>, <&clks 64>, <&clks 35>; > > + clock-names = "ipg", "ahb", "enet_out", "ptp"; > > + > > + ethernet-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + mtip_port1: port@1 { > > + reg = <1>; > > + label = "lan0"; > > + local-mac-address = [ 00 00 00 00 00 00 ]; > > + phy-mode = "rmii"; > > + phy-handle = <ðphy0>; > > + }; > > + > > + mtip_port2: port@2 { > > + reg = <2>; > > + label = "lan1"; > > + local-mac-address = [ 00 00 00 00 00 00 ]; > > + phy-mode = "rmii"; > > + phy-handle = <ðphy1>; > > + }; > > + }; > > + > > + mdio_sw: mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + reset-gpios = <&gpio2 13 0>; > > + reset-delay-us = <25000>; > > + reset-post-delay-us = <10000>; > > + > > + ethphy0: ethernet-phy@0 { > > + reg = <0>; > > + }; > > + > > + ethphy1: ethernet-phy@1 { > > + reg = <1>; > > + }; > > + }; > > + }; > > -- > > 2.39.5 > > Thanks for the hint. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Tue, Apr 01, 2025 at 12:35:07PM +0200, Lukasz Majewski wrote: > Hi Rob, > > > On Mon, Mar 31, 2025 at 12:31:13PM +0200, Lukasz Majewski wrote: > > > This patch provides description of the MTIP L2 switch available in > > > some NXP's SOCs - e.g. imx287. > > > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > > > --- > > > Changes for v2: > > > - Rename the file to match exactly the compatible > > > (nxp,imx287-mtip-switch) > > > > > > Changes for v3: > > > - Remove '-' from const:'nxp,imx287-mtip-switch' > > > - Use '^port@[12]+$' for port patternProperties > > > - Drop status = "okay"; > > > - Provide proper indentation for 'example' binding (replace 8 > > > spaces with 4 spaces) > > > - Remove smsc,disable-energy-detect; property > > > - Remove interrupt-parent and interrupts properties as not required > > > - Remove #address-cells and #size-cells from required properties > > > check > > > - remove description from reg: > > > - Add $ref: ethernet-switch.yaml# > > > --- > > > .../bindings/net/nxp,imx287-mtip-switch.yaml | 154 > > > ++++++++++++++++++ 1 file changed, 154 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > > > > > diff --git > > > a/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > > b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > > new file mode 100644 index 000000000000..98eba3665f32 --- /dev/null > > > +++ > > > b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > > @@ -0,0 +1,154 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR > > > BSD-2-Clause) +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/net/nxp,imx287-mtip-switch.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: NXP SoC Ethernet Switch Controller (L2 MoreThanIP switch) > > > + > > > +maintainers: > > > + - Lukasz Majewski <lukma@denx.de> > > > + > > > +description: > > > + The 2-port switch ethernet subsystem provides ethernet packet > > > (L2) > > > + communication and can be configured as an ethernet switch. It > > > provides the > > > + reduced media independent interface (RMII), the management data > > > input > > > + output (MDIO) for physical layer device (PHY) management. > > > + > > > +$ref: ethernet-switch.yaml# > > > > This needs to be: ethernet-switch.yaml#/$defs/ethernet-ports > > > > With that, you can drop much of the below part. More below... > > > > > + > > > +properties: > > So it shall be after the "properties:" > > $ref: ethernet-switch.yaml#/$defs/ethernet-ports [*] It can stay where it is, just add "/$defs/ethernet-ports" > > > + compatible: > > > + const: nxp,imx287-mtip-switch > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + phy-supply: > > > + description: > > > + Regulator that powers Ethernet PHYs. > > > + > > > + clocks: > > > + items: > > > + - description: Register accessing clock > > > + - description: Bus access clock > > > + - description: Output clock for external device - e.g. PHY > > > source clock > > > + - description: IEEE1588 timer clock > > > + > > > + clock-names: > > > + items: > > > + - const: ipg > > > + - const: ahb > > > + - const: enet_out > > > + - const: ptp > > > + > > > + interrupts: > > > + items: > > > + - description: Switch interrupt > > > + - description: ENET0 interrupt > > > + - description: ENET1 interrupt > > > + > > > + pinctrl-names: true > > > + > > > > > + ethernet-ports: > > And then this "node" can be removed as it has been referenced above [*]? Well, you have to keep it to have 'required' in the child nodes. > > (I shall only keep the properties, which are not standard to [*] if > any). > > > > + type: object > > > + additionalProperties: false > > > + > > > + properties: > > > + '#address-cells': > > > + const: 1 > > > + '#size-cells': > > > + const: 0 > > > + > > > + patternProperties: > > > + '^port@[12]+$': > > > > Note that 'ethernet-port' is the preferred node name though 'port' is > > allowed. > > Ok. That would be the correct define: > > ethernet-ports { > mtip_port1: ethernet-port@1 { > reg = <1>; > label = "lan0"; > local-mac-address = [ 00 00 00 00 00 00 ]; > phy-mode = "rmii"; > phy-handle = <ðphy0>; > }; > > mtip_port2: port@2 { And here... > .... > }; > > > > > > + type: object > > > + description: MTIP L2 switch external ports > > > + > > > + $ref: ethernet-controller.yaml# > > > + unevaluatedProperties: false > > > + > > > + properties: > > > + reg: > > > + items: > > > + - enum: [1, 2] > > > + description: MTIP L2 switch port number > > > + > > > + label: > > > + description: Label associated with this port > > > + > > > + required: > > > + - reg > > > + - label > > > + - phy-mode > > > + - phy-handle > > > > All the above under 'ethernet-ports' can be dropped though you might > > want to keep 'required' part. > > Ok, I will keep it. So I think you just want this: ethernet-ports: type: object additionalProperties: true # Check if you need this patternProperties: '^ethernet-port@[12]$': required: - label - phy-mode - phy-handle Rob
On Tue, 1 Apr 2025 18:03:46 -0500 Rob Herring <robh@kernel.org> wrote: > On Tue, Apr 01, 2025 at 12:35:07PM +0200, Lukasz Majewski wrote: > > Hi Rob, > > > > > On Mon, Mar 31, 2025 at 12:31:13PM +0200, Lukasz Majewski wrote: > > > > This patch provides description of the MTIP L2 switch available > > > > in some NXP's SOCs - e.g. imx287. > > > > > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > > > > --- > > > > Changes for v2: > > > > - Rename the file to match exactly the compatible > > > > (nxp,imx287-mtip-switch) > > > > > > > > Changes for v3: > > > > - Remove '-' from const:'nxp,imx287-mtip-switch' > > > > - Use '^port@[12]+$' for port patternProperties > > > > - Drop status = "okay"; > > > > - Provide proper indentation for 'example' binding (replace 8 > > > > spaces with 4 spaces) > > > > - Remove smsc,disable-energy-detect; property > > > > - Remove interrupt-parent and interrupts properties as not > > > > required > > > > - Remove #address-cells and #size-cells from required properties > > > > check > > > > - remove description from reg: > > > > - Add $ref: ethernet-switch.yaml# > > > > --- > > > > .../bindings/net/nxp,imx287-mtip-switch.yaml | 154 > > > > ++++++++++++++++++ 1 file changed, 154 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > > > b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > > > new file mode 100644 index 000000000000..98eba3665f32 --- > > > > /dev/null +++ > > > > b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml > > > > @@ -0,0 +1,154 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR > > > > BSD-2-Clause) +%YAML 1.2 > > > > +--- > > > > +$id: > > > > http://devicetree.org/schemas/net/nxp,imx287-mtip-switch.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# + > > > > +title: NXP SoC Ethernet Switch Controller (L2 MoreThanIP > > > > switch) + > > > > +maintainers: > > > > + - Lukasz Majewski <lukma@denx.de> > > > > + > > > > +description: > > > > + The 2-port switch ethernet subsystem provides ethernet packet > > > > (L2) > > > > + communication and can be configured as an ethernet switch. It > > > > provides the > > > > + reduced media independent interface (RMII), the management > > > > data input > > > > + output (MDIO) for physical layer device (PHY) management. > > > > + > > > > +$ref: ethernet-switch.yaml# > > > > > > This needs to be: ethernet-switch.yaml#/$defs/ethernet-ports > > > > > > With that, you can drop much of the below part. More below... > > > > > > > + > > > > +properties: > > > > So it shall be after the "properties:" > > > > $ref: ethernet-switch.yaml#/$defs/ethernet-ports [*] > > It can stay where it is, just add "/$defs/ethernet-ports" > > > > > > + compatible: > > > > + const: nxp,imx287-mtip-switch > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + phy-supply: > > > > + description: > > > > + Regulator that powers Ethernet PHYs. > > > > + > > > > + clocks: > > > > + items: > > > > + - description: Register accessing clock > > > > + - description: Bus access clock > > > > + - description: Output clock for external device - e.g. > > > > PHY source clock > > > > + - description: IEEE1588 timer clock > > > > + > > > > + clock-names: > > > > + items: > > > > + - const: ipg > > > > + - const: ahb > > > > + - const: enet_out > > > > + - const: ptp > > > > + > > > > + interrupts: > > > > + items: > > > > + - description: Switch interrupt > > > > + - description: ENET0 interrupt > > > > + - description: ENET1 interrupt > > > > + > > > > + pinctrl-names: true > > > > + > > > > > > > + ethernet-ports: > > > > And then this "node" can be removed as it has been referenced above > > [*]? > > Well, you have to keep it to have 'required' in the child nodes. > > > > > (I shall only keep the properties, which are not standard to [*] if > > any). > > > > > > + type: object > > > > + additionalProperties: false > > > > + > > > > + properties: > > > > + '#address-cells': > > > > + const: 1 > > > > + '#size-cells': > > > > + const: 0 > > > > + > > > > + patternProperties: > > > > + '^port@[12]+$': > > > > > > Note that 'ethernet-port' is the preferred node name though > > > 'port' is allowed. > > > > Ok. That would be the correct define: > > > > ethernet-ports { > > mtip_port1: ethernet-port@1 { > > reg = <1>; > > label = "lan0"; > > local-mac-address = [ 00 00 00 00 00 00 ]; > > phy-mode = "rmii"; > > phy-handle = <ðphy0>; > > }; > > > > mtip_port2: port@2 { > > And here... > > > .... > > }; > > > > > > > > > + type: object > > > > + description: MTIP L2 switch external ports > > > > + > > > > + $ref: ethernet-controller.yaml# > > > > + unevaluatedProperties: false > > > > + > > > > + properties: > > > > + reg: > > > > + items: > > > > + - enum: [1, 2] > > > > + description: MTIP L2 switch port number > > > > + > > > > + label: > > > > + description: Label associated with this port > > > > + > > > > + required: > > > > + - reg > > > > + - label > > > > + - phy-mode > > > > + - phy-handle > > > > > > All the above under 'ethernet-ports' can be dropped though you > > > might want to keep 'required' part. > > > > Ok, I will keep it. > > So I think you just want this: > > ethernet-ports: > type: object > additionalProperties: true # Check if you need this > > patternProperties: > '^ethernet-port@[12]$': > required: > - label > - phy-mode > - phy-handle > I had to add: $ref: ethernet-switch.yaml#/$defs/ethernet-ports patternProperties: "^(ethernet-)?ports$": type: object additionalProperties: true after the description: to avoid issues when checking DT schema. Simple adding patternProperties: '^ethernet-port@[12]$': required: - label - phy-mode - phy-handle Causes more errors. > Rob Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml new file mode 100644 index 000000000000..98eba3665f32 --- /dev/null +++ b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml @@ -0,0 +1,154 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/nxp,imx287-mtip-switch.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP SoC Ethernet Switch Controller (L2 MoreThanIP switch) + +maintainers: + - Lukasz Majewski <lukma@denx.de> + +description: + The 2-port switch ethernet subsystem provides ethernet packet (L2) + communication and can be configured as an ethernet switch. It provides the + reduced media independent interface (RMII), the management data input + output (MDIO) for physical layer device (PHY) management. + +$ref: ethernet-switch.yaml# + +properties: + compatible: + const: nxp,imx287-mtip-switch + + reg: + maxItems: 1 + + phy-supply: + description: + Regulator that powers Ethernet PHYs. + + clocks: + items: + - description: Register accessing clock + - description: Bus access clock + - description: Output clock for external device - e.g. PHY source clock + - description: IEEE1588 timer clock + + clock-names: + items: + - const: ipg + - const: ahb + - const: enet_out + - const: ptp + + interrupts: + items: + - description: Switch interrupt + - description: ENET0 interrupt + - description: ENET1 interrupt + + pinctrl-names: true + + ethernet-ports: + type: object + additionalProperties: false + + properties: + '#address-cells': + const: 1 + '#size-cells': + const: 0 + + patternProperties: + '^port@[12]+$': + type: object + description: MTIP L2 switch external ports + + $ref: ethernet-controller.yaml# + unevaluatedProperties: false + + properties: + reg: + items: + - enum: [1, 2] + description: MTIP L2 switch port number + + label: + description: Label associated with this port + + required: + - reg + - label + - phy-mode + - phy-handle + + mdio: + type: object + $ref: mdio.yaml# + unevaluatedProperties: false + description: + Specifies the mdio bus in the switch, used as a container for phy nodes. + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + - mdio + - ethernet-ports + +additionalProperties: false + +examples: + - | + #include<dt-bindings/interrupt-controller/irq.h> + switch@800f0000 { + compatible = "nxp,imx287-mtip-switch"; + reg = <0x800f0000 0x20000>; + pinctrl-names = "default"; + pinctrl-0 = <&mac0_pins_a>, <&mac1_pins_a>; + phy-supply = <®_fec_3v3>; + interrupts = <100>, <101>, <102>; + clocks = <&clks 57>, <&clks 57>, <&clks 64>, <&clks 35>; + clock-names = "ipg", "ahb", "enet_out", "ptp"; + + ethernet-ports { + #address-cells = <1>; + #size-cells = <0>; + + mtip_port1: port@1 { + reg = <1>; + label = "lan0"; + local-mac-address = [ 00 00 00 00 00 00 ]; + phy-mode = "rmii"; + phy-handle = <ðphy0>; + }; + + mtip_port2: port@2 { + reg = <2>; + label = "lan1"; + local-mac-address = [ 00 00 00 00 00 00 ]; + phy-mode = "rmii"; + phy-handle = <ðphy1>; + }; + }; + + mdio_sw: mdio { + #address-cells = <1>; + #size-cells = <0>; + + reset-gpios = <&gpio2 13 0>; + reset-delay-us = <25000>; + reset-post-delay-us = <10000>; + + ethphy0: ethernet-phy@0 { + reg = <0>; + }; + + ethphy1: ethernet-phy@1 { + reg = <1>; + }; + }; + };
This patch provides description of the MTIP L2 switch available in some NXP's SOCs - e.g. imx287. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- Changes for v2: - Rename the file to match exactly the compatible (nxp,imx287-mtip-switch) Changes for v3: - Remove '-' from const:'nxp,imx287-mtip-switch' - Use '^port@[12]+$' for port patternProperties - Drop status = "okay"; - Provide proper indentation for 'example' binding (replace 8 spaces with 4 spaces) - Remove smsc,disable-energy-detect; property - Remove interrupt-parent and interrupts properties as not required - Remove #address-cells and #size-cells from required properties check - remove description from reg: - Add $ref: ethernet-switch.yaml# --- .../bindings/net/nxp,imx287-mtip-switch.yaml | 154 ++++++++++++++++++ 1 file changed, 154 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml