| Message ID | 20250409134128.2098195-2-y-abhilashchandra@ti.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fix dtbs_check warnings in CSI overlays | expand |
Hi Abhilash On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote: > Add device tree nodes for two power regulators on the J721E SK board. > vsys_5v0: A fixed regulator representing the 5V supply output from the > LM61460 and vdd_sd_dv: A GPIO-controlled TLV71033 regulator. > > J721E-SK schematics: https://www.ti.com/lit/zip/sprr438 > Fixes: 1bfda92a3a36 ("arm64: dts: ti: Add support for J721E SK") > Cc: stable@vger.kernel.org > Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com> > --- > arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 31 ++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > index 440ef57be294..4965957e6545 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > @@ -184,6 +184,17 @@ vsys_3v3: fixedregulator-vsys3v3 { > regulator-boot-on; > }; > > + vsys_5v0: fixedregulator-vsys5v0 { > + /* Output of LM61460 */ > + compatible = "regulator-fixed"; > + regulator-name = "vsys_5v0"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <&vusb_main>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > vdd_mmc1: fixedregulator-sd { > compatible = "regulator-fixed"; > pinctrl-names = "default"; > @@ -211,6 +222,20 @@ vdd_sd_dv_alt: gpio-regulator-tps659411 { > <3300000 0x1>; > }; > > + vdd_sd_dv: gpio-regulator-TLV71033 { > + compatible = "regulator-gpio"; > + pinctrl-names = "default"; > + pinctrl-0 = <&vdd_sd_dv_pins_default>; > + regulator-name = "tlv71033"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + vin-supply = <&vsys_5v0>; > + gpios = <&main_gpio0 118 GPIO_ACTIVE_HIGH>; > + states = <1800000 0x0>, > + <3300000 0x1>; > + }; > + > transceiver1: can-phy1 { > compatible = "ti,tcan1042"; > #phy-cells = <0>; > @@ -613,6 +638,12 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26) WKUP_GPIO0_9 */ > >; > }; > > + vdd_sd_dv_pins_default: vdd-sd-dv-default-pins { > + pinctrl-single,pins = < > + J721E_IOPAD(0x1dc, PIN_INPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */ > + >; > + }; > + > wkup_uart0_pins_default: wkup-uart0-default-pins { > pinctrl-single,pins = < > J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */ Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote: > Add device tree nodes for two power regulators on the J721E SK board. > vsys_5v0: A fixed regulator representing the 5V supply output from the > LM61460 and vdd_sd_dv: A GPIO-controlled TLV71033 regulator. > > J721E-SK schematics: https://www.ti.com/lit/zip/sprr438 > Fixes: 1bfda92a3a36 ("arm64: dts: ti: Add support for J721E SK") For me does not looks like a fix, you can adding missing nodes > Cc: stable@vger.kernel.org > Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com> > --- > arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 31 ++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > index 440ef57be294..4965957e6545 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > @@ -184,6 +184,17 @@ vsys_3v3: fixedregulator-vsys3v3 { > regulator-boot-on; > }; > > + vsys_5v0: fixedregulator-vsys5v0 { > + /* Output of LM61460 */ > + compatible = "regulator-fixed"; > + regulator-name = "vsys_5v0"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <&vusb_main>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > vdd_mmc1: fixedregulator-sd { > compatible = "regulator-fixed"; > pinctrl-names = "default"; > @@ -211,6 +222,20 @@ vdd_sd_dv_alt: gpio-regulator-tps659411 { > <3300000 0x1>; > }; > > + vdd_sd_dv: gpio-regulator-TLV71033 { > + compatible = "regulator-gpio"; > + pinctrl-names = "default"; > + pinctrl-0 = <&vdd_sd_dv_pins_default>; > + regulator-name = "tlv71033"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + vin-supply = <&vsys_5v0>; > + gpios = <&main_gpio0 118 GPIO_ACTIVE_HIGH>; > + states = <1800000 0x0>, > + <3300000 0x1>; > + }; > + > transceiver1: can-phy1 { > compatible = "ti,tcan1042"; > #phy-cells = <0>; > @@ -613,6 +638,12 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26) WKUP_GPIO0_9 */ > >; > }; > > + vdd_sd_dv_pins_default: vdd-sd-dv-default-pins { > + pinctrl-single,pins = < > + J721E_IOPAD(0x1dc, PIN_INPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */ Shouldn't be this pin be output to control regulator ? > + >; > + }; > + > wkup_uart0_pins_default: wkup-uart0-default-pins { > pinctrl-single,pins = < > J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
Hi Udit, On 11/04/25 19:04, Kumar, Udit wrote: > > On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote: >> Add device tree nodes for two power regulators on the J721E SK board. >> vsys_5v0: A fixed regulator representing the 5V supply output from the >> LM61460 and vdd_sd_dv: A GPIO-controlled TLV71033 regulator. >> >> J721E-SK schematics: https://www.ti.com/lit/zip/sprr438 >> Fixes: 1bfda92a3a36 ("arm64: dts: ti: Add support for J721E SK") > > For me does not looks like a fix, you can adding missing nodes > Since we are adding the regulator nodes in the sensor overlay, (Patch 4 of this series) which in turn references these regulator nodes, I have included the Fixes tag in this patch as well. > >> Cc: stable@vger.kernel.org >> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 31 ++++++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts >> b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts >> index 440ef57be294..4965957e6545 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts >> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts >> @@ -184,6 +184,17 @@ vsys_3v3: fixedregulator-vsys3v3 { >> regulator-boot-on; >> }; >> + vsys_5v0: fixedregulator-vsys5v0 { >> + /* Output of LM61460 */ >> + compatible = "regulator-fixed"; >> + regulator-name = "vsys_5v0"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + vin-supply = <&vusb_main>; >> + regulator-always-on; >> + regulator-boot-on; >> + }; >> + >> vdd_mmc1: fixedregulator-sd { >> compatible = "regulator-fixed"; >> pinctrl-names = "default"; >> @@ -211,6 +222,20 @@ vdd_sd_dv_alt: gpio-regulator-tps659411 { >> <3300000 0x1>; >> }; >> + vdd_sd_dv: gpio-regulator-TLV71033 { >> + compatible = "regulator-gpio"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&vdd_sd_dv_pins_default>; >> + regulator-name = "tlv71033"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-boot-on; >> + vin-supply = <&vsys_5v0>; >> + gpios = <&main_gpio0 118 GPIO_ACTIVE_HIGH>; >> + states = <1800000 0x0>, >> + <3300000 0x1>; >> + }; >> + >> transceiver1: can-phy1 { >> compatible = "ti,tcan1042"; >> #phy-cells = <0>; >> @@ -613,6 +638,12 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26) >> WKUP_GPIO0_9 */ >> >; >> }; >> + vdd_sd_dv_pins_default: vdd-sd-dv-default-pins { >> + pinctrl-single,pins = < >> + J721E_IOPAD(0x1dc, PIN_INPUT, 7) /* (Y1) >> SPI1_CLK.GPIO0_118 */ > > Shouldn't be this pin be output to control regulator ? > Yes, I will correct this in the next revision. Thanks and Regards Yemike Abhilash Chandra > >> + >; >> + }; >> + >> wkup_uart0_pins_default: wkup-uart0-default-pins { >> pinctrl-single,pins = < >> J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) >> WKUP_UART0_RXD */
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts index 440ef57be294..4965957e6545 100644 --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts @@ -184,6 +184,17 @@ vsys_3v3: fixedregulator-vsys3v3 { regulator-boot-on; }; + vsys_5v0: fixedregulator-vsys5v0 { + /* Output of LM61460 */ + compatible = "regulator-fixed"; + regulator-name = "vsys_5v0"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + vin-supply = <&vusb_main>; + regulator-always-on; + regulator-boot-on; + }; + vdd_mmc1: fixedregulator-sd { compatible = "regulator-fixed"; pinctrl-names = "default"; @@ -211,6 +222,20 @@ vdd_sd_dv_alt: gpio-regulator-tps659411 { <3300000 0x1>; }; + vdd_sd_dv: gpio-regulator-TLV71033 { + compatible = "regulator-gpio"; + pinctrl-names = "default"; + pinctrl-0 = <&vdd_sd_dv_pins_default>; + regulator-name = "tlv71033"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + vin-supply = <&vsys_5v0>; + gpios = <&main_gpio0 118 GPIO_ACTIVE_HIGH>; + states = <1800000 0x0>, + <3300000 0x1>; + }; + transceiver1: can-phy1 { compatible = "ti,tcan1042"; #phy-cells = <0>; @@ -613,6 +638,12 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26) WKUP_GPIO0_9 */ >; }; + vdd_sd_dv_pins_default: vdd-sd-dv-default-pins { + pinctrl-single,pins = < + J721E_IOPAD(0x1dc, PIN_INPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */ + >; + }; + wkup_uart0_pins_default: wkup-uart0-default-pins { pinctrl-single,pins = < J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
Add device tree nodes for two power regulators on the J721E SK board. vsys_5v0: A fixed regulator representing the 5V supply output from the LM61460 and vdd_sd_dv: A GPIO-controlled TLV71033 regulator. J721E-SK schematics: https://www.ti.com/lit/zip/sprr438 Fixes: 1bfda92a3a36 ("arm64: dts: ti: Add support for J721E SK") Cc: stable@vger.kernel.org Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com> --- arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 31 ++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)