| Message ID | 20250409134128.2098195-3-y-abhilashchandra@ti.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fix dtbs_check warnings in CSI overlays | expand |
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote: > Update the vin-supply of the TLV71033 regulator from LM5141 (vsys_3v3) to > LM61460 (vsys_5v0) to match the schematics. Add a fixed regulator node for > the LM61460 5V supply to support this change. > > AM68-SK schematics: https://www.ti.com/lit/zip/sprr463 > Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board") > Cc: stable@vger.kernel.org > Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts > index 11522b36e0ce..5fa70a874d7b 100644 > --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts > @@ -44,6 +44,17 @@ vusb_main: regulator-vusb-main5v0 { > regulator-boot-on; > }; > > + vsys_5v0: regulator-vsys5v0 { > + /* Output of LM61460 */ > + compatible = "regulator-fixed"; > + regulator-name = "vsys_5v0"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <&vusb_main>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > vsys_3v3: regulator-vsys3v3 { > /* Output of LM5141 */ > compatible = "regulator-fixed"; > @@ -76,7 +87,7 @@ vdd_sd_dv: regulator-tlv71033 { > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > regulator-boot-on; > - vin-supply = <&vsys_3v3>; > + vin-supply = <&vsys_5v0>; Looking at schematic page -3 USB PD Controller is giving input to LM61460 , LM5141(3V3), and TPS62177. Could you please recheck this, vin-supply for 3v3 regulator Thanks Udit > gpios = <&main_gpio0 49 GPIO_ACTIVE_HIGH>; > states = <1800000 0x0>, > <3300000 0x1>;
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote: > Update the vin-supply of the TLV71033 regulator from LM5141 (vsys_3v3) to > LM61460 (vsys_5v0) to match the schematics. Add a fixed regulator node for > the LM61460 5V supply to support this change. > > AM68-SK schematics: https://www.ti.com/lit/zip/sprr463 > Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board") > Cc: stable@vger.kernel.org > Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts > index 11522b36e0ce..5fa70a874d7b 100644 > --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts > @@ -44,6 +44,17 @@ vusb_main: regulator-vusb-main5v0 { > regulator-boot-on; > }; > > + vsys_5v0: regulator-vsys5v0 { > + /* Output of LM61460 */ > + compatible = "regulator-fixed"; > + regulator-name = "vsys_5v0"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <&vusb_main>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > vsys_3v3: regulator-vsys3v3 { > /* Output of LM5141 */ > compatible = "regulator-fixed"; > @@ -76,7 +87,7 @@ vdd_sd_dv: regulator-tlv71033 { > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > regulator-boot-on; > - vin-supply = <&vsys_3v3>; > + vin-supply = <&vsys_5v0>; > gpios = <&main_gpio0 49 GPIO_ACTIVE_HIGH>; > states = <1800000 0x0>, > <3300000 0x1>; Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote: > Update the vin-supply of the TLV71033 regulator from LM5141 (vsys_3v3) to > LM61460 (vsys_5v0) to match the schematics. Add a fixed regulator node for > the LM61460 5V supply to support this change. > > AM68-SK schematics: https://www.ti.com/lit/zip/sprr463 > Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board") > Cc: stable@vger.kernel.org > Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts > index 11522b36e0ce..5fa70a874d7b 100644 > --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts > @@ -44,6 +44,17 @@ vusb_main: regulator-vusb-main5v0 { > regulator-boot-on; > }; > > + vsys_5v0: regulator-vsys5v0 { > + /* Output of LM61460 */ > + compatible = "regulator-fixed"; > + regulator-name = "vsys_5v0"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <&vusb_main>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > vsys_3v3: regulator-vsys3v3 { > /* Output of LM5141 */ > compatible = "regulator-fixed"; > @@ -76,7 +87,7 @@ vdd_sd_dv: regulator-tlv71033 { > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > regulator-boot-on; > - vin-supply = <&vsys_3v3>; > + vin-supply = <&vsys_5v0>; > gpios = <&main_gpio0 49 GPIO_ACTIVE_HIGH>; Please ignore previous comment , I realized you are changing parent for tlv71033 not for vsys_3v3. With that Reviewed-by: Udit Kumar <u-kumar1@ti.com> > states = <1800000 0x0>, > <3300000 0x1>;
diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts index 11522b36e0ce..5fa70a874d7b 100644 --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts @@ -44,6 +44,17 @@ vusb_main: regulator-vusb-main5v0 { regulator-boot-on; }; + vsys_5v0: regulator-vsys5v0 { + /* Output of LM61460 */ + compatible = "regulator-fixed"; + regulator-name = "vsys_5v0"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + vin-supply = <&vusb_main>; + regulator-always-on; + regulator-boot-on; + }; + vsys_3v3: regulator-vsys3v3 { /* Output of LM5141 */ compatible = "regulator-fixed"; @@ -76,7 +87,7 @@ vdd_sd_dv: regulator-tlv71033 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; regulator-boot-on; - vin-supply = <&vsys_3v3>; + vin-supply = <&vsys_5v0>; gpios = <&main_gpio0 49 GPIO_ACTIVE_HIGH>; states = <1800000 0x0>, <3300000 0x1>;
Update the vin-supply of the TLV71033 regulator from LM5141 (vsys_3v3) to LM61460 (vsys_5v0) to match the schematics. Add a fixed regulator node for the LM61460 5V supply to support this change. AM68-SK schematics: https://www.ti.com/lit/zip/sprr463 Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board") Cc: stable@vger.kernel.org Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com> --- arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)