From patchwork Wed Apr 16 06:06:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Zhu X-Patchwork-Id: 14053214 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0364C369B1 for ; Wed, 16 Apr 2025 06:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z/ZZpQ8LxIFPxxJvrZewL0fh5qESFxQt9iOTACQH02c=; b=uUOwhV/y2lCjhgan5veO/QdDVA 7a/UvWfMYtE2aSRCiuerKvnRTx6CmuvJ9K45T3Pm5P4528+S9eLdIGng00Y4b3Xqp1O2Z8bKaT36M Rixr5SS6kSiYjXJmRHBYLDou7iOlcFKyE6Jcl/COVCr2BznESOBKQ7qVkWbmTs7OBKV48S3byx03q 5peFK+teCuEg00de8OhNEDsyQMWr8ClIOs1fFZvrGo4E42ZU/lUuJwIZ7Woyl1a7eLUYB7d90QMQw 3PjuvUdfRJWTaWKr73Uzzpkouzc39HpShAWq9w0I+TB/t2Kqludumzf35Q10jeeq7yZof1jAy+s9v Ea4590mQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4w5M-00000008NwD-18PJ; Wed, 16 Apr 2025 06:17:24 +0000 Received: from mail-westeuropeazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c201::7] helo=AM0PR02CU008.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4vxi-00000008Mmb-2ZAX for linux-arm-kernel@lists.infradead.org; Wed, 16 Apr 2025 06:09:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZmufXeuJDWjTR820S2UG+K1SM875HDEu2h9J2iZlGUSyLQmdaCdWHdYDULivRqDodLCEIiuTXsBNvzqFNyFOH6gGQqRZTHbnv68oIB77qhjzhR9MN/wl+qRkOFVFKx2BW/R5CB1nfwVZ+F1nsVvp/eoEUa7wjXnCsUPPmUhZuOIXB54e1EtDQQaiGJwtVCKodJFt2hPRPeUPpxgpkawZd7qt+VLoel35etAxrur8YN9WCh6QICsoC+EI+hh2/pwcp87WhtDrWSOQ1+TAHxHRIHGt4CgoALGlgfQDJI66VgfCrjr9s/sxdKv/ORpz9NAggEV7SxxA5VRw9mntQyPt/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z/ZZpQ8LxIFPxxJvrZewL0fh5qESFxQt9iOTACQH02c=; b=C9Pp4Y/oCQCMFYDSYhbO+HDXMkf08q+BP9niwIffVGupGXEHJghSwjmLmWRQzGp4Duat7evWiuPKfE1o3fa+rwdNFYTF75bNsyIIlKN+YHX8wbPqYZA9Wui9cBJH2DTXCuQMOHtJ00d0WmBXMmxEJo92HR1jcXyFTQUISd6a1EBqDOcJDm2HM/yQhUOTs4oifTnXZhJDgRys1fe1tdGaTnPUoqUD6hl4LOxFPZAvvkJ5lffRGTTFwSSSiUjZOyszWoG9vXRpyF9OUd12Nqi9DDAhY1UwDpjFhev7wvPFpxkopEQypPY1f8sfg8fKSkxFfsEI89d+KF7NC7t6sl42Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z/ZZpQ8LxIFPxxJvrZewL0fh5qESFxQt9iOTACQH02c=; b=g1vYZaB4JUNCEj3LAWCSh7bHULhxd6vJ3P4kvyYlkL/oBNgRYUoQ0addAic2TG8BWr4Bu02RMbqPKmtsL6x/EB5u2WHtqchfx7aumADAvaNhvVHfR8pH8C0FNkIrqJIgQ7Uwz2hZyDgaeBTV39pSwRuQ3jKe58R9fpy4pN7NlGGpfNxKBLm4OVy92Hu1gyCZaBujEURIFrJNOxFKmBogBm7ZZmCvr5ZuWZ6yCdc2YI+JKR5S+PVYaM4yEexa4kotnzViFGtvBHofTC2jTdExal7Xxy+ope1cupHwEKxAzncXtdmCOUNWraqmAloo3USScFntDneV7an0usWT7hq6ag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by VI1PR04MB6992.eurprd04.prod.outlook.com (2603:10a6:803:139::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.33; Wed, 16 Apr 2025 06:09:25 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93%4]) with mapi id 15.20.8632.030; Wed, 16 Apr 2025 06:09:25 +0000 From: Richard Zhu To: frank.li@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu , Frank Li Subject: [PATCH v6 3/7] PCI: imx6: Toggle the cold reset for i.MX95 PCIe Date: Wed, 16 Apr 2025 14:06:44 +0800 Message-Id: <20250416060648.3628972-4-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250416060648.3628972-1-hongxing.zhu@nxp.com> References: <20250416060648.3628972-1-hongxing.zhu@nxp.com> X-ClientProxiedBy: SI2PR01CA0054.apcprd01.prod.exchangelabs.com (2603:1096:4:193::22) To AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8676:EE_|VI1PR04MB6992:EE_ X-MS-Office365-Filtering-Correlation-Id: 8361e8b5-9011-4e66-3df7-08dd7cad3d0d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|7416014|376014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: xAy1nKsb4V6hnC828RsmwecOdFI9WUCReEppPZ80opqw2YPIbFRlH4nFim85BhrFD43jO5tkGOYP3Im/CXclw8JfHnPo9/DozZ1KRbI3gdp64iE/F+08Cy1DhuDt4L4Pwzp+t4Snvl9gjCZIkL3K01psw7cxdMdV45iuLsatFb0aSSJwtYGiEL8VSbVEREmVl+PRDUFAfyck4pFjvT0RoQswqrWdOrnkYrRHAvODEQs+rAhTMdFdMnZ8tm8YqqOfrwaOvRJ44rFxAyXjAObfb6+3pqhIqXYVel7OUhdd+loMRSAaTFOyK0YFMnNQgn7UmIN0oY31TLxzJp1EgR+Fi6Zh9+qWa9RKU/cylKHUzOR1gFdcOzmxrK/GsmQ4KN/pbSMkf9zhpDZkhkVmCKpB3X3Vi694UdXKznwG5FN3vNAOKwp4N2jpmEQyiXHfCc9bLU9fN29qXuPVEhErzXirsrkMpegoTNW7xYT3PR/EisxLgSpISdv9MtFrSbJuUiN1SyTOghPkSbreYzD2th4lvUVN0yvAu7elVDhOynY/PeIzP2I1Z1oO/qZ/Ut/ZiDPtheIX0A6vOss2ih2AXs2yRVvoZ0kALA+lA0M2xceiY54zCWDzwDJdPqKIkdiGPrw9Y4IyVKilvtKV6ThgEEfEXlD5G2RgZXg42bx4xGnFVDykw9+sd5I4OUmMP+gd3LKGtvwtlut4am0STsEwUWnfeTD7CJpl6Zk2Jg3l0ydm4eOYN08CmTEsqE+7Ayp/8sjEAF9bnGbKm/dSc/kMpbEinAkFztPJV/14TJv+TuzZXhRlDOtkzLGgHiK1C0BZ8iEYu2Giiew7j7TeioowHaFTqOJc0O2X8si38y2UxQNpk7caCZwnljP6eVqQkyyXaPbSDm7tUzmFTk9COdlC6HFwnO9ryqZRjQn4HC75/WSFExwZpruP21PYhtJuuJnJ/14qIMPGoLM4cybudCjH2uZe4a8HkSOM5iTfyPTVX0ODRUWhciLZW7hWqaO8IMmEgf0xyFkAl3UoQ+9LvMCgEAiD1C448hmF+KN6rpfsXoayQzEmobJEWqL9mgQVhLg7ugba0F166AplKNZgSoz9Cmu6R73jarrVEoLUgHPEbprlByNob9K2i076VXF2eIWDkt62Pm9ibH7PUTOt49tR6Ay4q8/lquGXUHMLn+JMr2F7ZHWaSaOkuRv7m03FVr8VIcRM2LPWCVKa5D3IZrQ/Bjx6f4RXCKS06HVYOpG+eFly2C92HeLWxDrKaO5XHSsG3aXg7DR/wicsThjiC4XpptV+d9vUYXn1Qk4f3SGro6ygWzBubap+hzyEMnB1WwRaHjbrPHN1azsVV+VPoi6Pg3qOv4I3cleNsIc7dTLGZwfLLDPYF/oY8yliqIbhntoZmRVKGe4Zw1ZLA6jRMVfEm3YomZ9kvkqhUZysywj7SAO5yBKc8BVJLt4M7JpucSkIVjpjHurWcLhzUbBC9IdL8W0Ar8+Rql+GiZLtWge5Qkc8ghU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8676.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(7416014)(376014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TlFxKwoMrkoCUjqCQ/QGdgRKmgtb303f1WOv0VSpaIKWdVouwfVARQ6tIb6q4KYjqMvYwYzE1ZASLY1IhaEEzyA3x2vokLsNuY975WAGWgN+xb1tqYAcXOrXWgysPvNChfbcqcfPcaVA/GOraN4vxDALzPlzkY9pLrHn7aWcEzvE1BMVT8DzAI0obP9h3D3qT8vZ+SUnu/sytEnNOhHcqg9mcQO3f3Jy3BYh4qiBUq8p8A3PJfEr5+31LkFa5dj3iSThZv6bsWYwSZM9ejAc5eFBe890ieTvsH5B94LJ2PcQC86nU2bJCoryGhzsZj6Hy1PYITwgG+Tq39AhE8AO+LK4JP6eRPCvTeQ1raI91/IJr8sPP7btzlD+BQmOINv8rcR3WdZFpROjTcs/1Yxfw84Y59fXLIVOwOLQjGylNzcILdYk6USruQfF1ev8IjsDvbpqd8jRbLHBhI0SqvNdra9kkD/K9H0zV5tkljLgt3Do3hDazrS6kJ/icHlLXeNrEiHnrYLyoKfTFicYHtCZdmiE4YsHqcsZ/inBoWW74/zY3DHuDwwBj4B6PkurlA3GFgW6k41htb6GjGZYsncR4Ei2SF9igk/wZz3SGdgEFj81QzdfPCryO0pvUDg1YmVZ8oWtLU3x6TwtzYa1oVkHi/pWo4z2az/OjLKw0VPO41aryat4BBXFlMXQtaJDx7oQ1PypkP1H5Fn6+BJDy+AFGiI6WaHR8Zz9Pzuwh3845pqJgDcpujcjf9umDREuPl0WirqPmJ1U5+Mmm4o0RrRSoSTdBPq246hlg1/SX4Gr54aFVHFtcHXaYOG4vct/a4PIlHJueEd8/x66BI9T4UmMQEFoqAo/91AU2DuMQf/fVX95BFpBsc3MDRooT5nBvIIF7kQAaYIgzfrTumP5e/XAdpDDqZVTDg/PMBTeQPICHOZIJGjsnYzU/lHMBhPw8llpUpQ1hieWPwh+GjS/Tb7wDcUQt8oSZY2hwYBmPg2FZcvd0H6GI/O9eX/5sqRZtv7dzjCG64BfCk4x+JnIUizGVXcJuzsr5DHUC+zsWIfOuvT9MvaCNGA953dwpB7E6fZrEWjxnvEw6aB7yJmra0dn73rXx4FFPIAXL70zF2xdv6tFD2Yg1bm8wlrZMP44TUgo8bktSQ5DbD+aj1kJqGsP6VnlhKZuBQ/SmjfTR90unmZHDersCnptEXHGOD9SyF9lWo5ycStf2E8mo8iR0mzupVSU+fjXgokjcIGyODlWmjCzrZTjF3oTvs8OtajpcVgIA5bah/uH/Gc+VNwPxKXdAVTzqQOYjZ3b+IQBHXBDBYAZ7tMh/Vr+r7vCwo3syocAGKQC6rs3QSbj9YgFXtb1Nb7qmt0MHZlwKGyW/RT8+qRDyIq835Q4BLD93zVKqA91+Dmu4BhVeCEaAo3muU/iYCncZG8Jv5wBOhaX/q1eQqX6aHfnHqMv+79094lJRmdQ3CmPCXvR/U7kQ+6telI8BwIVa2Y+msSnRknsQ1Ld7KJsGBkzXnj2eI3GdDIRTnpker51Pzk1iNqSkyqfKeMxgapJPbgnmSKQi0zqtmGP8Ww6CEx+XGArn50QejD5XZSD X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8361e8b5-9011-4e66-3df7-08dd7cad3d0d X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2025 06:09:25.3743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vULDA/THOAbOdjKcU4bnu8s0bd002zIFzoR7N7uNeallPU/yPIxkqpu4JVvQOY/qyq1h8lVXdTxmMSaEVktIrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6992 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250415_230930_651676_CF8DC302 X-CRM114-Status: GOOD ( 14.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add a cold reset toggle for i.MX95 PCIe to align PHY's power-up sequence. Signed-off-by: Richard Zhu Reviewed-by: Manivannan Sadhasivam Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 42 +++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index c5871c3d4194..7c60b712480a 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -71,6 +71,9 @@ #define IMX95_SID_MASK GENMASK(5, 0) #define IMX95_MAX_LUT 32 +#define IMX95_PCIE_RST_CTRL 0x3010 +#define IMX95_PCIE_COLD_RST BIT(0) + #define to_imx_pcie(x) dev_get_drvdata((x)->dev) enum imx_pcie_variants { @@ -773,6 +776,43 @@ static int imx7d_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) return 0; } +static int imx95_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) +{ + u32 val; + + if (assert) { + /* + * From i.MX95 PCIe PHY perspective, the COLD reset toggle + * should be complete after power-up by the following sequence. + * > 10us(at power-up) + * > 10ns(warm reset) + * |<------------>| + * ______________ + * phy_reset ____/ \________________ + * ____________ + * ref_clk_en_______________________/ + * Toggle COLD reset aligned with this sequence for i.MX95 PCIe. + */ + regmap_set_bits(imx_pcie->iomuxc_gpr, IMX95_PCIE_RST_CTRL, + IMX95_PCIE_COLD_RST); + /* + * Make sure the write to IMX95_PCIE_RST_CTRL is flushed to the + * hardware by doing a read. Otherwise, there is no guarantee + * that the write has reached the hardware before udelay(). + */ + regmap_read_bypassed(imx_pcie->iomuxc_gpr, IMX95_PCIE_RST_CTRL, + &val); + udelay(15); + regmap_clear_bits(imx_pcie->iomuxc_gpr, IMX95_PCIE_RST_CTRL, + IMX95_PCIE_COLD_RST); + regmap_read_bypassed(imx_pcie->iomuxc_gpr, IMX95_PCIE_RST_CTRL, + &val); + udelay(10); + } + + return 0; +} + static void imx_pcie_assert_core_reset(struct imx_pcie *imx_pcie) { reset_control_assert(imx_pcie->pciephy_reset); @@ -1739,6 +1779,7 @@ static const struct imx_pcie_drvdata drvdata[] = { .ltssm_mask = IMX95_PCIE_LTSSM_EN, .mode_off[0] = IMX95_PE0_GEN_CTRL_1, .mode_mask[0] = IMX95_PCIE_DEVICE_TYPE, + .core_reset = imx95_pcie_core_reset, .init_phy = imx95_pcie_init_phy, }, [IMX8MQ_EP] = { @@ -1792,6 +1833,7 @@ static const struct imx_pcie_drvdata drvdata[] = { .mode_off[0] = IMX95_PE0_GEN_CTRL_1, .mode_mask[0] = IMX95_PCIE_DEVICE_TYPE, .init_phy = imx95_pcie_init_phy, + .core_reset = imx95_pcie_core_reset, .epc_features = &imx95_pcie_epc_features, .mode = DW_PCIE_EP_TYPE, },