From patchwork Tue Jun 18 15:20:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 2742921 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 53613C0AB1 for ; Tue, 18 Jun 2013 15:22:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 371792047C for ; Tue, 18 Jun 2013 15:22:18 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2F6B2046B for ; Tue, 18 Jun 2013 15:22:16 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Uoxiu-0002qd-Hk; Tue, 18 Jun 2013 15:21:32 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Uoxio-0003Aj-B3; Tue, 18 Jun 2013 15:21:26 +0000 Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Uoxic-00038Z-96 for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2013 15:21:15 +0000 Received: by mail-pa0-f51.google.com with SMTP id lf11so4102791pab.38 for ; Tue, 18 Jun 2013 08:20:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :in-reply-to:references:x-gm-message-state; bh=Xi96dC6u4rQ18nCcOkGnHbid6DZyaCJPjnZ9pN1aFKI=; b=fooPk99XYdo16/TOTrKB8Uj6t+dNFuRF6qcs+Veu7grEsEX3U/+Ruy9bUZZBB8mogs dyKtfVJvWVsmGshR3KiMb0lIf+HJTNHT7JkUT5Ga1JMqfkwWlF7bej/5QHNSeYlzSO+x m5BW2XtTtmbcBWM9Opqqy6RwOEo3lTct3FvB964/swAe3C3cklSGoaHZOVueVGOUo8en HX1xA84RAzHrh68E302ydJviuEdEjucrMaB5iGw3OEDRhnTJoIUb1J4mGVlz6w8qEgZY /wJJ9CnBim9AdcYnwSRy1R7mRf6dKYBRNV2KBs/h0MbIQ1qzpGKxp5qdPHLIpLAHytcs Va2A== X-Received: by 10.68.203.161 with SMTP id kr1mr17509412pbc.192.1371568852830; Tue, 18 Jun 2013 08:20:52 -0700 (PDT) Received: from localhost ([122.167.240.191]) by mx.google.com with ESMTPSA id wi6sm18701876pbc.22.2013.06.18.08.20.49 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 18 Jun 2013 08:20:52 -0700 (PDT) From: Viresh Kumar To: wim@iguana.be Subject: [PATCH V3 01/14] watchdog/mpcore_wdt: Mark it as BROKEN Date: Tue, 18 Jun 2013 20:50:25 +0530 Message-Id: <22d22fe6eea294c5132e47b8901e094d60b0e99d.1371535242.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 1.7.12.rc2.18.g61b472e In-Reply-To: References: In-Reply-To: References: X-Gm-Message-State: ALoCoQnrx9cET5YPb70SyjjHs9VqL8IwSuEs2PwvODQi2A1TkS76hbYXs9IhXaJ45XoJtc5Be62w X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130618_112114_447605_722BE5BB X-CRM114-Status: GOOD ( 12.21 ) X-Spam-Score: -1.9 (-) Cc: marc.zyngier@arm.com, Viresh Kumar , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This driver was broken since ever. - Interrupt request doesn't use the right API: The TWD watchdog uses a per-cpu interrupt (usually interrupt #30), and the GIC configuration should flag it as such. With this setup, request_irq() should fail, and the right API is request_percpu_irq(), together with enable_percpu_irq()/disable_percpu_irq(). - Nothing ensures the userspace ioctl() will end-up kicking the watchdog on the right CPU. Was last discussed here: http://lists.infradead.org/pipermail/linux-arm-kernel/2012-April/095960.html Lets mark it broken until somebody with this hardware gets up and fixes it. Suggested-by: Marc Zyngier Signed-off-by: Viresh Kumar --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 9d03af1..c7dabe9 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -223,7 +223,7 @@ config DW_WATCHDOG config MPCORE_WATCHDOG tristate "MPcore watchdog" - depends on HAVE_ARM_TWD + depends on HAVE_ARM_TWD && BROKEN help Watchdog timer embedded into the MPcore system.