From patchwork Wed Jul 8 18:04:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= X-Patchwork-Id: 11652227 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A314513B1 for ; Wed, 8 Jul 2020 18:26:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CBF9206F6 for ; Wed, 8 Jul 2020 18:26:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FOfLJZjf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=rere.qmqm.pl header.i=@rere.qmqm.pl header.b="Dy2H4kyZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CBF9206F6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rere.qmqm.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:MIME-Version:Subject:From:References:In-Reply-To: Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A3BMFnkCrjF2qDs0A2OwupCMPJEVMHhbu+YA1+v6NNM=; b=FOfLJZjfpTHm6Ut6MBvu8E2uB CRw0bOarN6N1Whbzp3FvlDS1OqF6b+E/0RtZzRg3a8/hXt4S1MGxKOJWcqKNyxSF0EvXH/fqZTpJU Bhr8kqn9MUdOuWH3sYBz2/rYrcvI0e3DHXSPHVA0xf5F7X/N1cWjZnWxWWRQYK/yZEnNho/pEgCq+ vLWrhPhIrIbRtgjdnp59SyRI7/FSAxtZOWEczotmw2CSNCEqw2s0ZrbNpys6jk2KkCOwjErEfPC6P lRLG6OYJix2df+ZXRt2By35MndOnXr1RndNhQreFGklBhHq0LyLZagQUKYKfbi64zFKD+fSioKv3i 3dDiEJ2qA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtEks-0007xb-P8; Wed, 08 Jul 2020 18:25:14 +0000 Received: from rere.qmqm.pl ([91.227.64.183]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtEQf-0006An-VM for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 18:04:40 +0000 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4B26d60W3NzMK; Wed, 8 Jul 2020 20:04:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1594231450; bh=r3FexnWOGPLoKtGxgqbQb3w5FegJpG2pFaJligFub9Q=; h=Date:In-Reply-To:References:From:Subject:To:Cc:From; b=Dy2H4kyZY48Pt9ZFLiCLIJdFhup5pYVlRW+XQV6z2hbmGRqKUKENRqLzyE0FQ/KAs eI02tfwbOv8vq7EbqdHy7+NiMiUhwW65EhHNSOZ3f0MxfYnMe+OvfAEH3dSKzPn8ts GrnMw4+l7qGZZSvkHO9tyOC+hw4syiE4j/qxVWZnkojFHew1fCjYowsXsppzHGVr9E 0aDaRLZJR9PBbohHnMD68VGmir/B/XHJDKFwv1MfTFYx0heNVvNG25JaxjPtaHjEyv Qwh366QO+esPNguUjtvLAM5S8oO294/OxUfSSBYa9foSPtg2ZtrI5ybFrAeYMIhjiB ZLx+PPDvyx8yQ== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at mail Date: Wed, 08 Jul 2020 20:04:09 +0200 Message-Id: <248e7089f7fbb3727e83a1dfb43820d96a69e8c2.1594231056.git.mirq-linux@rere.qmqm.pl> In-Reply-To: References: From: =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= Subject: [PATCH RESEND 2/3] usb: gadget: udc: atmel: fix uninitialized read in debug printk MIME-Version: 1.0 To: Alexandre Belloni , Cristian Birsan , Felipe Balbi , Greg Kroah-Hartman , Ludovic Desroches , Nicolas Ferre , Songjun Wu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_140422_506733_A506F3D9 X-CRM114-Status: GOOD ( 11.26 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixed commit moved the assignment of 'req', but did not update a reference in the DBG() call. Use the argument as it was renamed. Fixes: 5fb694f96e7c ("usb: gadget: udc: atmel: fix possible oops when unloading module") Signed-off-by: Michał Mirosław Acked-by: Alexandre Belloni Acked-by: Cristian Birsan --- drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 9153e220848d..9342a3d24963 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -865,7 +865,7 @@ static int usba_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req) u32 status; DBG(DBG_GADGET | DBG_QUEUE, "ep_dequeue: %s, req %p\n", - ep->ep.name, req); + ep->ep.name, _req); spin_lock_irqsave(&udc->lock, flags);