From patchwork Mon Sep 30 13:07:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 2964611 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B0B1E9F288 for ; Mon, 30 Sep 2013 13:08:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1FD4520204 for ; Mon, 30 Sep 2013 13:08:42 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6249B201FA for ; Mon, 30 Sep 2013 13:08:37 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VQdD7-00044x-G3; Mon, 30 Sep 2013 13:08:25 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VQdD5-0002am-3T; Mon, 30 Sep 2013 13:08:23 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VQdD1-0002Zw-Ka for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2013 13:08:21 +0000 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTX00M8LWH5SCG0@mailout3.samsung.com> for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2013 22:07:57 +0900 (KST) X-AuditID: cbfee61b-b7f776d0000016c8-cc-524977ad72f1 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 06.FC.05832.DA779425; Mon, 30 Sep 2013 22:07:57 +0900 (KST) Received: from amdc1032.localnet ([106.116.147.136]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MTX00GEQWH8P480@mmp2.samsung.com>; Mon, 30 Sep 2013 22:07:57 +0900 (KST) From: Bartlomiej Zolnierkiewicz To: Simon Horman Subject: [PATCH] ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag Date: Mon, 30 Sep 2013 15:07:47 +0200 Message-id: <26068642.Hn7T63a6ac@amdc1032> User-Agent: KMail/4.8.4 (Linux/3.2.0-52-generic-pae; KDE/4.8.5; i686; ; ) MIME-version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsVy+t9jQd215Z5BBjM+yFg0b/3KaHG26Q27 xabH11gtLu+aw2Yx588UZosHq9+yObB57Jx1l91j85J6j74tqxg95vz8xuLxeZNcAGsUl01K ak5mWWqRvl0CV8bxNdNYCk5yVOybfIy9gXEZexcjJ4eEgInEnCsnmCFsMYkL99azdTFycQgJ TGeU+LzgESNIQkighUmi46kXiM0mYCUxsX0VWFxEQFXi95FvLCANzAJbGCVmN3SCTRIWCJHY 8aMdrIgFqOjn2S1gcV4BLYn2Q5vBNosKeEp8mrQUKi4o8WPyPRYQm1lAXmLf/qmsELaWxPqd x5kmMPLNQlI2C0nZLCRlCxiZVzGKphYkFxQnpeca6RUn5haX5qXrJefnbmIEh+oz6R2Mqxos DjEKcDAq8fBaLPUIEmJNLCuuzD3EKMHBrCTCK17mGSTEm5JYWZValB9fVJqTWnyIUZqDRUmc 92CrdaCQQHpiSWp2ampBahFMlomDU6qBcfWWxJ3fk5//Oj/hB/9PWeuMnKlWJYpt8X+dln4I 3iBX8fzbUZvD1ip8m7deY295e/uE3lJhDg6BtaGvXA8y2b65oPYwXHhxdrDn/fyk2NtS604p mHKb8mWJMHLPOqj74dekfq5nymxZ/zMvbTnN0b3laKWQT9+eKzvvHPFPD9i52zu1xOjBDiWW 4oxEQy3mouJEADewPzVRAgAA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130930_090819_885863_2378E95F X-CRM114-Status: GOOD ( 10.72 ) X-Spam-Score: -7.5 (-------) Cc: Kyungmin Park , Magnus Damm , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP __initdata tag should be placed between the variable name and equal sign for the variable to be placed in the intended .init.data section. In this particular case __initdata is incorrect as ape6evm_keys_pdata can be used as a platform data for gpio-keys driver which can be compiled as module. Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- arch/arm/mach-shmobile/board-ape6evm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644 --- a/arch/arm/mach-shmobile/board-ape6evm.c +++ b/arch/arm/mach-shmobile/board-ape6evm.c @@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = { GPIO_KEY(KEY_VOLUMEDOWN, 329, "S21"), }; -static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = { +static struct gpio_keys_platform_data ape6evm_keys_pdata = { .buttons = gpio_buttons, .nbuttons = ARRAY_SIZE(gpio_buttons), };