From patchwork Mon Mar 24 07:12:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 14026879 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C41CEC36002 for ; Mon, 24 Mar 2025 07:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cb6ZekWLkVePTuMzLCdqRm3yrgquLep1rTqCU69e+sA=; b=Rx8io3q+calHE1HVhrCHxsF441 wHPzvYNTf9GJTGVRStMUcxqPj+e3HMd8g7Fm3w/JxuBw+H2Qk473EHiTStbLwLyEZIchbVbouHaL6 tpdRnvFwIwOxpcP4fSXH31U5XcEHVHH99kXnwTHVpSj0Xu35bRrwXYll+NfPGFpCH/LM0FwBj6o13 jgLM5WFdDR0ZVzqtnZVcFRPJPRjJteJ/b0U0gsO0LT26l0PYUihk1RLPVehnPTf8CXnd9L+VNE/yi RQ1zxgHdOXMAS+LdiZ+o6VEIszDEFBa0IYd3sv43d2uK1H5ncLV1etMARZP5y56ocDy8vchgn110w revUVobg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1twc9r-00000002RPC-0FTA; Mon, 24 Mar 2025 07:23:39 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1twbzX-00000002Prk-1Scn for linux-arm-kernel@lists.infradead.org; Mon, 24 Mar 2025 07:13:00 +0000 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-5499c8fa0f3so4805817e87.2 for ; Mon, 24 Mar 2025 00:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742800377; x=1743405177; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Cb6ZekWLkVePTuMzLCdqRm3yrgquLep1rTqCU69e+sA=; b=IE3cOH4jYv5zYjBOi/bFsVEbRBche5EE5Dr16p7PvIcvqIvN7TL1HS+OIUbzPQI3jU oI29wUrufSWxuchiXWEkWB572y4a3E614nNp6N6qnzeHFvEH5momyycHXqyD7MqdlxMy F/mN+ncczFGrh/sz8EMMqRD1Kl2jj4EwCGUbE8q90E1HiaBXxg2Ci6Wu4mb2NiY1ScZG m+u2z3mA32Zvi7FHPqV09uYsEJJknRxEqXqxZtRFJYoaWDtKqgz4tkONfQIC+OEJ3Kmm B27jefR0ACBwn+Jap94xRiLYjrMDSOsxkaQgU9J3RU0bSLrkQIts+POI9G3J177cThJ7 YeCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742800377; x=1743405177; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Cb6ZekWLkVePTuMzLCdqRm3yrgquLep1rTqCU69e+sA=; b=qd5KH7qAUSbX/U9m9UFjwNpdeW9UAeOn9Y7BKjoG8ZQBE/rJD7uGjChXsM11+5btZk 5+QMn1i0p2QpWTNCMVlJYxQxvK2myi23xVCwC8bc1QzJtGQoffAjLW4wgXRP91QuGIi4 NOrxIyuKoEs1VJosC9nc2JwRroo/wd4xZhRhjqctZtYDNgW872vHZUbQU1t3jcJi1Oca nJyZitwkoSCe0MhvvvRWfRJZYdetsd3XdE3KezNpXbgDpFLN0EbgWEPBQmGm9lNzWezn YwkRy0cdPeZLKrgASoSk768ri7CbRVhpSlnrBVyHCHS866z/d6PHiCIDKNX557pb6Zwe mSrA== X-Forwarded-Encrypted: i=1; AJvYcCUNFaZ55kWUmkXiJXHFOA65znpUrK1Yfgyi3YRRXYmjFsBA3P5vESFIpnEbD5Z7rf6PL3agD9H+aP0CSG3J7baK@lists.infradead.org X-Gm-Message-State: AOJu0YzfT/ArCWxHCa9XFzjc6NQVBSib5japTYNzlhEz360veNomShGT 2rf3LSWN56DuBQ3JtGp88ISywST7KoRI9i6BR/vWghJkEQJemKyN X-Gm-Gg: ASbGnctrcFtN6YTOHtED4Y5JPYuGHm/u4MmdBbbN0RTuMEXNNWyFGbz9fT2VmJb6nZi 71Qg/8xPtSGMxKhXnjkpP4TxfEzPNRCweftPYtp5iND2EQS9vsUEDAs/bOqjWG7sk0dt0dleqt8 364pXIPRmX5fU4hztvdfJRw0IPz63S1CJHXegWzV5Ell2q6byBZA6/P6kSSA2Oj8OC2AFiFAd9B UIE6TXfysefFp3H8cGMVIZoc7MKbRIW3a7MEnchvuOZF2kJG2luhaQm5b014UdpnB4LHHtev5oN PHuTDafxRcNWt1ERRV5fdnNXpMMqEuhpi97woUMy+dWBIo+kquE= X-Google-Smtp-Source: AGHT+IHmmYJxZaoxJegOFs7H2qFgMQysAz3M56PHCG4I22aUs9ljmNowu7LQ3Ype2zutd04sqwhXUw== X-Received: by 2002:a05:6512:10d4:b0:545:1082:91a1 with SMTP id 2adb3069b0e04-54ad64807e9mr3497478e87.7.1742800377109; Mon, 24 Mar 2025 00:12:57 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54ad647b468sm1032949e87.59.2025.03.24.00.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 00:12:55 -0700 (PDT) Date: Mon, 24 Mar 2025 09:12:50 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Matti Vaittinen , Lad Prabhakar , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Nuno Sa , David Lechner , Javier Carrasco , Guillaume Stols , Olivier Moysan , Dumitru Ceclan , Trevor Gamblin , Matteo Martelli , Alisa-Dariana Roman , AngeloGioacchino Del Regno , =?iso-8859-1?q?Jo=E3o_Paulo_Gon=E7alves?= , Ramona Alexandra Nechita , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH v10 2/8] property: Add functions to iterate named child Message-ID: <2767173b7b18e974c0bac244688214bd3863ff06.1742560649.git.mazziesaccount@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250324_001259_390413_C3B77949 X-CRM114-Status: GOOD ( 20.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There are a few use-cases where child nodes with a specific name need to be parsed. Code like: fwnode_for_each_child_node() if (fwnode_name_eq()) ... can be found from a various drivers/subsystems. Adding a macro for this can simplify things a bit. In a few cases the data from the found nodes is later added to an array, which is allocated based on the number of found nodes. One example of such use is the IIO subsystem's ADC channel nodes, where the relevant nodes are named as channel[@N]. Add helpers for iterating and counting device's sub-nodes with certain name instead of open-coding this in every user. Suggested-by: Jonathan Cameron Signed-off-by: Matti Vaittinen Reviewed-by: Andy Shevchenko Reviewed-by: Marcelo Schmitt --- Revision history: v9 => - No changes v8 => v9: - Drop the fwnode_for_each_available_named_child_node() as suggested by Sakari during v8 review: https://lore.kernel.org/all/Z9mQPJwnKAkPHriT@kekkonen.localdomain/ v7 => v8: - Fix the example in fwnode_get_named_child_node_count() documentation to use the fwnode_get_named_child_node_count() and not the device_get_named_child_node_count() - Fix the rest of the new macro's indentiations v6 => v7: - Improve kerneldoc - Inline device_get_named_child_node_count() and change it to call fwnode_get_named_child_node_count() inside - Fix indentiation of the new macros v5 => v6: - Add helpers to also iterate through the nodes. v4 => v5: - Use given name instead of string 'channel' when counting the nodes - Add also fwnode_get_child_node_count_named() as suggested by Rob. v3 => v4: - New patch as suggested by Jonathan, see discussion in: https://lore.kernel.org/lkml/20250223161338.5c896280@jic23-huawei/ --- drivers/base/property.c | 27 +++++++++++++++++++++++++++ include/linux/property.h | 20 ++++++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/drivers/base/property.c b/drivers/base/property.c index c1392743df9c..f42f32ff45fc 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -945,6 +945,33 @@ unsigned int device_get_child_node_count(const struct device *dev) } EXPORT_SYMBOL_GPL(device_get_child_node_count); +/** + * fwnode_get_named_child_node_count - number of child nodes with given name + * @fwnode: Node which child nodes are counted. + * @name: String to match child node name against. + * + * Scan child nodes and count all the nodes with a specific name. Potential + * 'number' -ending after the 'at sign' for scanned names is ignored. + * E.g.:: + * fwnode_get_named_child_node_count(fwnode, "channel"); + * would match all the nodes:: + * channel { }, channel@0 {}, channel@0xabba {}... + * + * Return: the number of child nodes with a matching name for a given device. + */ +unsigned int fwnode_get_named_child_node_count(const struct fwnode_handle *fwnode, + const char *name) +{ + struct fwnode_handle *child; + unsigned int count = 0; + + fwnode_for_each_named_child_node(fwnode, child, name) + count++; + + return count; +} +EXPORT_SYMBOL_GPL(fwnode_get_named_child_node_count); + bool device_dma_supported(const struct device *dev) { return fwnode_call_bool_op(dev_fwnode(dev), device_dma_supported); diff --git a/include/linux/property.h b/include/linux/property.h index e214ecd241eb..3e83babac0b0 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -167,6 +167,10 @@ struct fwnode_handle *fwnode_get_next_available_child_node( for (child = fwnode_get_next_child_node(fwnode, NULL); child; \ child = fwnode_get_next_child_node(fwnode, child)) +#define fwnode_for_each_named_child_node(fwnode, child, name) \ + fwnode_for_each_child_node(fwnode, child) \ + if (!fwnode_name_eq(child, name)) { } else + #define fwnode_for_each_available_child_node(fwnode, child) \ for (child = fwnode_get_next_available_child_node(fwnode, NULL); child;\ child = fwnode_get_next_available_child_node(fwnode, child)) @@ -178,11 +182,19 @@ struct fwnode_handle *device_get_next_child_node(const struct device *dev, for (child = device_get_next_child_node(dev, NULL); child; \ child = device_get_next_child_node(dev, child)) +#define device_for_each_named_child_node(dev, child, name) \ + device_for_each_child_node(dev, child) \ + if (!fwnode_name_eq(child, name)) { } else + #define device_for_each_child_node_scoped(dev, child) \ for (struct fwnode_handle *child __free(fwnode_handle) = \ device_get_next_child_node(dev, NULL); \ child; child = device_get_next_child_node(dev, child)) +#define device_for_each_named_child_node_scoped(dev, child, name) \ + device_for_each_child_node_scoped(dev, child) \ + if (!fwnode_name_eq(child, name)) { } else + struct fwnode_handle *fwnode_get_named_child_node(const struct fwnode_handle *fwnode, const char *childname); struct fwnode_handle *device_get_named_child_node(const struct device *dev, @@ -210,6 +222,14 @@ int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const char *name); unsigned int device_get_child_node_count(const struct device *dev); +unsigned int fwnode_get_named_child_node_count(const struct fwnode_handle *fwnode, + const char *name); +static inline unsigned int device_get_named_child_node_count(const struct device *dev, + const char *name) +{ + return fwnode_get_named_child_node_count(dev_fwnode(dev), name); +} + static inline int device_property_read_u8(const struct device *dev, const char *propname, u8 *val) {