From patchwork Thu Jun 8 15:36:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Christian Lamparter X-Patchwork-Id: 13272467 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C6F3C7EE29 for ; Thu, 8 Jun 2023 15:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=dWsGuUy58TW6qjyiNUkCZ0tbhlO/TVsBVwAxLI8Wj/I=; b=KjRm+yP8FSQhgm aM7MPBNHJLszAx/c5X02AOH4R9cr6c9PA+oQNrWmMNmPCh0UHoxfMW83K2FZm3w/Iok/nh4QS90WS VRluXwteiQLqZVPOjD9Z5ijeLeEijW98Pt3SKEZknlAxNnfA5NVsTvq0OFNcMrRigyVpBEV30lfvM YbBukjKs3uGGowSFTCJt8fke6Fuk9mT4fX9EpmY2o2tj3/CRjjcHoAMHQJjN9zfAMMHcaZ8kZ97Gn u9iSI8nAOZdShzmnZnIevyJfEObguSViR9jOiBMXCA9FEr2+jho5cIXbME4FpYp5kZ4ocuP+rzITO 5pfayQRPb4A0uUIx5sNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7Hgr-009lIo-2l; Thu, 08 Jun 2023 15:36:45 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7Hgm-009lFc-33 for linux-arm-kernel@lists.infradead.org; Thu, 08 Jun 2023 15:36:42 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-977d02931d1so120191366b.0 for ; Thu, 08 Jun 2023 08:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686238591; x=1688830591; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Khaj7ZsYDEb4kfH4WHb643/yEvEjTfxC1Xvcx9U6sS0=; b=qbBegI3jgogGYY+GyfxmnzcqY4a/1gKT44xnG5o1xupHDBVu5q3F2Oe0pzWRyGuMnu ZJl+Sj2+TsDTHOBuVSWCKdGTDU28C6R5ri1EQuMMb3+aSVJULuOVCVoLiJX2jRMEShK7 VCDUOUvq7gtvDvZ11GdDOe8PxsE87//QrQMApHQdxj1e0ciC8T3XmjDaoMW4ernoXps+ ViAQJdrZhEn9t/+e9mtGD0zFBghP0cbyJxM28cFeHWBxvTYumRachcEa/xqQNvlrIOjJ 6yebma5B71QQlq0xncaEbem4loavt/9VYHKR5vun9ifuMd2ojEHIzE5uccUPTO2r7LJO 9Xnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686238591; x=1688830591; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Khaj7ZsYDEb4kfH4WHb643/yEvEjTfxC1Xvcx9U6sS0=; b=XIyfpGTImpwsVv/INMubvLWEw2sDlz+EzrKlH/prZpReVlqe04JTys1jCHwYiYnx/r S9QhXdFmCT493nCBRFtvoYtPBdJwFCLd5SWvqnzPdEDwSk/V/7yEGMtGAscO6x2/CFCN MxID9o5Ob8OFlGJxCiWafUtr9+ODZE5Prk939jDXPLWCmkP34YsVutR3xh56qyYjdYvu 1qZ7uDyjbtk2UdJskQv2VrkrUe6m662jYnw5KwDgwwNuDZWKMSJP89zsyW677xhUAsfU vNqugYmpd35WG9dsQlPsjGNxKTS90leS9oKLycJ3fgF+3r7u2vYwO7S8+H91iQEFsqPd /TBQ== X-Gm-Message-State: AC+VfDzczM3+YVAcMmquYKP7b1lwArXHUMk0c7Evj17j0So5Wo3jkLRx tg/ouyJ7l0FEfB91M4KsoyW7BP/uT5g= X-Google-Smtp-Source: ACHHUZ6SIu1qXtMUYeYyzJWO7krCwyeShSZzuIFnFlMWpamN+/J5cTUAtIKs938wqTKiF7uF392Kxg== X-Received: by 2002:a17:907:7291:b0:94e:e5fe:b54f with SMTP id dt17-20020a170907729100b0094ee5feb54fmr132299ejc.23.1686238591094; Thu, 08 Jun 2023 08:36:31 -0700 (PDT) Received: from shift.daheim (pd9e29cc7.dip0.t-ipconnect.de. [217.226.156.199]) by smtp.gmail.com with ESMTPSA id j14-20020a1709066dce00b00977cd6d2127sm857523ejt.6.2023.06.08.08.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 08:36:30 -0700 (PDT) Received: from chuck by shift.daheim with local (Exim 4.96) (envelope-from ) id 1q7Hgb-004atj-25; Thu, 08 Jun 2023 17:36:29 +0200 From: Christian Lamparter To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Cc: Florian Fainelli , Hauke Mehrtens , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: [PATCH v2 1/3] ARM: dts: BCM5301X: MR26: MR32: remove bogus nand-ecc-algo property Date: Thu, 8 Jun 2023 17:36:27 +0200 Message-Id: <2c4d00dd40124c2ddc0b139cbce7531b108f9052.1686238550.git.chunkeey@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_083640_987052_8580D7CE X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org | bcm53015-meraki-mr26.dtb: nand-controller@18028000: | nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs'] | From schema: Documentation/[...]/nand-controller.yaml | bcm53016-meraki-mr32.dtb: nand-controller@18028000: | nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs'] | From schema: Documentation/[...]/nand-controller.yaml original ECC values for these old Merakis are sadly not provided by the vendor. It looks like Meraki just stuck with what Broadcom's SDK was doing... which left this up to the proprietary nand driver. Note: The invalid setting was and is handled by brcmnand. It falls back to "bch" in brcmnand_setup_dev() when ecc.algo is set to NAND_ECC_ALGO_UNKNOWN (since "hw" is not in the list above). A correct nand-ecc-algo = "bch"; is already specified in the included "bcm5301x-nand-cs0-bch8.dtsi". So this line can be dropped. Reported-by: Rafał Miłecki (per Mail) Fixes: 935327a73553 ("ARM: dts: BCM5301X: Add DT for Meraki MR26") Fixes: ec88a9c344d9 ("ARM: BCM5301X: Add DT for Meraki MR32") Signed-off-by: Christian Lamparter --- v1 -> v2: - add dts and BCM5301X tag (Rafael) - Rebased on top of stblinux devicetree/next - investigated device NAND OOB for clues what is used. => also checked out brcmnand.c --- arch/arm/boot/dts/bcm53015-meraki-mr26.dts | 2 -- arch/arm/boot/dts/bcm53016-meraki-mr32.dts | 2 -- 2 files changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/bcm53015-meraki-mr26.dts b/arch/arm/boot/dts/bcm53015-meraki-mr26.dts index 071f2cb97251..83d1b6e0b0d5 100644 --- a/arch/arm/boot/dts/bcm53015-meraki-mr26.dts +++ b/arch/arm/boot/dts/bcm53015-meraki-mr26.dts @@ -72,8 +72,6 @@ &gmac3 { }; &nandcs { - nand-ecc-algo = "hw"; - partitions { compatible = "fixed-partitions"; #address-cells = <0x1>; diff --git a/arch/arm/boot/dts/bcm53016-meraki-mr32.dts b/arch/arm/boot/dts/bcm53016-meraki-mr32.dts index 46c2c93b01d8..16c650595cb9 100644 --- a/arch/arm/boot/dts/bcm53016-meraki-mr32.dts +++ b/arch/arm/boot/dts/bcm53016-meraki-mr32.dts @@ -125,8 +125,6 @@ &pwm { }; &nandcs { - nand-ecc-algo = "hw"; - partitions { /* * The partition autodetection does not work for this device.