From patchwork Tue Jul 10 11:13:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 10516847 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 507A96032A for ; Tue, 10 Jul 2018 11:15:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B98228D47 for ; Tue, 10 Jul 2018 11:15:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F68128D50; Tue, 10 Jul 2018 11:15:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CFC1D28D47 for ; Tue, 10 Jul 2018 11:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FoNN0p4oD9/zIZUv5kjqRjA4eCkIToz13H7T7qCObIk=; b=IjXJZxqAQpepPV 0s+O86+1QLkdH98JoBSJlCFxw4rm+QJxSgTU4y8YLidbuyowL7wYakuUeY1ZNXuxlHdr3dEPTghpd IvfXllXHxnXtUbvEiXaiDWRTiXFs8pm3Aq/A3eAtO806of32nQ5Ime3EoGhw1rKh0Q4QQSgAXuAn2 tx9Vk/MFMqjiri5+sur3aWW6hBn97PSkKvMdImIsEulwI9kKWOI8obEyD2qwqJnTeX4MkInNJCQti zufsGGowfR7oK6WrKaq8BoJ1eUC8Wq3b3XmCa2Q/EtkFLzLYKb+pL+Z/+L4QgP0bBGmG6UPnFy6DC mKFUVHJo+XqTh5u5gKGA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fcqbt-0007j3-D7; Tue, 10 Jul 2018 11:15:09 +0000 Received: from cloudserver094114.home.pl ([79.96.170.134]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fcqbp-0006aV-PH for linux-arm-kernel@lists.infradead.org; Tue, 10 Jul 2018 11:15:07 +0000 Received: from 79.184.255.246.ipv4.supernova.orange.pl (79.184.255.246) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83) id 17ad5040c1ea7f31; Tue, 10 Jul 2018 13:14:47 +0200 From: "Rafael J. Wysocki" To: Jeremy Linton Subject: Re: 4.18rc3 TX2 boot failure with "ACPICA: AML parser: attempt to continue loading table after error" Date: Tue, 10 Jul 2018 13:13:17 +0200 Message-ID: <3574827.zOC4apc8e1@aspire.rjw.lan> In-Reply-To: <218e4339-477d-eb0d-6007-764c8e24229f@arm.com> References: <218e4339-477d-eb0d-6007-764c8e24229f@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180710_041506_020963_CA268805 X-CRM114-Status: GOOD ( 26.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Schmauss, Erik" , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday, July 10, 2018 5:44:05 AM CEST Jeremy Linton wrote: > Hi, > > On 07/09/2018 04:28 PM, Rafael J. Wysocki wrote: > > On Mon, Jul 9, 2018 at 10:45 PM, Jeremy Linton wrote: > >> Hi, > >> > >> First thanks for the patch.. > >> > >> On 07/08/2018 04:14 AM, Rafael J. Wysocki wrote: > >>> > >>> On Monday, July 2, 2018 11:41:42 PM CEST Jeremy Linton wrote: > >>>> > >>>> Hi, > >>>> > >>>> I'm experiencing two problems with commit 5088814a6e931 which is > >>>> "ACPICA: AML parser: attempt to continue loading table after error" > >>>> > >>>> The first is this boot failure on a thunderX2: > >>>> > >>>> [ 10.770098] ACPI Error: Ignore error and continue table load > >> > >> > >> [trimming] > >> > >>>> ]--- > >>>> > >>>> Which does appear to be the result of some bad data in the table, but it > >>>> was working with 4.17, and reverting this commit solves the problem. > >>> > >>> > >>> Does the patch below make any difference? > >>> > >>> --- > >>> drivers/acpi/acpica/psobject.c | 3 +++ > >>> 1 file changed, 3 insertions(+) > >>> > >>> Index: linux-pm/drivers/acpi/acpica/psobject.c > >>> =================================================================== > >>> --- linux-pm.orig/drivers/acpi/acpica/psobject.c > >>> +++ linux-pm/drivers/acpi/acpica/psobject.c > >>> @@ -39,6 +39,9 @@ static acpi_status acpi_ps_get_aml_opcod > >>> ACPI_FUNCTION_TRACE_PTR(ps_get_aml_opcode, walk_state); > >>> walk_state->aml = walk_state->parser_state.aml; > >>> + if (!walk_state->aml) > >>> + return AE_CTRL_PARSE_CONTINUE; > >>> + > >> > >> > >> Well this seems to avoid the crash, but now it hangs right after on the > >> "Ignore error and continue table load" message. > > > > Well, maybe we should just abort in that case. > > > > I'm wondering what happens if you replace the return statement in the > > patch above with > > > > return_ACPI_STATUS(AE_AML_BAD_OPCODE) > > Yes, that is where I went when I applied the patch but I used > AE_CTRL_TERMINATE, which terminates the loop in acpi_ps_parse_loop() and > that appears to successfully finish/terminate the initial parsing pass. > But, it then crashes in acpi_ns_lookup called via the > acpi_walk_resources sequences that goes through ut_evalute_object() due > to the path/scope_info->scope.node being ACPI_ROOT_OBJECT (-1) and > bypassing the null check. Adding a ACPI_ROOT_OBJECT check as well as the > null checks in acpi_ns_lookup results in a successful boot. Tracking > down how the terminate (or whatever) is leaving the info->prefix_node > (in acpi_ns_evaluate) set to ROOT_OBJECT instead of null, is something I > don't yet understand. > > Anyway, I tried Using BAD_OPCODE rather than TERMINATE and it seems to > have the same basic result as PARSE_CONTINUE. OK, thanks! I evidently didn't look deep enough. Can you please check the patch below? I'm not sure if we can pass this broken state to acpi_ps_complete_final_op(), so it may be necessary to return an error directly when aml_op_start is NULL. --- drivers/acpi/acpica/psloop.c | 3 +++ 1 file changed, 3 insertions(+) Index: linux-pm/drivers/acpi/acpica/psloop.c =================================================================== --- linux-pm.orig/drivers/acpi/acpica/psloop.c +++ linux-pm/drivers/acpi/acpica/psloop.c @@ -493,6 +493,9 @@ acpi_status acpi_ps_parse_loop(struct ac ASL_CV_CAPTURE_COMMENTS(walk_state); aml_op_start = parser_state->aml; + if (!aml_op_start) + break; + if (!op) { status = acpi_ps_create_op(walk_state, aml_op_start, &op);