From patchwork Fri Sep 2 16:26:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 12964412 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2933C001B5 for ; Fri, 2 Sep 2022 16:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Mw/w2NXvqH0ynS1XYPkHJcG6BOXsglasQVtXv+emCFs=; b=lZEy/+5fkXqALi 7IDIcC/BAJssgIgPghLkmsyAUjHui4MGSp3ZJFbzsxIXmJfAeXZL2rw2vdY4dShE+UHTxzve0KxdE oW/umZVxDbbTuwrb6Qs6sM5UsRGUcdXfI/J/g07fXFEZ8dvsTqAVDqOoCCkyNp/VCpFbAmj8u/5cG RybVAAYEMP+T1KsdXNIl9v0IbgHLAHD1UDiqZXxtEgZGw8T8AZp8Z0C4AkyztEm6RUGV8KemTcsAn eUPOfvO3VY5/kHevvwT4IA3txeSuyDUgXdwy6htRGx+zbiCzriTdeILeuMt9Eyf0B+g/x+Nvx2a0m TnA+DQrt4VAcXT14sQAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oU9W0-006zNe-3s; Fri, 02 Sep 2022 16:27:32 +0000 Received: from smtp08.smtpout.orange.fr ([80.12.242.130] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oU9Vv-006ycu-Ri for linux-arm-kernel@lists.infradead.org; Fri, 02 Sep 2022 16:27:30 +0000 Received: from pop-os.home ([90.11.190.129]) by smtp.orange.fr with ESMTPA id U9VRobqH1kifIU9VSoXLOn; Fri, 02 Sep 2022 18:27:03 +0200 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Fri, 02 Sep 2022 18:27:03 +0200 X-ME-IP: 90.11.190.129 From: Christophe JAILLET To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , Andy Shevchenko , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3] stmmac: intel: Simplify intel_eth_pci_remove() Date: Fri, 2 Sep 2022 18:26:56 +0200 Message-Id: <35ab3ac5b67716acb3f7073229b02a38fce71fb7.1662135995.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220902_092728_050745_E3617AD0 X-CRM114-Status: GOOD ( 10.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is no point to call pcim_iounmap_regions() in the remove function, this frees a managed resource that would be release by the framework anyway. Signed-off-by: Christophe JAILLET Reviewed-by: Andy Shevchenko --- Change in v3: * (no code change) * what was patch 1/2 in the serie has been applied * synch with net-next Change in v2: * (no code change) * Remove the text added below the --- in v1 (see link below if needed) * Add Reviewed-by: https://lore.kernel.org/all/2aeb1a03d07c686efd8b3e6fc8ff2d45cd7da1e8.1660659689.git.christophe.jaillet@wanadoo.fr/ v1: https://lore.kernel.org/all/9f82d58aa4a6c34ec3c734399a4792d3aa23297f.1659204745.git.christophe.jaillet@wanadoo.fr/ --- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c index 7d3c7ca7caf4..0a2afc1a3124 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c @@ -1135,8 +1135,6 @@ static void intel_eth_pci_remove(struct pci_dev *pdev) clk_disable_unprepare(priv->plat->stmmac_clk); clk_unregister_fixed_rate(priv->plat->stmmac_clk); - - pcim_iounmap_regions(pdev, BIT(0)); } static int __maybe_unused intel_eth_pci_suspend(struct device *dev)