From patchwork Fri Apr 2 10:12:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Syed Nayyar Waris X-Patchwork-Id: 12180749 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72D72C433ED for ; Fri, 2 Apr 2021 10:24:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EAC8610E7 for ; Fri, 2 Apr 2021 10:24:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EAC8610E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NzUwajGbAmDIMMXTcVDQHa9tlOxFWTn1yiuXA+/pc9I=; b=FrCSGDLJKZ0R8goTPRl8hG0vc gXsvTCiBDLVzcUlG511ZYcArcyfK2CrV72448Da3QxljDsx+VjpdHTER/qbbubgsg7nBGluTR5DF/ mt8IOPSUxyD7P8Ws7LYbYnjrMottXK11WOct1+EzlHWVE5XpfsMfWMVuHQpl0otqzoff1vS06wMpD Sdw+x/PxFaQKdl1qiDw8bV9lQcHXU8k0Pc6QXKuoXSgKQeoDNDg8M4/LMN6dIOESECKNPNdNU3Oy8 hAcczU64CFgD234KuTirHLNggHbtsU4A0hXiVvZbBmhBZMwFoMF/NV/Rbl+9CMC/C2SA1Z6kwDDG7 aFL02om2Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lSGvb-00CjIU-Bo; Fri, 02 Apr 2021 10:21:24 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lSGmu-00Chmg-IG for linux-arm-kernel@lists.infradead.org; Fri, 02 Apr 2021 10:12:30 +0000 Received: by mail-pf1-x42d.google.com with SMTP id c204so3334257pfc.4 for ; Fri, 02 Apr 2021 03:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pjJTs/trNbCfk/Wd5AeG0sctmtT3vopPWM58p/JWi08=; b=X0pl6oiDGAB8riJRc8TdXBwVXf3oZNvOJwhTa2W7pA6M5M9hyfmX2bdbKbwz3pblYH IYZg697aXp3DpAZFoRpEwUwnG4Ag90KNmwmeUStf6J9wmarh7MIONtvf1++OG7p/D7JQ vHyoAHEujja+kgxFzY7F8rpzz/L+xoNeoT4okBQ8ARmhePe0AW0pahn3rGDhiHWW1FTW 7ArCZ4+c3aZn6tz5iajWiKbQC0bX/UUDgt8X8asCIgEhk7QA4Fapo+SASiuOZj+hAU79 E/RLY4srtg9kbXu4wHonooy57C3VgAQVj3IZLjA1ySSBcQRCXQ5L/hgzGa6aWDUkWF8Q glGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pjJTs/trNbCfk/Wd5AeG0sctmtT3vopPWM58p/JWi08=; b=tUbeaJaH6xMoqref7dyHsB0kBHVXyxNDI5JmxKDpqbAK/SbxQWPYZwcwYjy8zh5ykl IImV77oFc50w5IDMSNYCVSwkJLNfshn3vNK27d5lk51ULU799NNVl3JGUNKEoL8LCV+L eOqP5SafHZ/7I2uoZf8YL68R2V1AFoYs5R7Eu3AOgE9dos4EsuFRozumqndvujGXvljL p/QI1Cg72yN/2JKR+Ye5HCGoAek0i5Wge8M/UzrU5mryPT+giNVSRapfl3SPc3tmAN6r DmhxOsU8W3g+qoNyLnBE021HUNE4FsYuKLLsS2p71lirpP4sGc3hVQ4CPzMJc7PsfKli u8fA== X-Gm-Message-State: AOAM531sBgMFl0jqY4LdynaBGPMlmhNsTj/oFNYHks0GaCvzboB6ijMC JcipPQtDGZ/m79Pr8rOD9HE= X-Google-Smtp-Source: ABdhPJw8RJb7DEr9GjqHs0QTLVJduTr4bs7vTfx3FKXKyLa3wkOCb2XxgyvGtFl04jQnovTx3jM9Cw== X-Received: by 2002:a63:f542:: with SMTP id e2mr11371560pgk.338.1617358342446; Fri, 02 Apr 2021 03:12:22 -0700 (PDT) Received: from syed ([223.225.111.29]) by smtp.gmail.com with ESMTPSA id b84sm8051524pfb.162.2021.04.02.03.12.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Apr 2021 03:12:22 -0700 (PDT) Date: Fri, 2 Apr 2021 15:42:06 +0530 From: Syed Nayyar Waris To: bgolaszewski@baylibre.com Cc: andriy.shevchenko@linux.intel.com, vilhelm.gray@gmail.com, michal.simek@xilinx.com, arnd@arndb.de, rrichter@marvell.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, yamada.masahiro@socionext.com, akpm@linux-foundation.org, rui.zhang@intel.com, daniel.lezcano@linaro.org, amit.kucheria@verdurent.com, linux-arch@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH v4 2/3] gpio: thunderx: Utilize for_each_set_nbits macro Message-ID: <3a9bd0a593798538bec54d8b5ceab20a73d7eaa1.1617357235.git.syednwaris@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210402_111225_841218_39C020FE X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This patch reimplements the thunderx_gpio_set_multiple function in drivers/gpio/gpio-thunderx.c to use the new for_each_set_nbits macro. Instead of looping for each bank in thunderx_gpio_set_multiple function, now we can skip bank which is not set and save cycles. Cc: Robert Richter Cc: Bartosz Golaszewski Signed-off-by: Syed Nayyar Waris Acked-by: William Breathitt Gray --- drivers/gpio/gpio-thunderx.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-thunderx.c b/drivers/gpio/gpio-thunderx.c index 9f66deab46ea..4349e7393a1d 100644 --- a/drivers/gpio/gpio-thunderx.c +++ b/drivers/gpio/gpio-thunderx.c @@ -16,7 +16,7 @@ #include #include #include - +#include "gpiolib.h" #define GPIO_RX_DAT 0x0 #define GPIO_TX_SET 0x8 @@ -275,12 +275,15 @@ static void thunderx_gpio_set_multiple(struct gpio_chip *chip, unsigned long *bits) { int bank; - u64 set_bits, clear_bits; + unsigned long set_bits, clear_bits, gpio_mask; + unsigned long offset; + struct thunderx_gpio *txgpio = gpiochip_get_data(chip); - for (bank = 0; bank <= chip->ngpio / 64; bank++) { - set_bits = bits[bank] & mask[bank]; - clear_bits = ~bits[bank] & mask[bank]; + for_each_set_nbits(offset, gpio_mask, mask, chip->ngpio, 64) { + bank = offset / 64; + set_bits = bits[bank] & gpio_mask; + clear_bits = ~bits[bank] & gpio_mask; writeq(set_bits, txgpio->register_base + (bank * GPIO_2ND_BANK) + GPIO_TX_SET); writeq(clear_bits, txgpio->register_base + (bank * GPIO_2ND_BANK) + GPIO_TX_CLR); }