From patchwork Tue Nov 14 10:54:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Gonzalez X-Patchwork-Id: 10057453 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 05F966023A for ; Tue, 14 Nov 2017 12:17:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C701B2974E for ; Tue, 14 Nov 2017 12:17:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BB8A929753; Tue, 14 Nov 2017 12:17:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 57C0C2974E for ; Tue, 14 Nov 2017 12:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OtNdAFxWTq3WgigN5whwvbP856n+CMH1inM60xXeKvA=; b=AVICpw5yCkMQdh s7TjrA+Cgt99gstpouMj/thssMywZO0nOQB2AAmOkghL83XMWjBlTu8a78WBmCX+U3Folm9Mhzits y0e2Oh7BQhDoiUbriFEUSYrR0FW6qo81/FXZo/+rv299iJpuz/PhGNopWCp3F8Iz1Il9e+Q3U0HFV AQMRNh3JvYF/cwg8jIufVr34/cx/FHUDQWW3ANM0RcFxIsvYB9kJbq9UZJv2Ah2gzID3EiCiybIFr LrU4mKVfy/qehjmhSHbTcOp2cOTd/DXf0kbYCWsCIdopAD+LK6RYpDUSagV9KPBcUmybWL0gc+9B4 EPIPJ8WgqDxjc9QPHPZw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eEa9f-0004jV-Lp; Tue, 14 Nov 2017 12:17:27 +0000 Received: from us-smtp-delivery-107.mimecast.com ([63.128.21.107]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eEZzm-00084v-CS for linux-arm-kernel@lists.infradead.org; Tue, 14 Nov 2017 12:07:20 +0000 Received: from CPH-EX1.SDESIGNS.COM (195-215-56-170-static.dk.customer.tdc.net [195.215.56.170]) (Using TLS) by us-smtp-1.mimecast.com with ESMTP id us-mta-150-aAgNAKd8NOWOy_fjdP4dGA-1; Tue, 14 Nov 2017 07:06:50 -0500 X-MC-Unique: aAgNAKd8NOWOy_fjdP4dGA-1 Received: from [172.27.0.114] (172.27.0.114) by CPH-EX1.sdesigns.com (192.168.10.36) with Microsoft SMTP Server (TLS) id 14.3.294.0; Tue, 14 Nov 2017 13:06:47 +0100 Subject: [PATCH v3 1/4] net: nb8800: Drop generic support From: Marc Gonzalez To: David Miller , Mans Rullgard References: <230165aa-eaf1-6e2b-7ff3-45b3ee4ffc62@sigmadesigns.com> Message-ID: <3c0385f3-bae9-8b40-aec4-3818456b2767@sigmadesigns.com> Date: Tue, 14 Nov 2017 11:54:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.1 MIME-Version: 1.0 In-Reply-To: <230165aa-eaf1-6e2b-7ff3-45b3ee4ffc62@sigmadesigns.com> X-Originating-IP: [172.27.0.114] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171114_040714_507003_BBE3B05B X-CRM114-Status: UNSURE ( 8.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev , Thibaud Cornic , Florian Fainelli , Linux ARM , Mason Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP According to our HW dev, there is no provision for software to safely disable RX DMA in the AU-NB8800 hardware block (ethernet DMA). Thus, it is the responsibility of the SoC designer to provide such a feature. The nb8800_dma_stop() implementation is a clever hack that works most of the times, but it breaks the DMA state machine in rare cases. Therefore, let's drop generic support. FWIW, tango chips provide a reset register. When the ethernet block comes out of reset, DMA is disabled. Signed-off-by: Marc Gonzalez --- drivers/net/ethernet/aurora/nb8800.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c index e94159507847..26f719e2d6ca 100644 --- a/drivers/net/ethernet/aurora/nb8800.c +++ b/drivers/net/ethernet/aurora/nb8800.c @@ -1335,9 +1335,6 @@ static const struct nb8800_ops nb8800_tango4_ops = { }; static const struct of_device_id nb8800_dt_ids[] = { - { - .compatible = "aurora,nb8800", - }, { .compatible = "sigma,smp8642-ethernet", .data = &nb8800_tangox_ops,