diff mbox

[2/2] usb: gadget: Add test if argument pointer has a valid value in pxa27x_udc

Message ID 3c2b75a6-55ec-bf5e-1f84-4c9a50e04660@tul.cz (mailing list archive)
State New, archived
Headers show

Commit Message

Petr Cvek Feb. 23, 2017, 1:35 a.m. UTC 
Move call usb_put_phy(udc->transceiver) inside a valid pointer test.

Reported-by: robert.jarzmik@free.fr
Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
---
 drivers/usb/gadget/udc/pxa27x_udc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Robert Jarzmik Feb. 23, 2017, 7:28 a.m. UTC | #1 
Petr Cvek <petr.cvek@tul.cz> writes:

> Move call usb_put_phy(udc->transceiver) inside a valid pointer test.
>
> Reported-by: robert.jarzmik@free.fr
I'd rather have my normal signature here :
Reported-by: Robert Jarzmik <robert.jarzmik@free.fr>

> Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.
diff mbox

Patch

diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
index 6fa675bf2c6f..9d2e1a8aa69d 100644
--- a/drivers/usb/gadget/udc/pxa27x_udc.c
+++ b/drivers/usb/gadget/udc/pxa27x_udc.c
@@ -2531,9 +2531,10 @@  static int pxa_udc_remove(struct platform_device *_dev)
 	usb_del_gadget_udc(&udc->gadget);
 	pxa_cleanup_debugfs(udc);
 
-	if (!IS_ERR_OR_NULL(udc->transceiver))
+	if (!IS_ERR_OR_NULL(udc->transceiver)) {
 		usb_unregister_notifier(udc->transceiver, &pxa27x_udc_phy);
-	usb_put_phy(udc->transceiver);
+		usb_put_phy(udc->transceiver);
+	}
 
 	udc->transceiver = NULL;
 	the_controller = NULL;