From patchwork Fri Nov 16 10:01:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10685783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CB03214DB for ; Fri, 16 Nov 2018 10:03:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA93D2D3F1 for ; Fri, 16 Nov 2018 10:03:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AE6CD2D4B6; Fri, 16 Nov 2018 10:03:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4416F2D403 for ; Fri, 16 Nov 2018 10:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TrN3c2LrnZg4vQ3d6twmCYvzd1+qbU0SLjl6ddirGcE=; b=JuuDMxn3I20h6S 15iHa/M8xB4Kvq+3ydV5z7eb/bVWEWhM2WAOL1040Mlm9d0U7itcm+i9MtA8VeHgdkszKHtWH4qOX 23CROKBYhONTXZU1OYK/mhokS34312bQbPnNl5DTe2aVNSex924Wpo6M/dzby7wX2REiZWa9QCL3A F2uX6QPXQpGGLu0yp8EO0D0VpoaXvr8R7MqMFmXUwD/542He7UYlyixvjKnSFV0QmNjsWUmByvOc3 YphSTldLSPlXp4oXAMCXtxzBS3GOkVb3agZLyqhFoOKSliCNozvTAE5XschCUxfoXlenBm8csoknJ dJlt9K7lTjQKJwhOZq7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gNaxu-0004wV-MZ; Fri, 16 Nov 2018 10:03:06 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gNawg-0003d8-AX for linux-arm-kernel@lists.infradead.org; Fri, 16 Nov 2018 10:01:57 +0000 Received: by mail-pl1-x644.google.com with SMTP id w22-v6so10948887plk.0 for ; Fri, 16 Nov 2018 02:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LK6GiW769WFFMCSrW8bZq8d0PusJgT2ioSzhc2edhMA=; b=fq+At354HoAdN09twMtyS3uMc8QXc2XxXLgHQY9WkbhKgkRKwNemxOdQH3+SceMY+m SKk6RGwNyqjv49thLZgJfxIzTLX44RhhOfJ+SJqDtuiDCjrESb1MkUqMz+5EDSEwLDzM InKRhBL9rj1SrpStpMIXCel8q5B66PSAT13EE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LK6GiW769WFFMCSrW8bZq8d0PusJgT2ioSzhc2edhMA=; b=b2/nFvdUIWGkCNC1IbwQEWqinbZiZK6GGn99rQ/OHT5u6Rp+/wJ/OHEKnrbG4kr+Ne BkNoaN5hA0NguXcy+8n2EthASSsi0mpIwBAxkqpHuAULDgzE7OO9tEvw9WiqOT0ogV5G 7GFSWAPuRonQGjkUpr7NXZ7JtcoCY1WS5QyRbWBPXzZq1+Mn2i+9ZGcNpYLd9Mth+6iT SrUSt2+CUAMT0jaBXX6IxqT34Pga/Em55mxnuJVGNWek19TxeYvpV6bDlDzUijISFAgP nTfN4L4Ff+elTjzkADTvF4OTvIscUl5+2hII8oYaOlO1oLl06GqILSmm39lL6PTx1r29 CJLA== X-Gm-Message-State: AGRZ1gIi6uPZMt16+o7GD2hVQaDPEoXPjTcjfvjZvAKLGBhzfaotjv7U czoLSkstdel1kOTAEiMD64DY2g== X-Google-Smtp-Source: AJdET5cP3OiPVJ0GUIcBL5FuxbLvoThio2c0iqx0gdi1CHjEsGsz/vnFwS7sJ94vVR+Jg81RGev/lw== X-Received: by 2002:a17:902:162:: with SMTP id 89-v6mr10100540plb.293.1542362499626; Fri, 16 Nov 2018 02:01:39 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id o84sm18959674pfi.172.2018.11.16.02.01.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:01:39 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , Matthias Brugger Subject: [PATCH 3/6] ARM: dts: mt7623: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:31:12 +0530 Message-Id: <3c44454d70c9c9bafcf86f2c020d17d048f33360.1542362000.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181116_020150_384485_01730035 X-CRM114-Status: GOOD ( 14.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Vincent Guittot , Viresh Kumar , Daniel Lezcano , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/mt7623.dtsi | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi index d01bdee6f2f3..7cae886f79c9 100644 --- a/arch/arm/boot/dts/mt7623.dtsi +++ b/arch/arm/boot/dts/mt7623.dtsi @@ -187,17 +187,26 @@ cooling-maps { map0 { trip = <&cpu_passive>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; map1 { trip = <&cpu_active>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; map2 { trip = <&cpu_hot>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; };