From patchwork Fri Apr 21 08:43:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mason X-Patchwork-Id: 9692189 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 880D060328 for ; Fri, 21 Apr 2017 08:45:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7FEC328609 for ; Fri, 21 Apr 2017 08:45:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 747CD28618; Fri, 21 Apr 2017 08:45:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 114B428609 for ; Fri, 21 Apr 2017 08:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1K8lkEelHwv2krvA0+37aV70BZLUzAzU7ybc1RcX/co=; b=S3NKkB12dG0CKX VBM9fzYAG0sXASjT4nEb50gnePO9noPiofiqaHPdzdLMF/iRG06SQ8h0Wz0QiupUSCg6eduNvtYz6 WLthRZuYfTnRJrSpv99qGRaBHdz8B0wgP5ZlxanuD925Wr9qOzqOgX+vagA0SzY73aQdCb2pqArg6 tpkbDySDLtHzWRvU1sOx1i/9syuTZ99Ro9soEwitz8vvRafN2y0lSCsJdZHuSnwcQyOzESAWFZq5d Hozc8onOUl7FpTHP12M40NA3vIEZ6PwoSF0MybyzonPbRB0+tLO2KdfIT5kRyMFo+Uoy2Y2SJqf9d csz+IZh/FIvNEVNE3IkA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1d1UCQ-0007fU-56; Fri, 21 Apr 2017 08:45:54 +0000 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1d1UAp-0005Pk-Fc for linux-arm-kernel@lists.infradead.org; Fri, 21 Apr 2017 08:44:41 +0000 Received: from [192.168.0.66] (unknown [88.191.210.51]) (Authenticated sender: shill) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 761AD200413; Fri, 21 Apr 2017 10:43:25 +0200 (CEST) Subject: [PATCH v2] dmaengine: sun4i: fix invalid argument To: Maxime Ripard References: <20170421084033.5c987e13@canb.auug.org.au> <9858a4ed-bdd9-bd6c-d8a4-e9e6bd539904@free.fr> <584a2c53-100b-945b-d665-cef3fa856526@free.fr> <20170421082417.7cqtevwuhjvfgjcx@lukather> From: Mason Message-ID: <3e98596a-0322-e4f1-7cc2-9b0eaceb4465@free.fr> Date: Fri, 21 Apr 2017 10:43:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49 MIME-Version: 1.0 In-Reply-To: <20170421082417.7cqtevwuhjvfgjcx@lukather> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170421_014415_907895_728D06EF X-CRM114-Status: UNSURE ( 7.06 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Russell King , arm-soc , Vinod Koul , LKML , Emilio Lopez , Chen-Yu Tsai , linux-next , dmaengine@vger.kernel.org, Dan Williams , Linux ARM Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Marc Gonzalez The "pchans_used" field is an unsigned long array. for_each_clear_bit_from() expects an unsigned long pointer, not an array address. $ make C=2 drivers/dma/sun4i-dma.o CHECK drivers/dma/sun4i-dma.c drivers/dma/sun4i-dma.c:241:9: warning: incorrect type in argument 1 (different base types) drivers/dma/sun4i-dma.c:241:9: expected unsigned long const *p drivers/dma/sun4i-dma.c:241:9: got unsigned long ( * )[1] Signed-off-by: Marc Gonzalez Acked-by: Maxime Ripard --- drivers/dma/sun4i-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c index 57aa227bfadb..f4ed3f17607c 100644 --- a/drivers/dma/sun4i-dma.c +++ b/drivers/dma/sun4i-dma.c @@ -238,7 +238,7 @@ static struct sun4i_dma_pchan *find_and_use_pchan(struct sun4i_dma_dev *priv, } spin_lock_irqsave(&priv->lock, flags); - for_each_clear_bit_from(i, &priv->pchans_used, max) { + for_each_clear_bit_from(i, priv->pchans_used, max) { pchan = &pchans[i]; pchan->vchan = vchan; set_bit(i, priv->pchans_used);