From patchwork Thu Dec 30 11:31:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12701399 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4106BC433EF for ; Thu, 30 Dec 2021 11:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o1qQm1xmItYlHqzc3yAMb578l9oCcSoLD/8bth6RLrg=; b=qO9dsZgws9aEXy XtIzgsjS1NofRkRqMnkG5NT1RMV4d7unFgBGkn5Fo1nK+kFlwML8PHMEKhfBu4S2ZWdjFksdxAJx4 yu2lE+ur6QpTViKTtE5TDZ3VV6ZMZZO7Ng4+Sh/DAY0PQ4aqAVrcOkCLkpYyVSwu9gfn5DgEjqbQS +sCsH4UU5P+Su0JygbdPJymOM9E9tzAe06tE8lUp5k8NMdGblyH2HZ380PZDDWzkm250pPqcWfMDa xEpEHLRu2Vk6pNRV4rC0pGTpASpPlmh/OVoQQpaHE3KoDG1XN112qf1yErjlMzBXzPLQEVZSL7w59 h3xOngveALq2nHQiTqCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tgL-004IF7-A8; Thu, 30 Dec 2021 11:33:17 +0000 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tgG-004IDB-PQ; Thu, 30 Dec 2021 11:33:14 +0000 Received: by mail-qv1-xf2d.google.com with SMTP id fo11so21790201qvb.4; Thu, 30 Dec 2021 03:33:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0NAb92aP3BvHX/H/r7xcS0pDvxqvrorYUGqTqAdSQus=; b=A9gJExEihB/bAGFoBMIBq18odmtsTOCydFD2wgMeuWGTGJ3MFb6CqvVl7rmzJptGby 45SuFMl4GHtVNDMdIEezv4fpEfhXmJWSJrmsNZXt3EZoL1QFT8BwszUdJU/g1l0d9pHc XtSfHGfHRgiJnZUfSf1P8TaYErGPK/0gGC4qCSS4pMTeiZ/qCt9wrah1f3VMqO3ggNkS dswRWt+db55IzbzIJv8SjnWR4GmbqGK/FxMNjdrLVWiLweC/IO5OvCL0FxEWkOcRSzbH XcGQkyC9oC5gGhYxbOgXfe5uTOTmSpAq2Ugm9FDxN/nDaK6pjirB2SUKVmxPcgzk+MNA vIig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0NAb92aP3BvHX/H/r7xcS0pDvxqvrorYUGqTqAdSQus=; b=esekB0EVJrJNfrEovHJ9krh39+m3NigzlAJWKfMMdX432cnDwk3cRH7bOzrCmfZPjU AIn0wd3/9Eq1XfjTnQgjvBSxJHiLoi2Fe27qjxknSaX7INRw/SfdCTqe6nG1JpFbPazy jNcHpg8BgDor4mKjwQ/tXA0V64jIfDfxihuyy11KN25/N/FYdxkf6L4hmC5zPdjZZ/rK deVTsi4Nj8Yft2YgYbWnKHQQmxveYyaR7beuoeh6H/qVgKSN8YpqRLZwz7iiwfPcsCM9 2tViSNndegFAb05nTxJqLuvk3KOKgLMZANBPvpd82Y88yJg9vNglhDE60AEcUi+gpcN4 W3xA== X-Gm-Message-State: AOAM531BoHTBxU/Ey9Dhz9RfqBwiF8Jlqy9xHF2YB/MCVIct6YdtPxR/ zM3NTTNkBCLTdlse4g3WSgs= X-Google-Smtp-Source: ABdhPJym1DmSfFDOm0+uJkMnhCuNXQ/vZE1Hb0Km0uMhLyBPVYS1yLSZhyh+rXnBWdszqWcIzY3AJg== X-Received: by 2002:a05:6214:2344:: with SMTP id hu4mr11691004qvb.55.1640863991767; Thu, 30 Dec 2021 03:33:11 -0800 (PST) Received: from localhost.localdomain ([181.23.70.139]) by smtp.gmail.com with ESMTPSA id v5sm20348559qkp.126.2021.12.30.03.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 03:33:11 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 3/3] staging: vc04_services: update TODO file Date: Thu, 30 Dec 2021 08:31:29 -0300 Message-Id: <3f560a75063a0bb744bb34c410e49f792d2c3d21.1640776340.git.gascoar@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_033312_869323_4DA0DCEB X-CRM114-Status: GOOD ( 13.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There are no struct typedef remaining inside vc04_services/. Hence, remove the task from the TODO file. While at it, fix the items sequential numbering. Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/TODO | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 39810ce017cd..241ca004735c 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -80,11 +80,7 @@ vchiq-core.ko and vchiq-dev.ko. This would also ease the upstreaming process. The code in vchiq_bcm2835_arm.c should fit in the generic platform file. -12) Get rid of all the struct typedefs - -Most structs are typedefd, it's not encouraged in the kernel. - -13) Get rid of all non essential global structures and create a proper per +11) Get rid of all non essential global structures and create a proper per device structure The first thing one generally sees in a probe function is a memory allocation @@ -92,6 +88,6 @@ for all the device specific data. This structure is then passed all over the driver. This is good practice since it makes the driver work regardless of the number of devices probed. -14) Clean up Sparse warnings from __user annotations. See +12) Clean up Sparse warnings from __user annotations. See vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter" is never disclosed to userspace.