| Message ID | 3fef68a94e4947d58a199709929d30e0e2bf2e44.1651139070.git.quic_saipraka@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | lib/rwmmio/arm64: Add support to trace register reads/writes | expand |
On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote: > Disable MMIO tracing for geni serial driver as it is a high > frequency operation for serial driver with many register reads/ > writes and not very useful to log all MMIO traces and prevent > excessive logging. > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com> > --- > drivers/tty/serial/qcom_geni_serial.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index 1543a6028856..5b48e6c2bf3c 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -1,5 +1,11 @@ > // SPDX-License-Identifier: GPL-2.0 > -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved. > +/* > + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > + */ I strongly disagree that adding a single line here warrants a copyright update. If your lawyers will sign off on this change, I am willing to reconsider. > + > +/* Disable MMIO tracing */ Please say why in the comment, not just what. thanks, greg k-h
On 4/28/2022 4:20 PM, Greg KH wrote: > On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote: >> Disable MMIO tracing for geni serial driver as it is a high >> frequency operation for serial driver with many register reads/ >> writes and not very useful to log all MMIO traces and prevent >> excessive logging. >> >> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> >> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com> >> --- >> drivers/tty/serial/qcom_geni_serial.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c >> index 1543a6028856..5b48e6c2bf3c 100644 >> --- a/drivers/tty/serial/qcom_geni_serial.c >> +++ b/drivers/tty/serial/qcom_geni_serial.c >> @@ -1,5 +1,11 @@ >> // SPDX-License-Identifier: GPL-2.0 >> -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved. >> +/* >> + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. >> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >> + */ > I strongly disagree that adding a single line here warrants a copyright > update. If your lawyers will sign off on this change, I am willing to > reconsider. > You are right, I checked with them and they mentioned copyright update is not required for a one line change. >> + >> +/* Disable MMIO tracing */ > Please say why in the comment, not just what. > Hmm the changelog describes it but I can add a comment as well. Thanks, Sai
On 4/28/2022 3:50 AM, Greg KH wrote: > On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote: >> Disable MMIO tracing for geni serial driver as it is a high >> frequency operation for serial driver with many register reads/ >> writes and not very useful to log all MMIO traces and prevent >> excessive logging. >> >> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> >> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com> >> --- >> drivers/tty/serial/qcom_geni_serial.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c >> index 1543a6028856..5b48e6c2bf3c 100644 >> --- a/drivers/tty/serial/qcom_geni_serial.c >> +++ b/drivers/tty/serial/qcom_geni_serial.c >> @@ -1,5 +1,11 @@ >> // SPDX-License-Identifier: GPL-2.0 >> -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved. >> +/* >> + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. >> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >> + */ > > I strongly disagree that adding a single line here warrants a copyright > update. If your lawyers will sign off on this change, I am willing to > reconsider. I am not a lawyer, we can skip adding QuIC copyright here since it is just one line change, but at the same time we can't add 2022 year in the existing copyright. If that is fine, we can skip the copyright year update entirely. ---Trilok Soni
On Thu, Apr 28, 2022 at 09:31:43AM -0700, Trilok Soni wrote: > On 4/28/2022 3:50 AM, Greg KH wrote: > > On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote: > > > Disable MMIO tracing for geni serial driver as it is a high > > > frequency operation for serial driver with many register reads/ > > > writes and not very useful to log all MMIO traces and prevent > > > excessive logging. > > > > > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > > Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com> > > > --- > > > drivers/tty/serial/qcom_geni_serial.c | 8 +++++++- > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > > > index 1543a6028856..5b48e6c2bf3c 100644 > > > --- a/drivers/tty/serial/qcom_geni_serial.c > > > +++ b/drivers/tty/serial/qcom_geni_serial.c > > > @@ -1,5 +1,11 @@ > > > // SPDX-License-Identifier: GPL-2.0 > > > -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved. > > > +/* > > > + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. > > > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > > > + */ > > > > I strongly disagree that adding a single line here warrants a copyright > > update. If your lawyers will sign off on this change, I am willing to > > reconsider. > > I am not a lawyer, we can skip adding QuIC copyright here since it is just > one line change, but at the same time we can't add 2022 year in the existing > copyright. That is correct, because you are not making a copyrightable change, otherwise the single line addition would be ok. Talk to your lawyers about this :) > If that is fine, we can skip the copyright year update entirely. Please do. thanks, greg k-h
On 4/28/2022 9:49 AM, Greg KH wrote: > On Thu, Apr 28, 2022 at 09:31:43AM -0700, Trilok Soni wrote: >> On 4/28/2022 3:50 AM, Greg KH wrote: >>> On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote: >>>> Disable MMIO tracing for geni serial driver as it is a high >>>> frequency operation for serial driver with many register reads/ >>>> writes and not very useful to log all MMIO traces and prevent >>>> excessive logging. >>>> >>>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> >>>> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com> >>>> --- >>>> drivers/tty/serial/qcom_geni_serial.c | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c >>>> index 1543a6028856..5b48e6c2bf3c 100644 >>>> --- a/drivers/tty/serial/qcom_geni_serial.c >>>> +++ b/drivers/tty/serial/qcom_geni_serial.c >>>> @@ -1,5 +1,11 @@ >>>> // SPDX-License-Identifier: GPL-2.0 >>>> -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved. >>>> +/* >>>> + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. >>>> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >>>> + */ >>> >>> I strongly disagree that adding a single line here warrants a copyright >>> update. If your lawyers will sign off on this change, I am willing to >>> reconsider. >> >> I am not a lawyer, we can skip adding QuIC copyright here since it is just >> one line change, but at the same time we can't add 2022 year in the existing >> copyright. > > That is correct, because you are not making a copyrightable change, > otherwise the single line addition would be ok. > > Talk to your lawyers about this :) > >> If that is fine, we can skip the copyright year update entirely. > > Please do. > Sai, please go ahead and remove QuIC copyright line here. ---Trilok Soni
On 4/28/2022 10:30 PM, Trilok Soni wrote: > On 4/28/2022 9:49 AM, Greg KH wrote: >> On Thu, Apr 28, 2022 at 09:31:43AM -0700, Trilok Soni wrote: >>> On 4/28/2022 3:50 AM, Greg KH wrote: >>>> On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote: >>>>> Disable MMIO tracing for geni serial driver as it is a high >>>>> frequency operation for serial driver with many register reads/ >>>>> writes and not very useful to log all MMIO traces and prevent >>>>> excessive logging. >>>>> >>>>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> >>>>> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com> >>>>> --- >>>>> drivers/tty/serial/qcom_geni_serial.c | 8 +++++++- >>>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c >>>>> index 1543a6028856..5b48e6c2bf3c 100644 >>>>> --- a/drivers/tty/serial/qcom_geni_serial.c >>>>> +++ b/drivers/tty/serial/qcom_geni_serial.c >>>>> @@ -1,5 +1,11 @@ >>>>> // SPDX-License-Identifier: GPL-2.0 >>>>> -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved. >>>>> +/* >>>>> + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. >>>>> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >>>>> + */ >>>> >>>> I strongly disagree that adding a single line here warrants a copyright >>>> update. If your lawyers will sign off on this change, I am willing to >>>> reconsider. >>> >>> I am not a lawyer, we can skip adding QuIC copyright here since it is just >>> one line change, but at the same time we can't add 2022 year in the existing >>> copyright. >> >> That is correct, because you are not making a copyrightable change, >> otherwise the single line addition would be ok. >> >> Talk to your lawyers about this :) >> >>> If that is fine, we can skip the copyright year update entirely. >> >> Please do. >> > > Sai, please go ahead and remove QuIC copyright line here. > > Already done yesterday itself in the new version which is v13. Thanks, Sai
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 1543a6028856..5b48e6c2bf3c 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -1,5 +1,11 @@ // SPDX-License-Identifier: GPL-2.0 -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved. +/* + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. + */ + +/* Disable MMIO tracing */ +#define __DISABLE_TRACE_MMIO__ #include <linux/clk.h> #include <linux/console.h>
Disable MMIO tracing for geni serial driver as it is a high frequency operation for serial driver with many register reads/ writes and not very useful to log all MMIO traces and prevent excessive logging. Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com> --- drivers/tty/serial/qcom_geni_serial.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)