From patchwork Tue Apr 23 08:07:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13639586 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52DF3C4345F for ; Tue, 23 Apr 2024 08:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2tvKMNGi2FYl+yEty211fBsNsVPAUHPhYPZzmabDVRI=; b=3+Wt07yYNZNRat Yc+KfIIRHjNTLO9ncsvDIsF7BxI3o9beFeDikCQTr2WcCGX9taTr5dL3Ky5EDjJmUzCuXBHxEKmnN dRSyWMy8+kf4B325MDJSoQDr96KpRGo5UDcbFF1owrGc0vrWZmgUdsEnrC0U93xUsGPcJf1t/qQLC mA0x6HuFPiQ9x15c3nYJJMhUqzmsnZlntZ/OM6WqYhGTRlEB7wAZ+katj4esM9pGszjfwv5Jzg+RL RPWuVFmnWdMfEqN8cDDVN8ET0H1Z6C4gV0B0DTpEqITarr4/34/JEN0CzdY5BUnoaQkHkldcDJssD eOOfhv+qBMJzh0+IPSoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBo-0000000GP57-1dhC; Tue, 23 Apr 2024 08:07:44 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBT-0000000GOx4-0ykq for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 08:07:27 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzBBL-000358-JD; Tue, 23 Apr 2024 10:07:15 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzBBK-00Dq1Y-I2; Tue, 23 Apr 2024 10:07:14 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rzBBK-006nfv-1V; Tue, 23 Apr 2024 10:07:14 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Anshuman Khandual , Sudeep Holla Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, Greg Kroah-Hartman Subject: [PATCH 3/5] coresight: stm: Convert to platform remove callback returning void Date: Tue, 23 Apr 2024 10:07:00 +0200 Message-ID: <3fefa60744fc68c9c4b40aeb69e34cda22582c4b.1713858615.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2082; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=6jj1et03NEbeAAFrK+MkJGJ4zRd04/Wcgxra5zA+vuQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmJ2wol9aHpD6mMPDRKveIJ6x8NgbDf8sNB72sl 2DxjYz27J2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZidsKAAKCRCPgPtYfRL+ TuQSB/9aM2ihAPUtN72QJZb2kgQsH/1X8r6mrqaNXZAA9BED8kRjWGrPMecm8obijzWOWbwgj3v 61+jMl9H0KT4MaNeUw58E1bFB16TkSNRoxjWKD1UgYocLYnhPjHdxbEfTA5qgtJ7sLsJqi94wtY VA/ksJ6v/wC62oc1qRISsOLgpe5PzkejkgmLb8vEloegcD73qHNh2Ui/14AHq5cFn34yCAvYD+w IYluumtU9ck8N9f43GgoZHmGsAznZBVw7ZMvDUkZXErdRpFZUpYWruqvbRlCHoEeyD6f7UqhOmZ NqIb8rDH97KZxpblfWH23tyF5CDzUw0sPWdQeadswDtVaycd X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_010723_293398_EDD2BE1C X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Fixes: 057256aaacc8 ("coresight: stm: Move ACPI support from AMBA driver to platform driver") Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-stm.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c index cbf7f17556f8..96b1a8cfee14 100644 --- a/drivers/hwtracing/coresight/coresight-stm.c +++ b/drivers/hwtracing/coresight/coresight-stm.c @@ -1014,18 +1014,17 @@ static int stm_platform_probe(struct platform_device *pdev) return ret; } -static int stm_platform_remove(struct platform_device *pdev) +static void stm_platform_remove(struct platform_device *pdev) { struct stm_drvdata *drvdata = dev_get_drvdata(&pdev->dev); if (WARN_ON(!drvdata)) - return -ENODEV; + return; __stm_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); if (!IS_ERR_OR_NULL(drvdata->pclk)) clk_put(drvdata->pclk); - return 0; } #ifdef CONFIG_ACPI @@ -1038,7 +1037,7 @@ MODULE_DEVICE_TABLE(acpi, stm_acpi_ids); static struct platform_driver stm_platform_driver = { .probe = stm_platform_probe, - .remove = stm_platform_remove, + .remove_new = stm_platform_remove, .driver = { .name = "coresight-stm-platform", .acpi_match_table = ACPI_PTR(stm_acpi_ids),