From patchwork Thu Jan 11 17:22:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 10158287 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DBA13601A1 for ; Thu, 11 Jan 2018 17:23:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE0EF28178 for ; Thu, 11 Jan 2018 17:23:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B194828417; Thu, 11 Jan 2018 17:23:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A748328178 for ; Thu, 11 Jan 2018 17:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KgoNj1NlW/xJ8bcjjU28yLYJk7PLVXWU8TKhjH74uw0=; b=Zr89QjgXCAHIOa7Mjm4ghJ+5B Zehc1CyAzBhyPp2bqbqpQD+YqEWykPMEN1HKT2IK53S5ozK5kSMKws40qX0L4Pu7pZnwvZvcbZDX9 NX7Gki5AVHscwQSiJxQUvUmV2UY8HknuzSEtxTrk+ZSxzeKVVV7gS3Uqg8TtNJWnPIG5UO9tfngIS d4qkrk+WPIxv/iwAxl+ea31UeGCowh4lATGENS5/pa8l5pctbLUyKmNrhFRAjXWiYUleMTgYgBBmz mYLiyZAFskrA6fStM2a6AjYIHQlKsSeto38Rvn5iEbQCLPBAaN0zaGdky/Ie4V8y5ZexP4T7lF2Pp b78c1M6Aw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eZgZg-0003ZD-CC; Thu, 11 Jan 2018 17:23:32 +0000 Received: from vern.gendns.com ([206.190.152.46]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eZgZb-0003Sz-Nb for linux-arm-kernel@lists.infradead.org; Thu, 11 Jan 2018 17:23:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=e1JtwWT8YeZ7xEOtj0bulFVXZ5TeHFCjpo/Cjah1tqE=; b=NPLPrc6I6Lrt07X5ObycuGaupr bhR2COPduBYGWT+4QUx5ex5MrR1gkWmDj03DBWlR8RgcnexaV2el18ALqI3Tg4bKctd8ESS7G3x3+ T+ksNTwSPryITVYa2LVyNXG+1qcWQgzp/Onkwrvq4FkDOOKGDlMnudwgEcTNMP6ry5dgLQbhAH/b9 UZPWoG5iOV3l1UH1A1OMeOWBVrbIOYBMhf8gmpBvamNiFvWmYWGAGaBUjG9+MqUJ+OaYviPhXeCza BRlnomSF0OJoYHkhK4XdP1m0cGDi+f/p6g+fzN2NMyMVpC1wCv80PwvG+8XT7Mfa6LSDfqj4mOYlP exGONtHA==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:60662 helo=[192.168.0.134]) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1eZgYU-002m1d-1r; Thu, 11 Jan 2018 12:22:18 -0500 Subject: Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks To: Adam Ford References: <1515377863-20358-1-git-send-email-david@lechnology.com> <1515377863-20358-2-git-send-email-david@lechnology.com> <22409e49-5c14-4068-b137-7535afaf90d7@lechnology.com> <0f90b5f7-f21e-5f81-1154-9a815bbb786d@ti.com> <5aacc350-6236-2e4f-35bb-a681fc9d47e7@ti.com> From: David Lechner Message-ID: <40501635-6f5b-20c9-f8bc-d17e26b58426@lechnology.com> Date: Thu, 11 Jan 2018 11:22:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180111_092327_791836_3F783814 X-CRM114-Status: GOOD ( 27.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Kevin Hilman , Sekhar Nori , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, Rob Herring , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 01/11/2018 06:45 AM, Adam Ford wrote: > On Wed, Jan 10, 2018 at 8:50 PM, David Lechner wrote: >> On 01/10/2018 04:24 PM, Adam Ford wrote: >>> >>> >>> I am available tomorrow to build and test patches against the >>> da850-evm. I just need to know which version(s) to test. >> >> >> Great. As per the cover letter: >> >> You can find a working branch with everything included in the >> "common-clk-v5" >> branch of https://github.com/dlech/ev3dev-kernel.git. > > I wasn't sure if things had changed after some of the dialog about the > bindings and device tree. Not yet. ;-) > > Here is my log with DEBUG_LL and CONFIG_EARLY_PRINTK set : > > Starting kernel ... > > Uncompressing Linux... done, booting the kernel. > Booting Linux on physical CPU 0x0 > Linux version 4.15.0-rc4-g8564e0f (aford@ubuntu16) (gcc version 7.2.0 > (Buildroot 2017.11.1-00021-g7b43660)) #2 PREEMPT Thu Jan 11 06:35:29 > CST 2018 > CPU: ARM926EJ-S [41069265] revision 5 (ARMv5TEJ), cr=0005317f > CPU: VIVT data cache, VIVT instruction cache > OF: fdt: Machine model: DA850/AM1808/OMAP-L138 EVM OK, using device tree... > Memory policy: Data cache writethrough > cma: Reserved 16 MiB at 0xc2c00000 > DaVinci da850/omap-l138 variant 0x0 > random: fast init done > Built 1 zonelists, mobility grouping on. Total pages: 16256 > Kernel command line: console=ttyS2,115200n8 root=PARTUUID= rw > rootfstype=ext4 rootwait > Dentry cache hash table entries: 8192 (order: 3, 32768 bytes) > Inode-cache hash table entries: 4096 (order: 2, 16384 bytes) > Memory: 42164K/65536K available (4548K kernel code, 280K rwdata, 1044K > rodata, 232K init, 143K bss, 6988K reserved, 16384K cma-reserved) > Virtual kernel memory layout: > vector : 0xffff0000 - 0xffff1000 ( 4 kB) > fixmap : 0xffc00000 - 0xfff00000 (3072 kB) > vmalloc : 0xc4800000 - 0xff800000 ( 944 MB) > lowmem : 0xc0000000 - 0xc4000000 ( 64 MB) > modules : 0xbf000000 - 0xc0000000 ( 16 MB) > .text : 0x(ptrval) - 0x(ptrval) (4550 kB) > .init : 0x(ptrval) - 0x(ptrval) ( 232 kB) > .data : 0x(ptrval) - 0x(ptrval) ( 281 kB) > .bss : 0x(ptrval) - 0x(ptrval) ( 144 kB) > SLUB: HWalign=32, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 > Preemptible hierarchical RCU implementation. > Tasks RCU enabled. > NR_IRQS: 245 > clocksource: timer0_1: mask: 0xffffffff max_cycles: 0xffffffff, > max_idle_ns: 79635851949 ns > sched_clock: 32 bits at 24MHz, resolution 41ns, wraps every > 89478484971ns > Console: colour dummy device 80x30 > Calibrating delay loop... 148.88 BogoMIPS (lpj=744448) > pid_max: default: 32768 minimum: 301 > Mount-cache hash table entries: 1024 (order: 0, 4096 bytes) > Mountpoint-cache hash table entries: 1024 (order: 0, 4096 bytes) > CPU: Testing write buffer coherency: ok > Setting up static identity map for 0xc0008400 - 0xc0008458 > Hierarchical SRCU implementation. > devtmpfs: initialized > clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, > max_idle_ns: 19112604462750000 ns > futex hash table entries: 256 (order: -1, 3072 bytes) > pinctrl core: initialized pinctrl subsystem > NET: Registered protocol family 16 > DMA: preallocated 256 KiB pool for atomic coherent allocations > cpuidle: using governor menu > mux: initialized RTC_ALARM > mux: Setting register RTC_ALARM > mux: PINMUX0 (0x00000000) = 0x44080000 -> 0x24080000 > edma 1c00000.edma: memcpy is disabled > edma 1c00000.edma: TI EDMA DMA engine driver > edma 1e30000.edma: memcpy is disabled > edma 1e30000.edma: TI EDMA DMA engine driver > i2c_davinci 1c22000.i2c: could not find pctldev for node > /soc@1c00000/pinmux@14120/pinmux_i2c0_pins, deferring probe > clocksource: Switched to clocksource timer0_1 > NET: Registered protocol family 2 > TCP established hash table entries: 1024 (order: 0, 4096 bytes) > TCP bind hash table entries: 1024 (order: 0, 4096 bytes) > TCP: Hash tables configured (established 1024 bind 1024) > UDP hash table entries: 256 (order: 0, 4096 bytes) > UDP-Lite hash table entries: 256 (order: 0, 4096 bytes) > NET: Registered protocol family 1 > RPC: Registered named UNIX socket transport module. > RPC: Registered udp transport module. > RPC: Registered tcp transport module. > RPC: Registered tcp NFSv4.1 backchannel transport module. > Initialise system trusted keyrings > workingset: timestamp_bits=30 max_order=14 bucket_order=0 > Key type asymmetric registered > Asymmetric key parser 'x509' registered > Block layer SCSI generic (bsg) driver version 0.4 loaded (major 251) > io scheduler noop registered (default) > io scheduler mq-deadline registered > io scheduler kyber registered > pinctrl-single 1c14120.pinmux: 160 pins at pa fdfe34a6 size 80 > Serial: 8250/16550 driver, 3 ports, IRQ sharing disabled > 1c42000.serial: ttyS0 at MMIO 0x1c42000 (irq = 25, base_baud = > 9375000) is a TI DA8xx/66AK2x > 1d0c000.serial: ttyS1 at MMIO 0x1d0c000 (irq = 53, base_baud = > 8250000) is a TI DA8xx/66AK2x > 1d0d000.serial: ttyS2 at MMIO 0x1d0d000 (irq = 61, base_baud = > 8250000) is a TI DA8xx/66AK2x > console [ttyS2] enabled If you are getting to this point, you probably don't need DEBUG_LL. It looks like "earlyprint" is not being passed to the command line anyway, so CONFIG_EARLY_PRINTK is not actually doing anything. > brd: module loaded > libphy: Fixed MDIO Bus: probed > davinci_mdio 1e24000.mdio: failed to get device clock > davinci_mdio: probe of 1e24000.mdio failed with error -2 It looks like this needs a clock-names property in the device tree. Please make this change and try again: > i2c /dev entries driver > davinci_mmc 1c40000.mmc: Using DMA, 4-bit mode > NET: Registered protocol family 10 > Segment Routing with IPv6 > sit: IPv6, IPv4 and MPLS over IPv4 tunneling driver > NET: Registered protocol family 17 > Loading compiled-in X.509 certificates > mmc0: host does not support reading read-only switch, assuming > write-enable > mmc0: new high speed SDHC card at address b368 > mmcblk0: mmc0:b368 00000 3.75 GiB > mmcblk0: p1 p2 > pca953x 0-0020: 0-0020 supply vcc not found, using dummy regulator > pca953x 0-0020: failed reading register > pca953x: probe of 0-0020 failed with error -121 I'm not sure why there is an error here. I'm using I2C0 on my board, so I am fairly confident that it is not a problem introduced by this series. > console [netcon0] enabled > netconsole: network logging started > davinci_emac 1e20000.ethernet: incompatible machine/device type for > reading mac address > hctosys: unable to open rtc device (rtc0) > What is normally the next line after this in a working boot? Also please try passing "clk_ignore_unused" to the kernel command line. diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 08a9817..fd3e316 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -713,6 +713,7 @@ #size-cells = <0>; reg = <0x224000 0x1000>; clocks = <&psc1 5>; + clock-names = "fck"; status = "disabled"; }; eth0: ethernet@220000 {