| Message ID | 44269c08e2a5d75b03ded87d2eb11621762d8249.1577636223.git.robin.murphy@arm.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 3433bdf98d8e9dd923118577dc582216a143e60d |
| Headers | show |
| Series | arm64: dts: rockchip: Fix IR on Beelink A1 | expand |
Am Sonntag, 29. Dezember 2019, 18:48:05 CET schrieb Robin Murphy: > Apparently I wasn't paying enough attention... And nor is the lazy > test of `cat /dev/lirc0` sufficiently blunder-proof. Oh well, with > the correct polarity, let's also hook up a keymap now that one for > the standard Beelink remote has handily appeared. > > Signed-off-by: Robin Murphy <robin.murphy@arm.com> > --- applied for 5.6 Thanks Heiko
On 2019-12-31 11:50 am, Heiko Stuebner wrote: > Am Sonntag, 29. Dezember 2019, 18:48:05 CET schrieb Robin Murphy: >> Apparently I wasn't paying enough attention... And nor is the lazy >> test of `cat /dev/lirc0` sufficiently blunder-proof. Oh well, with >> the correct polarity, let's also hook up a keymap now that one for >> the standard Beelink remote has handily appeared. >> >> Signed-off-by: Robin Murphy <robin.murphy@arm.com> >> --- > > applied for 5.6 Thanks Heiko - although if you have any other fixes to send for 5.5 do you think this might be able to sneak in too? Someone mentioned on IRC that unlike mine, their box wouldn't even generate interrupts with the polarity backwards. Cheers, Robin.
Hi Robin, Am Mittwoch, 1. Januar 2020, 14:01:32 CET schrieb Robin Murphy: > On 2019-12-31 11:50 am, Heiko Stuebner wrote: > > Am Sonntag, 29. Dezember 2019, 18:48:05 CET schrieb Robin Murphy: > >> Apparently I wasn't paying enough attention... And nor is the lazy > >> test of `cat /dev/lirc0` sufficiently blunder-proof. Oh well, with > >> the correct polarity, let's also hook up a keymap now that one for > >> the standard Beelink remote has handily appeared. > >> > >> Signed-off-by: Robin Murphy <robin.murphy@arm.com> > >> --- > > > > applied for 5.6 > > Thanks Heiko - although if you have any other fixes to send for 5.5 do > you think this might be able to sneak in too? Someone mentioned on IRC > that unlike mine, their box wouldn't even generate interrupts with the > polarity backwards. I've moved the patch over to a shiny new fixes branch for 5.5 now :-) Heiko
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts index 76b49f573101..16f1656d5203 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts @@ -49,7 +49,8 @@ ir-receiver { compatible = "gpio-ir-receiver"; - gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_HIGH>; + gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>; + linux,rc-map-name = "rc-beelink-gs1"; }; };
Apparently I wasn't paying enough attention... And nor is the lazy test of `cat /dev/lirc0` sufficiently blunder-proof. Oh well, with the correct polarity, let's also hook up a keymap now that one for the standard Beelink remote has handily appeared. Signed-off-by: Robin Murphy <robin.murphy@arm.com> --- arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)