From patchwork Fri Jul 6 04:56:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinya Kuribayashi X-Patchwork-Id: 1162821 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 7D6E5DF236 for ; Fri, 6 Jul 2012 05:06:25 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Sn0h7-0006zV-L1; Fri, 06 Jul 2012 05:03:05 +0000 Received: from relmlor4.renesas.com ([210.160.252.174]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Sn0fx-0006sb-1g for linux-arm-kernel@lists.infradead.org; Fri, 06 Jul 2012 05:01:53 +0000 Received: from relmlir4.idc.renesas.com ([10.200.68.154]) by relmlor4.idc.renesas.com ( SJSMS) with ESMTP id <0M6Q00JJK326YB00@relmlor4.idc.renesas.com> for linux-arm-kernel@lists.infradead.org; Fri, 06 Jul 2012 13:56:30 +0900 (JST) Received: from relmlac3.idc.renesas.com ([10.200.69.23]) by relmlir4.idc.renesas.com ( SJSMS) with ESMTP id <0M6Q00FGI3269QB0@relmlir4.idc.renesas.com> for linux-arm-kernel@lists.infradead.org; Fri, 06 Jul 2012 13:56:30 +0900 (JST) Received: by relmlac3.idc.renesas.com (Postfix, from userid 0) id 5AD281809C; Fri, 06 Jul 2012 13:56:30 +0900 (JST) Received: from relmlac3.idc.renesas.com (localhost [127.0.0.1]) by relmlac3.idc.renesas.com (Postfix) with ESMTP id 5584418098; Fri, 06 Jul 2012 13:56:30 +0900 (JST) Received: from relmlii2.idc.renesas.com [10.200.68.66] by relmlac3.idc.renesas.com with ESMTP id PAC16663; Fri, 06 Jul 2012 13:56:30 +0900 X-IronPort-AV: E=Sophos; i="4.77,536,1336316400"; d="scan'208"; a="89268345" Received: from unknown (HELO [10.161.69.127]) ([10.161.69.127]) by relmlii2.idc.renesas.com with ESMTP; Fri, 06 Jul 2012 13:56:30 +0900 Message-id: <4FF66FFE.2020803@renesas.com> Date: Fri, 06 Jul 2012 13:56:30 +0900 From: Shinya Kuribayashi User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-version: 1.0 To: ohad@wizery.com Subject: [PATCH 2/3] hwspinlock/core: add notes on lock element in 'struct hwspinlock' References: <4FF66FBD.5090601@renesas.com> In-reply-to: <4FF66FBD.5090601@renesas.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'lock' must be placed at the end of struct hwspinlock_device because we're doing 'hwlock = &bank->lock[0]' to get a pointer to the first 'struct hwspinlock' instance. Signed-off-by: Shinya Kuribayashi --- drivers/hwspinlock/hwspinlock_internal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hwspinlock/hwspinlock_internal.h b/drivers/hwspinlock/hwspinlock_internal.h index d26f78b..c60318c 100644 --- a/drivers/hwspinlock/hwspinlock_internal.h +++ b/drivers/hwspinlock/hwspinlock_internal.h @@ -57,7 +57,8 @@ struct hwspinlock { * @ops: platform-specific hwspinlock handlers * @base_id: id index of the first lock in this device * @num_locks: number of locks in this device - * @lock: dynamically allocated array of 'struct hwspinlock' + * @lock: dynamically allocated array of 'struct hwspinlock' (must be placed + * at the end of the hwspinlock_device) */ struct hwspinlock_device { struct device *dev;