| Message ID | 4d489d040ec1fc3821d8e4bf31ffcc2eebfa41e1.1518166039.git.viresh.kumar@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Feb 09, 2018 at 02:28:04PM +0530, Viresh Kumar wrote: > The "cooling-min-level" and "cooling-max-level" properties are not > parsed by any part of the kernel currently and the max cooling state of > a CPU cooling device is found by referring to the cpufreq table instead. > > Remove the unused properties from the CPU nodes. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Applied, thanks! Maxime
On Tue, Feb 13, 2018 at 5:13 PM, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > On Fri, Feb 09, 2018 at 02:28:04PM +0530, Viresh Kumar wrote: >> The "cooling-min-level" and "cooling-max-level" properties are not >> parsed by any part of the kernel currently and the max cooling state of >> a CPU cooling device is found by referring to the cpufreq table instead. That doesn't mean that other systems aren't using it. It's still part of the device tree binding. Last I checked, while they are optional, they aren't deprecated. Any comments from the device tree maintainers? >> >> Remove the unused properties from the CPU nodes. >> >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > Applied, thanks! > Maxime > > -- > Maxime Ripard, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > http://bootlin.com
On 13-02-18, 17:18, Chen-Yu Tsai wrote: > On Tue, Feb 13, 2018 at 5:13 PM, Maxime Ripard > <maxime.ripard@bootlin.com> wrote: > > On Fri, Feb 09, 2018 at 02:28:04PM +0530, Viresh Kumar wrote: > >> The "cooling-min-level" and "cooling-max-level" properties are not > >> parsed by any part of the kernel currently and the max cooling state of > >> a CPU cooling device is found by referring to the cpufreq table instead. > > That doesn't mean that other systems aren't using it. Are you aware of any systems which are using them ? > It's still part of > the device tree binding. Last I checked, while they are optional, they > aren't deprecated. Yeah, it isn't deprecated yet. Though the last patches of this series tries to do something similar. > Any comments from the device tree maintainers? None yet.
diff --git a/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts b/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts index 49247fbe6acd..e3d1d0f63caf 100644 --- a/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts +++ b/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts @@ -97,7 +97,6 @@ 864000 1300000 624000 1250000 >; - cooling-max-level = <2>; }; &de { diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi index 4f2f2eea0755..77e8436beed4 100644 --- a/arch/arm/boot/dts/sun4i-a10.dtsi +++ b/arch/arm/boot/dts/sun4i-a10.dtsi @@ -123,8 +123,6 @@ 624000 1250000 >; #cooling-cells = <2>; - cooling-min-level = <0>; - cooling-max-level = <3>; }; }; diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi index 4e830f5cb7f1..b1d827765530 100644 --- a/arch/arm/boot/dts/sun5i-a13.dtsi +++ b/arch/arm/boot/dts/sun5i-a13.dtsi @@ -116,8 +116,6 @@ 432000 1200000 >; #cooling-cells = <2>; - cooling-min-level = <0>; - cooling-max-level = <5>; }; &pio { diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi index 72d3fe44ecaf..c72992556a86 100644 --- a/arch/arm/boot/dts/sun6i-a31.dtsi +++ b/arch/arm/boot/dts/sun6i-a31.dtsi @@ -113,8 +113,6 @@ 480000 1000000 >; #cooling-cells = <2>; - cooling-min-level = <0>; - cooling-max-level = <3>; }; cpu@1 { diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index bd0cd3204273..a3a6ce489fda 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -116,8 +116,6 @@ 144000 1000000 >; #cooling-cells = <2>; - cooling-min-level = <0>; - cooling-max-level = <6>; }; cpu@1 {
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead. Remove the unused properties from the CPU nodes. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 1 - arch/arm/boot/dts/sun4i-a10.dtsi | 2 -- arch/arm/boot/dts/sun5i-a13.dtsi | 2 -- arch/arm/boot/dts/sun6i-a31.dtsi | 2 -- arch/arm/boot/dts/sun7i-a20.dtsi | 2 -- 5 files changed, 9 deletions(-)