From patchwork Tue Nov 5 10:29:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Vaittinen, Matti" X-Patchwork-Id: 11227457 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4D8E816B1 for ; Tue, 5 Nov 2019 10:29:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 225D32190F for ; Tue, 5 Nov 2019 10:29:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YT+I+o2c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 225D32190F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IE90R+NHOBN68OQpWMgxOu/effyl4QiXmUxjk4Xcg70=; b=YT+I+o2cfX8wcG drkhl97bsCsOPM2PwpPLthoVso1WLRG2b3OeWh4Ik9iKRbIlTzEj1SM4WVTlG1ou56OL40MisD0My EFQjUWMmNMTvLc8AhdWGVMjVa51sXKRPz/KbVRxEzIArDkJy0B8uymGB1GcSOXaM3DMFBsyonekl0 BZhJ/QUDyCP8oozbMPyWeJZJC5zFJa8g74acVxqtJLiTm0/bzLrhapODQxYOptCse3MpanFzS/hMO ZVfw8bo5QG0RyRLHV3C8ZRfc08u65VPHrh4Ry2EWVsqWWLOjF0Q3y/6m/CX17VuDzwQfVBsae7vfJ XhXTSskGZBC9J6Qa5WmQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRw5t-0003MH-PR; Tue, 05 Nov 2019 10:29:49 +0000 Received: from mail-lj1-f193.google.com ([209.85.208.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRw5r-0003Lt-H5 for linux-arm-kernel@lists.infradead.org; Tue, 05 Nov 2019 10:29:48 +0000 Received: by mail-lj1-f193.google.com with SMTP id t5so21210165ljk.0 for ; Tue, 05 Nov 2019 02:29:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=T/zJmmC9BfN7o1sqvqhhANQRkLvNhk04+tink2hcu/o=; b=iz4ks55rkA3o2gyB8g8BNneK9QacBGyZhe2jN7AmO9cwTjN4mTXgGDAoTfEte/iOD1 UvEO4w3RGSQc6ImpVB2w7o0RpeWDdCSeBrx38WKe5kxyDO/7E/Ib0HyCIAYHROmrM82B 2qg+lE5mBBjCfRZFR48ZuV7/+3mgjjE1dAiQ6KdSCdsbdc39Elv2ld/i1n9eCIOQhwN1 MgcWEI/1ugJI0G3gLkKGvwAXAjGhvrkelQFn+z5FOpOXMapxaKaYxJjQy1vKwmlEy/zD gvEMBk4tsmVQV3Mmfva7BnXlw38ZVmupTPLMoA4lUROnrm5SMns8EsqCXUpcmFbqOqQy 5krw== X-Gm-Message-State: APjAAAUZhKSoF09R+cNeeqQWnlaQYWXsiF8iDkOkJX7mULPE82OPMe6E Rhjb4ky7SfmShx3Dbsu8oFs= X-Google-Smtp-Source: APXvYqwAiLmM1AWBNWgvSloHZxacz7vhjYQV56y3Fw7fttafgeaQyw/oMgcvECS8UnmExC/IFeNwWQ== X-Received: by 2002:a2e:874a:: with SMTP id q10mr23012443ljj.14.1572949785377; Tue, 05 Nov 2019 02:29:45 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id s7sm8246972ljo.98.2019.11.05.02.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:29:44 -0800 (PST) Date: Tue, 5 Nov 2019 12:29:36 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Subject: [PATCH 37/62] gpio: gpio-sama5d2-piobu: Use new GPIO_LINE_DIRECTION Message-ID: <4e20b399f7ef56a7df25f97a86b4e89e131083d0.1572945890.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191105_022947_564066_0B597A34 X-CRM114-Status: GOOD ( 11.96 ) X-Spam-Score: 0.3 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.193 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (mazziesaccount[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.193 listed in wl.mailspike.net] 0.1 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, Bartosz Golaszewski , Ludovic Desroches , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-sama5d2-piobu.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-sama5d2-piobu.c b/drivers/gpio/gpio-sama5d2-piobu.c index 7d718557092e..b04c561f3280 100644 --- a/drivers/gpio/gpio-sama5d2-piobu.c +++ b/drivers/gpio/gpio-sama5d2-piobu.c @@ -119,7 +119,8 @@ static int sama5d2_piobu_get_direction(struct gpio_chip *chip, if (ret < 0) return ret; - return (ret == PIOBU_IN) ? 1 : 0; + return (ret == PIOBU_IN) ? GPIO_LINE_DIRECTION_IN : + GPIO_LINE_DIRECTION_OUT; } /** @@ -154,9 +155,9 @@ static int sama5d2_piobu_get(struct gpio_chip *chip, unsigned int pin) /* if pin is input, read value from PDS else read from SOD */ int ret = sama5d2_piobu_get_direction(chip, pin); - if (ret == 1) + if (ret == GPIO_LINE_DIRECTION_IN) ret = sama5d2_piobu_read_value(chip, pin, PIOBU_PDS); - else if (!ret) + else if (ret == GPIO_LINE_DIRECTION_OUT) ret = sama5d2_piobu_read_value(chip, pin, PIOBU_SOD); if (ret < 0)