From patchwork Fri Apr 20 10:50:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 10352459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7B444602B1 for ; Fri, 20 Apr 2018 10:52:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B4C428619 for ; Fri, 20 Apr 2018 10:52:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5FD362864A; Fri, 20 Apr 2018 10:52:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E5B6728619 for ; Fri, 20 Apr 2018 10:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OWjj8zf/D1NFMW5tyOEWAHcmsMZa2Q7Wf0x66dETbU4=; b=ExyAoFGC+Bx8ix PMEBeiyBhoO1PKBjKlelJifJ+UkeR2UgH2A6IWejWWaNZkvVCRLaxd9G6cdFL4ZJFtFagiTZ1D52c Aoe8N6zikTh14rj3mpoDos5Gonwc5S+73ql8IySRptgGZYcTOeBx6IKvDkJ4ZhpzxECj7nyHwYwEx nLHrprwLoDqLWJjUxerdxN4YGtyuskw1wKW99W+StWFNAoOLC3NNa6K9klSB2QFKQtTVbH6T7II1U eNZ02R4f7HO6vaYPWEmRviKD+89x8qkrCdJudEr4cwkEAz1D5WppQEd8I5uS8TrDJFMU5fcsqBI0H 5HrRnh/1VstCuvnzXJfA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f9Te7-000650-VL; Fri, 20 Apr 2018 10:52:04 +0000 Received: from mail-lf0-f51.google.com ([209.85.215.51]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f9TcZ-0004aT-8o for linux-arm-kernel@lists.infradead.org; Fri, 20 Apr 2018 10:50:51 +0000 Received: by mail-lf0-f51.google.com with SMTP id d20-v6so4538245lfe.3 for ; Fri, 20 Apr 2018 03:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5K3rLB44zAqbILhgeA71LjbcfqNzPBY2VoWvKfQt4NE=; b=O9XbE9YmjYF9TbWzfgV1NF1rf0ThxkTWbuAuZ9EaXTFLF0wFSSYASzQ5i4/haIshTb OKIt1c1m5N1gW4ec+TpCaWph7R8ICpwkqi4UwYneISJdULlyWRGWTi7pEfQjZjHmpfCM 9c7dMSKKD8gihjkMUM1FAqRlzD6RD4Idh+mo3ZFbW3qUHtrV8dfh2rW/cOaOZbaLt6Cu 8mqEUnEYwjInWCBE0ktKuDXcsgVfv8+lfkATMwc34GPPwsYcBtz3I/QKJ8RGBbLeKJDM 3yyc5yhhcFG6XgNN7s5s62q2uGjb073MY3NuS0YIVMsKC4rDLvHFIOfuHPOjkMp75Eu1 Z6xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=5K3rLB44zAqbILhgeA71LjbcfqNzPBY2VoWvKfQt4NE=; b=unF0JEodE6hFzwzLeABrdnW0YBqVE2FIE3ayRrV8VpOF31x87hXTescSsR0nIxpA8G X7orPPBuxHfDiAg6WhIjSNhIfPvG4wsN7uUBp8ybuUMSK0hXbgUazj2VyKfrprA18Bjq MOBTouAKlGmaS9ZepmVYUbBVJaKPS4WbSGU8u6S4HH7wBkmw+kXXYTuBtiOAzICvmv5G DiXzNzmQgCOsX6RqI/TIRMiibLMbLi+/KSSGtbyYHwCO8tqKulSOy6+iJ4tsjtn2Lxc7 /o0ua1JLUu3DG0jJWhQnaBchM2mdGlvQXgJad5aMeY5aOKUg+w17IIVBl+3DLPo3oq61 JiUQ== X-Gm-Message-State: ALQs6tA9HERp1f38SyWyaktb23i7/LG7/eti9AJFIN/L+gcuIT8/dYi1 b2Er0CjR2ctEQzkv+jLBZOWCa0dZ X-Google-Smtp-Source: AB8JxZqa7DsozSFDSDxif1RCdGL8jXSra1bdI3RWMOC3qJ0Oj3Ixtw0MtLNVJ1vORq87Q5Arln16Pw== X-Received: by 2002:a19:4813:: with SMTP id v19-v6mr2312053lfa.63.1524221412833; Fri, 20 Apr 2018 03:50:12 -0700 (PDT) Received: from [192.168.1.145] (ppp109-252-91-130.pppoe.spdop.ru. [109.252.91.130]) by smtp.googlemail.com with ESMTPSA id z19sm1010542ljz.1.2018.04.20.03.50.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Apr 2018 03:50:12 -0700 (PDT) Subject: Re: [PATCH] ARM: tegra: fix ulpi regression on tegra20 To: Marc Dietrich , Marcel Ziswiler References: <20180219151252.29289-1-marcel@ziswiler.com> <6600596.BijQW1iq1K@ax5200p> From: Dmitry Osipenko Openpgp: preference=signencrypt Autocrypt: addr=digetx@gmail.com; prefer-encrypt=mutual; keydata= xsBNBFpX5TwBCADQhg+lBnTunWSPbP5I+rM9q6EKPm5fu2RbqyVAh/W3fRvLyghdb58Yrmjm KpDYUhBIZvAQoFLEL1IPAgJBtmPvemO1XUGPxfYNh/3BlcDFBAgERrI3BfA/6pk7SAFn8u84 p+J1TW4rrPYcusfs44abJrn8CH0GZKt2AZIsGbGQ79O2HHXKHr9V95ZEPWH5AR0UtL6wxg6o O56UNG3rIzSL5getRDQW3yCtjcqM44mz6GPhSE2sxNgqureAbnzvr4/93ndOHtQUXPzzTrYB z/WqLGhPdx5Ouzn0Q0kSVCQiqeExlcQ7i7aKRRrELz/5/IXbCo2O+53twlX8xOps9iMfABEB AAHNIkRtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT7CwJQEEwEIAD4WIQSczHcO 3uc4K1eb3yvTNNaPsNRzvAUCWlflPAIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIX gAAKCRDTNNaPsNRzvFjTCACqAh1M9/YPq73/ai5h2ExDquTgJnjegL8KL2yHL3G+XINwzN5E nPI7esoYm+zVWDJbv3UuRqylpookLNSRA01yyvkaMcipB/B128UnqmUiGRqezj9QE20yIauo uHRuwHPE2q+UkfUhRX9iuOaEyQtZDiCa0myMjmRkJ+Z8ZetclEPG8dYZu47w04phuMlu1QAt a0gkZOaMKvXgj21ushALS6nYnvm7HiIPQXfnEXThartatRvFdmbG4PCn0IoICkQBizwJtXrL HEjELIFap0M8krVJlUoZTFaZnaZkGpUDWikeFtAuie2KuIxmVBYPM4X7pM3eP3AVvIPGS7EE UUFuzsBNBFpX5TwBCADFNDou220thijaLLGaQsebWjzc/gPRxMixIpk856MRyRaQin+IbGD6 YskMb5ZSD3nS88LIKNfY4MMH0LwfYztI++ICG2vdFLkbBt78E+LqEa+kZ9072l4W5KO3mWQo +jMfxXbpgGlc7iuEReDgl8iyZ27r51kSW665CYvvu2YJhLqgdj6QM1lN2D1UnhEhkkU+pRAj 1rJVOxdfJaQNQS4+204p3TrURovzNGkN/brqakpNIcqGOAGQqb8F0tuwwuP7ERq/BzDNkbdr qJOrVC/wkHRq1jfabQczWKf8MwYOvivR3HY8d3CpSQxmUXDtdOWfg0XGm1dxYnVfqPjuJaZt ABEBAAHCwHwEGAEIACYWIQSczHcO3uc4K1eb3yvTNNaPsNRzvAUCWlflPAIbDAUJA8JnAAAK CRDTNNaPsNRzvJzuB/9d+sxcwHbO8ZDcgaLX9N+bXFqN9fIRVmBUyWa+qqTSREA4uVAtYcRT lfPE2OQ7aMFxaYPwo+/z5SLpu8HcEhN/FG9uIkfYwK0mdCO0vgvlfvBJm4VHe7C6vyAeEPJQ DKbBvdgeqFqO+PsLkk2sawF/9sontMJ5iFfjNDj4UeAo4VsdlduTBZv5hHFvIbv/p7jKH6OT 90FsgUSVbShh7SH5OzAcgqSy4kxuS1AHizWo6P3f9vei987LZWTyhuEuhJsOfivDsjKIq7qQ c5eR+JJtyLEA0Jt4cQGhpzHtWB0yB3XxXzHVa4QUp00BNVWyiJ/t9JHT4S5mdyLfcKm7ddc9 Message-ID: <4f2ac009-8618-4b4d-e137-a5fd4907a56f@gmail.com> Date: Fri, 20 Apr 2018 13:50:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <6600596.BijQW1iq1K@ax5200p> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180420_035027_485366_FD41718C X-CRM114-Status: GOOD ( 27.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Marcel Ziswiler , linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Thierry Reding , linux-tegra@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 20.04.2018 11:52, Marc Dietrich wrote: > Hi Marcel, > > Am Montag, 19. Februar 2018, 16:12:52 CEST schrieb Marcel Ziswiler: >> From: Marcel Ziswiler >> >> Since commit f8f8f1d04494 ("clk: Don't touch hardware when reparenting >> during registration") ULPI has been broken on Tegra20 leading to the >> following error message during boot: >> >> [ 1.974698] ulpi_phy_power_on: ulpi write failed >> [ 1.979384] tegra-ehci c5004000.usb: Failed to power on the phy >> [ 1.985434] tegra-ehci: probe of c5004000.usb failed with error -110 >> >> Debugging through the changes and finally also consulting the TRM >> revealed that rather than the CDEV2 clock off OSC requiring such pin >> muxing actually the PLL_P_OUT4 clock is in use. It looks like so far it >> just worked by chance of that one having been enabled which Stephen's >> commit now changed when reparenting sclk away from pll_p_out4 leaving >> that one disabled. Fix this by properly assigning the PLL_P_OUT4 clock >> as the ULPI PHY clock. > > I booted 4.17-rc1 (which includes this fix) on an AC100 (T20 paz00 board) and > the error above is still there. Surprisingly the error vanishes when I revert > your patch. So this patch actually *causes* the problem above on my board. > Could it be, that we need all four clocks? Dimitry mentioned on IRC that it > could also be a problem in the clock init table. I don't have the technical > background myself to fix it, but I still wonder what could be so different > between TrimSlice and AC100. I managed to find CDEV clocks in TRM this time. Seems assigning CDEV2 clock to "ulpi-link" was correct and both CDEV2 and PLL_P_OUT4 should be enabled, CDEV2 should gate the PLL_P_OUT4 that feeds USB HW and PLL_P_OUT4 should be always-enabled because it is enabled by init_table, but apparently it is getting disabled erroneously. Marcel, could you please revert your patch, add "trace_event=clk_enable,clk_disable,clk_set_parent tp_printk" to kernels cmdline and post the log? It looks like there is some clk framework bug, but just in case please also try to apply this patch: *dt_clk = clk; diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c index 2acba2986bc6..407bd0c0ac2f 100644 --- a/drivers/clk/tegra/clk-tegra-periph.c +++ b/drivers/clk/tegra/clk-tegra-periph.c @@ -1024,7 +1024,7 @@ static void __init init_pllp(void __iomem *clk_base, void __iomem *pmc_base, if (dt_clk) { clk = tegra_clk_register_pll_out("pll_p_out4", "pll_p_out4_div", clk_base + PLLP_OUTB, - 17, 16, CLK_IGNORE_UNUSED | + 17, 16, CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0, &PLLP_OUTB_lock);