From patchwork Thu Sep 20 06:40:08 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory CLEMENT X-Patchwork-Id: 1482561 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 42F003FD40 for ; Thu, 20 Sep 2012 06:42:27 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TEaR4-0000Ga-G8; Thu, 20 Sep 2012 06:40:30 +0000 Received: from mail.free-electrons.com ([88.190.12.23]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TEaR0-0000GB-Oy for linux-arm-kernel@lists.infradead.org; Thu, 20 Sep 2012 06:40:27 +0000 Received: by mail.free-electrons.com (Postfix, from userid 106) id 40A83188; Thu, 20 Sep 2012 08:39:41 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham version=3.3.1 Received: from [192.168.1.41] (17.Red-217-126-98.staticIP.rima-tde.net [217.126.98.17]) by mail.free-electrons.com (Postfix) with ESMTPA id 95532143; Thu, 20 Sep 2012 08:39:25 +0200 (CEST) Message-ID: <505ABA48.1090208@free-electrons.com> Date: Thu, 20 Sep 2012 08:40:08 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: Russell King - ARM Linux Subject: Re: [PATCH V3 1/6] arm: cache-l2x0: make outer_cache_fns a field of l2x0_of_data References: <1346852677-5381-1-git-send-email-gregory.clement@free-electrons.com> <1346852677-5381-2-git-send-email-gregory.clement@free-electrons.com> <20120915203539.GK12245@n2100.arm.linux.org.uk> In-Reply-To: <20120915203539.GK12245@n2100.arm.linux.org.uk> X-Enigmail-Version: 1.4.4 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Lior Amsalem , Andrew Lunn , Ike Pan , Will Deacon , Nadav Haklai , Ian Molton , David Marlin , Yehuda Yitschak , Jani Monoses , Tawfik Bayouk , Dan Frazier , Barry Song <21cnbao@gmail.com>, Eran Ben-Avi , Li Li , Santosh Shilimkar , Leif Lindholm , Sebastian Hesselbarth , Jason Cooper , Arnd Bergmann , Jon Masters , Rob Herring , Ben Dooks , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , Chris Van Hoof , Nicolas Pitre , Maen Suleiman , Shadi Ammouri , Olof Johansson X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On 09/15/2012 10:35 PM, Russell King - ARM Linux wrote:> On Wed, Sep 05, 2012 at 03:44:32PM +0200, Gregory CLEMENT wrote: >> Instead of having multiple functions belonging to outer_cache and >> filling this structure on the fly, use a outer_cache_fns field inside >> l2x0_of_data and just memcopy it into outer_cache depending of the >> type of the l2x0 cache. For non DT case, the former code was kept. >> >> Signed-off-by: Gregory CLEMENT >> Tested-and-reviewed-by: Yehuda Yitschak >> Tested-and-reviewed-by: Lior Amsalem > > Just tried pulling this and got conflicts, so I looked a little deeper > at this. This patch advertises itself as merely changing the way > outer_cache is initialized: > >> +#ifndef CONFIG_OF >> outer_cache.inv_range = l2x0_inv_range; >> outer_cache.clean_range = l2x0_clean_range; >> outer_cache.flush_range = l2x0_flush_range; >> @@ -383,6 +384,7 @@ void __init l2x0_init(void __iomem *base, u32 aux_val, u32 aux_mask) >> outer_cache.flush_all = l2x0_flush_all; >> outer_cache.inv_all = l2x0_inv_all; >> outer_cache.disable = l2x0_disable; >> +#endif > > It disables this assignment... > >> static const struct l2x0_of_data pl310_data = { > ... >> + .outer_cache = { >> + .resume = pl310_resume, > > moves the resume here... At the end of l2x0_of_init(), resume were assigned in the outer_cache. It is the only place where this field is used.This patch introduces an outer_cache_fn field. It seemed logical to use it. I don't see where is the problem here. > >> + .inv_range = l2x0_inv_range, >> + .clean_range = l2x0_clean_range, >> + .flush_range = l2x0_flush_range, >> + .sync = l2x0_cache_sync, >> + .flush_all = l2x0_flush_all, >> + .inv_all = l2x0_inv_all, >> + .disable = l2x0_disable, > > initializes all these values that were previously set... Well if CONFIG_OF is not set then these part of the code is not compiled. The values arr not initialized here. If CONFIG_OF is set then these values are not assigned before (due to the #ifndef CONFIG_OF). > >> + .set_debug = pl310_set_debug, > > and adds one extra, which gets added because we blat over the assignment > of it in l2x0_init() after we read the ID from the device. As set_debug is also a field of outer_cache_fn field, it seemed logical to assign it here. > > Plus, doesn't this patch break systems which may enable CONFIG_OF, but > don't supply a DT file, relying on the old way to initialize the L2 cache > operations functions? Right I didn't think that we would want enable CONFIG_OF without using a DT file. But indeed it is still possible. I can replace the ifndef CONFIG_OF by a flag set in l2x0_of_init. What do you think about this, then: From 76ab86c053edd47459332665ba032ca93826f23c Mon Sep 17 00:00:00 2001 From: Gregory CLEMENT Date: Tue, 7 Aug 2012 10:39:41 +0200 Subject: [PATCH] arm: cache-l2x0: make outer_cache_fns a field of l2x0_of_data Instead of having multiple functions belonging to outer_cache and filling this structure on the fly, use a outer_cache_fns field inside l2x0_of_data and just memcopy it into outer_cache depending of the type of the l2x0 cache. For non DT case, the former code was kept. Signed-off-by: Gregory CLEMENT Tested-and-reviewed-by: Yehuda Yitschak Tested-and-reviewed-by: Lior Amsalem Cc: Barry Song <21cnbao@gmail.com> Cc: Will Deacon Cc: Santosh Shilimkar Cc: Rob Herring Cc: Arnd Bergmann Cc: Olof Johansson Signed-off-by: Gregory CLEMENT --- arch/arm/mm/cache-l2x0.c | 55 +++++++++++++++++++++++++++++++++------------- 1 file changed, 40 insertions(+), 15 deletions(-) diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c index 2a8e380..8b9c0ae 100644 --- a/arch/arm/mm/cache-l2x0.c +++ b/arch/arm/mm/cache-l2x0.c @@ -39,8 +39,9 @@ struct l2x0_regs l2x0_saved_regs; struct l2x0_of_data { void (*setup)(const struct device_node *, u32 *, u32 *); void (*save)(void); - void (*resume)(void); + struct outer_cache_fns outer_cache; }; +static bool of_init = false; static inline void cache_wait_way(void __iomem *reg, unsigned long mask) { @@ -376,13 +377,15 @@ void __init l2x0_init(void __iomem *base, u32 aux_val, u32 aux_mask) writel_relaxed(1, l2x0_base + L2X0_CTRL); } - outer_cache.inv_range = l2x0_inv_range; - outer_cache.clean_range = l2x0_clean_range; - outer_cache.flush_range = l2x0_flush_range; - outer_cache.sync = l2x0_cache_sync; - outer_cache.flush_all = l2x0_flush_all; - outer_cache.inv_all = l2x0_inv_all; - outer_cache.disable = l2x0_disable; + if (!of_init) { + outer_cache.inv_range = l2x0_inv_range; + outer_cache.clean_range = l2x0_clean_range; + outer_cache.flush_range = l2x0_flush_range; + outer_cache.sync = l2x0_cache_sync; + outer_cache.flush_all = l2x0_flush_all; + outer_cache.inv_all = l2x0_inv_all; + outer_cache.disable = l2x0_disable; + } printk(KERN_INFO "%s cache controller enabled\n", type); printk(KERN_INFO "l2x0: %d ways, CACHE_ID 0x%08x, AUX_CTRL 0x%08x, Cache size: %d B\n", @@ -533,15 +536,34 @@ static void pl310_resume(void) } static const struct l2x0_of_data pl310_data = { - pl310_of_setup, - pl310_save, - pl310_resume, + .setup = pl310_of_setup, + .save = pl310_save, + .outer_cache = { + .resume = pl310_resume, + .inv_range = l2x0_inv_range, + .clean_range = l2x0_clean_range, + .flush_range = l2x0_flush_range, + .sync = l2x0_cache_sync, + .flush_all = l2x0_flush_all, + .inv_all = l2x0_inv_all, + .disable = l2x0_disable, + .set_debug = pl310_set_debug, + }, }; static const struct l2x0_of_data l2x0_data = { - l2x0_of_setup, - NULL, - l2x0_resume, + .setup = l2x0_of_setup, + .save = NULL, + .outer_cache = { + .resume = l2x0_resume, + .inv_range = l2x0_inv_range, + .clean_range = l2x0_clean_range, + .flush_range = l2x0_flush_range, + .sync = l2x0_cache_sync, + .flush_all = l2x0_flush_all, + .inv_all = l2x0_inv_all, + .disable = l2x0_disable, + }, }; static const struct of_device_id l2x0_ids[] __initconst = { @@ -581,9 +603,12 @@ int __init l2x0_of_init(u32 aux_val, u32 aux_mask) if (data->save) data->save(); + /* */ + of_init = true; l2x0_init(l2x0_base, aux_val, aux_mask); - outer_cache.resume = data->resume; + memcpy(&outer_cache, &data->outer_cache, sizeof(outer_cache)); + return 0; } #endif