diff mbox

ARM: OMAP2+: clockdomain: Fix OMAP4 ISS clk domain to support only SWSUP

Message ID 50800679.2030202@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Benoit Cousson Oct. 18, 2012, 1:39 p.m. UTC 
From: Miguel Vadillo <vadillo@ti.com>

Since CAM domain (ISS) has no module wake-up dependency
with any other clock domain of the device and the dynamic
dependency from L3_main_2 is always disabled, the domain
needs to be in force wakeup in order to be able to access
it for configure (sysconfig) it or use it.

Also since there is no clock in the domain managed automatically
by the hardware, there is no use to configure automatic
clock domain transition. SW should keep the SW_WKUP domain
transition as long as a module in the domain is required to
be functional.

Signed-off-by: Miguel Vadillo <vadillo@ti.com>
Signed-off-by: Benoit Cousson <b-cousson@ti.com>
---

Hi Tony,

Here is a fix that Miguel sent me some time back and that I forgot until
I face the crash again while trying to enable the ISS for test.

Regards,
Benoit

 arch/arm/mach-omap2/clockdomains44xx_data.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Paul Walmsley Oct. 18, 2012, 2:41 p.m. UTC | #1 
On Thu, 18 Oct 2012, Benoit Cousson wrote:

> From: Miguel Vadillo <vadillo@ti.com>
> 
> Since CAM domain (ISS) has no module wake-up dependency
> with any other clock domain of the device and the dynamic
> dependency from L3_main_2 is always disabled, the domain
> needs to be in force wakeup in order to be able to access
> it for configure (sysconfig) it or use it.
> 
> Also since there is no clock in the domain managed automatically
> by the hardware, there is no use to configure automatic
> clock domain transition. SW should keep the SW_WKUP domain
> transition as long as a module in the domain is required to
> be functional.
> 
> Signed-off-by: Miguel Vadillo <vadillo@ti.com>
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>

Thanks queued for 3.7-rc.


- Paul
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/clockdomains44xx_data.c
b/arch/arm/mach-omap2/clockdomains44xx_data.c
index b56d06b..95192a0 100644
--- a/arch/arm/mach-omap2/clockdomains44xx_data.c
+++ b/arch/arm/mach-omap2/clockdomains44xx_data.c
@@ -359,7 +359,7 @@  static struct clockdomain iss_44xx_clkdm = {
 	.clkdm_offs	  = OMAP4430_CM2_CAM_CAM_CDOFFS,
 	.wkdep_srcs	  = iss_wkup_sleep_deps,
 	.sleepdep_srcs	  = iss_wkup_sleep_deps,
-	.flags		  = CLKDM_CAN_HWSUP_SWSUP,
+	.flags		  = CLKDM_CAN_SWSUP,
 };

 static struct clockdomain l3_dss_44xx_clkdm = {