diff mbox

[1/2] ARM: S3C64XX: Remove duplicated camera clock

Message ID 509e602f.a766980a.0f91.14f4@mx.google.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andrey Gusakov Nov. 10, 2012, 2:07 p.m. UTC 
From: Andrey Gusakov <dron_gus@mail.ru>

Camera clock defined two times. One in init_clocks_off array with
"cam" name, second in clksrcs array with "camera" name. Leave
second definition because clock have divider.

Signed-off-by: Andrey Gusakov <dron0gus@gmail.com>
---
 arch/arm/mach-s3c64xx/clock.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

Comments

Tomasz Figa Nov. 10, 2012, 3 p.m. UTC | #1 
Hi Andrey,

On Saturday 10 of November 2012 18:07:56 dron0gus@gmail.com wrote:
> From: Andrey Gusakov <dron_gus@mail.ru>
> 
> Camera clock defined two times. One in init_clocks_off array with
> "cam" name, second in clksrcs array with "camera" name. Leave
> second definition because clock have divider.
> 
> Signed-off-by: Andrey Gusakov <dron0gus@gmail.com>
> ---
>  arch/arm/mach-s3c64xx/clock.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c64xx/clock.c
> b/arch/arm/mach-s3c64xx/clock.c index cacbe45..b2d08fa 100644
> --- a/arch/arm/mach-s3c64xx/clock.c
> +++ b/arch/arm/mach-s3c64xx/clock.c
> @@ -319,10 +319,6 @@ static struct clk init_clocks_off[] = {
>  		.enable		= s3c64xx_sclk_ctrl,
>  		.ctrlbit	= S3C_CLKCON_SCLK_MFC,
>  	}, {
> -		.name		= "cam",
> -		.enable		= s3c64xx_sclk_ctrl,
> -		.ctrlbit	= S3C_CLKCON_SCLK_CAM,
> -	}, {
>  		.name		= "sclk_jpeg",
>  		.enable		= s3c64xx_sclk_ctrl,
>  		.ctrlbit	= S3C_CLKCON_SCLK_JPEG,

Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>

Best regards,
Tomasz Figa
Sylwester Nawrocki Nov. 10, 2012, 9:23 p.m. UTC | #2 
On 11/10/2012 03:07 PM, dron0gus@gmail.com wrote:
> From: Andrey Gusakov<dron_gus@mail.ru>
>
> Camera clock defined two times. One in init_clocks_off array with
> "cam" name, second in clksrcs array with "camera" name. Leave
> second definition because clock have divider.
>
> Signed-off-by: Andrey Gusakov<dron0gus@gmail.com>

Reviewed-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Kim Kukjin Nov. 12, 2012, 5:02 a.m. UTC | #3 
Sylwester Nawrocki wrote:
> 
> On 11/10/2012 03:07 PM, dron0gus@gmail.com wrote:
> > From: Andrey Gusakov<dron_gus@mail.ru>
> >
> > Camera clock defined two times. One in init_clocks_off array with
> > "cam" name, second in clksrcs array with "camera" name. Leave
> > second definition because clock have divider.
> >
> > Signed-off-by: Andrey Gusakov<dron0gus@gmail.com>
> 
> Reviewed-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>

Applied, thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
diff mbox

Patch

diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c64xx/clock.c
index cacbe45..b2d08fa 100644
--- a/arch/arm/mach-s3c64xx/clock.c
+++ b/arch/arm/mach-s3c64xx/clock.c
@@ -319,10 +319,6 @@  static struct clk init_clocks_off[] = {
 		.enable		= s3c64xx_sclk_ctrl,
 		.ctrlbit	= S3C_CLKCON_SCLK_MFC,
 	}, {
-		.name		= "cam",
-		.enable		= s3c64xx_sclk_ctrl,
-		.ctrlbit	= S3C_CLKCON_SCLK_CAM,
-	}, {
 		.name		= "sclk_jpeg",
 		.enable		= s3c64xx_sclk_ctrl,
 		.ctrlbit	= S3C_CLKCON_SCLK_JPEG,